Rob Lourens
c7d320d48e
* agentHost: dedupe concurrent _resumeSession calls per sessionId Concurrent _resumeSession(id) callers (e.g. an outdated-config refresh in sendMessage plus a getSessionMessages subscribe) each constructed a fresh CopilotAgentSession and ran it through _createAgentSession, whose this._sessions.set(id, …) on a DisposableMap synchronously disposed the first entry mid-initializeSession(). The result was a tight loop of 'Trying to add a disposable to a DisposableStore that has already been disposed' warnings (~550 in one repro) and a half-initialised session with no event subscriptions — the chat widget opens, but sending a message goes nowhere. Fix: - Add an _resumingSessions: Map<string, Promise<CopilotAgentSession>>; _resumeSession is now a thin wrapper that returns the in-flight promise when one exists, else delegates to a new _doResumeSession and memoizes the promise until it settles. - Stop registering sessions in _sessions inside _createAgentSession. Both callers (_doResumeSession and _materializeProvisional) now set _sessions only after initializeSession() succeeds, and dispose the freshly-constructed agentSession if it throws. This removes the DisposableMap.set footgun that disposed an in-flight entry from under its own init. Adds focused tests for the dedup contract: - concurrent calls for the same id share one promise + one _doResumeSession - inflight entry is cleared after resolution (next call re-invokes) - inflight entry is cleared after rejection (next call retries) - different ids resolve independently (Written by Copilot) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * agentHost: guard post-init _sessions.set against shutdown race Address Copilot review on #318636: now that _sessions.set is deferred until after initializeSession() resolves, an in-flight _resumeSession / _materializeProvisional whose init resolves AFTER dispose() -> shutdown() -> super.dispose() has run would call _sessions.set(...) on a disposed DisposableMap, leaking the session and reproducing the 'Trying to add a disposable to a DisposableStore that has already been disposed' warning this PR exists to eliminate. Extract a small _registerInitializedSession helper that bails (dispose + CancellationError) when _shutdownPromise is already set, and route both call sites through it. The provisional path additionally still removes its created worktree on cancel via the existing catch block. Add a focused unit test that exercises the helper directly with a fake session, simulating the shutdown-started state. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * launch skill: call out the transpile-client → preLaunch-skips-compile trap When 'out/' already exists from a prior 'npm run transpile-client', 'node build/lib/preLaunch.ts' will skip 'npm run compile' and you'll get a launched window whose built-in extensions fail to activate with 'Cannot find module .../extensions/.../out/...'. Document the trap in both prerequisites and troubleshooting, and add a 'node_modules / npm install' prereq. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * launch skill: tighten compile prereq + sign-in nudge Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Visual Studio Code - Open Source ("Code - OSS")
The Repository
This repository ("Code - OSS") is where we (Microsoft) develop the Visual Studio Code product together with the community. Not only do we work on code and issues here, but we also publish our roadmap, monthly iteration plans, and our endgame plans. This source code is available to everyone under the standard MIT license.
Visual Studio Code
Visual Studio Code is a distribution of the Code - OSS repository with Microsoft-specific customizations released under a traditional Microsoft product license.
Visual Studio Code combines the simplicity of a code editor with what developers need for their core edit-build-debug cycle. It provides comprehensive code editing, navigation, and understanding support along with lightweight debugging, a rich extensibility model, and lightweight integration with existing tools.
Visual Studio Code is updated monthly with new features and bug fixes. You can download it for Windows, macOS, and Linux on Visual Studio Code's website. To get the latest releases every day, install the Insiders build.
Contributing
There are many ways in which you can participate in this project, for example:
- Submit bugs and feature requests, and help us verify as they are checked in
- Review source code changes
- Review the documentation and make pull requests for anything from typos to new content.
If you are interested in fixing issues and contributing directly to the code base, please see the document How to Contribute, which covers the following:
- How to build and run from source
- The development workflow, including debugging and running tests
- Coding guidelines
- Submitting pull requests
- Finding an issue to work on
- Contributing to translations
Feedback
- Ask a question on Stack Overflow
- Request a new feature
- Upvote popular feature requests
- File an issue
- Connect with the extension author community on GitHub Discussions or Slack
- Follow @code and let us know what you think!
See our wiki for a description of each of these channels and information on some other available community-driven channels.
Related Projects
Many of the core components and extensions to VS Code live in their own repositories on GitHub. For example, the node debug adapter and the mono debug adapter repositories are separate from each other. For a complete list, please visit the Related Projects page on our wiki.
Bundled Extensions
VS Code includes a set of built-in extensions located in the extensions folder, including grammars and snippets for many languages. Extensions that provide rich language support (inline suggestions, Go to Definition) for a language have the suffix language-features. For example, the json extension provides coloring for JSON and the json-language-features extension provides rich language support for JSON.
Development Container
This repository includes a Visual Studio Code Dev Containers / GitHub Codespaces development container.
-
For Dev Containers, use the Dev Containers: Clone Repository in Container Volume... command which creates a Docker volume for better disk I/O on macOS and Windows.
- If you already have VS Code and Docker installed, you can also click here to get started. This will cause VS Code to automatically install the Dev Containers extension if needed, clone the source code into a container volume, and spin up a dev container for use.
-
For Codespaces, install the GitHub Codespaces extension in VS Code, and use the Codespaces: Create New Codespace command.
Docker / the Codespace should have at least 4 cores and 6 GB of RAM (8 GB recommended) to run a full build. See the development container README for more information.
Code of Conduct
This project has adopted the Microsoft Open Source Code of Conduct. For more information see the Code of Conduct FAQ or contact opencode@microsoft.com with any additional questions or comments.
License
Copyright (c) Microsoft Corporation. All rights reserved.
Licensed under the MIT license.