Pi-Hole/FTL
1
0
Fork 0
mirror of https://github.com/pi-hole/FTL.git synced 2026-07-01 18:45:39 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2910 from rdevshp/edns0_optlen0_fix

Browse Source 
fix OOB write in FTL_parse_pseudoheaders when optlen is 0
This commit is contained in:
Dominik
2026-06-13 17:43:29 +02:00
committed by GitHub
parent 57eb60ddec a0238d9987
commit 6ef7e94de5
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/edns0.c
+5 -1
View File
@@ -369,7 +369,11 @@ void FTL_parse_pseudoheaders(unsigned char *pheader, const size_t plen)
char *pp = pretty_payload;
for(unsigned int j = 0; j < optlen; j++)
pp += sprintf(pp, "0x%02X ", payload[j]);
pretty_payload[optlen*5 - 1] = '\0'; // Truncate away the trailing whitespace
// Truncate away the trailing whitespace
if(optlen)
pretty_payload[optlen*5 - 1] = '\0';
log_debug(DEBUG_EDNS0, "CPE-ID (payload size %u): \"%s\" (%s)",
optlen, payload, pretty_payload);
free(pretty_payload);