Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2025-12-20 02:38:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use document.body.dataset instead of defining a hidden <div>

Browse Source 
Signed-off-by: DL6ER <dl6er@dl6er.de>
This commit is contained in:
DL6ER
2025-03-09 20:13:18 +01:00
parent f8ef22572a
commit e873dfed2b
4 changed files with 3 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
login.lp
View File

@@ -9,7 +9,7 @@
mg.include('scripts/lua/header.lp','r')
?>
<body class="hold-transition layout-boxed login-page">
<body class="hold-transition layout-boxed login-page" data-apiurl="<?=pihole.api_url()?>">
<div class="box login-box" id="login-box">
<section style="padding: 15px;">
<div class="login-logo">
@@ -117,8 +117,6 @@ mg.include('scripts/lua/header.lp','r')
<strong><a href="https://pi-hole.net/donate/" rel="noopener" target="_blank"><i class="fa fa-heart text-red"></i> Donate</a></strong> if you found this useful.
</div>
</div>
<div id="webhome" style="display: none;"><?=webhome?></div>
<div id="api-url" style="display: none;"><?=pihole.api_url()?></div>
<script src="<?=pihole.fileversion('scripts/js/footer.js')?>"></script>
<script src="<?=pihole.fileversion('scripts/js/login.js')?>"></script>
</body>

2
scripts/js/footer.js
View File

@@ -8,7 +8,7 @@
/* global utils:false, moment:false */
var _isLoginPage = false;
const apiUrl = document.getElementById("api-url").textContent;
const apiUrl = document.body.dataset.apiurl;
const REFRESH_INTERVAL = {
logs: 500, // 0.5 sec (logs page)

1
scripts/lua/footer.lp
View File

@@ -66,7 +66,6 @@ end
</div>
<!-- ./wrapper -->
<div id="api-url" style="display: none;"><?=pihole.api_url()?></div>
<script src="<?=pihole.fileversion('scripts/js/footer.js')?>"></script>
<div id="advanced-info-data" style="display: none;" data-starttime="<?=starttime?>" data-endtime="<?=mg.time(true)?>" data-client-ip="<?=mg.request_info.remote_addr?>" data-tls="<?=tostring(is_secure)?>" data-xff="<?=x_forwarded_for?>"></div>

2
scripts/lua/header_authenticated.lp
View File

@@ -22,7 +22,7 @@ mg.include('header.lp','r')
<script src="<?=pihole.fileversion('vendor/chartjs-plugin-zoom/chartjs-plugin-zoom.min.js')?>"></script>
<script src="<?=pihole.fileversion('vendor/bstreeview/bstreeview.min.js')?>"></script>
</head>
<body class="<?=theme.name?> hold-transition sidebar-mini <? if pihole.boxedlayout() then ?>layout-boxed<? end ?> logged-in">
<body class="<?=theme.name?> hold-transition sidebar-mini <? if pihole.boxedlayout() then ?>layout-boxed<? end ?> logged-in" data-apiurl="<?=pihole.api_url()?>">
<noscript>
<!-- JS Warning -->
<div>