Pi-Hole/web
1
0
Fork 0
mirror of https://github.com/pi-hole/web.git synced 2026-08-23 06:39:09 +01:00
Code Issues Packages Projects Releases Wiki Activity
7,520 Commits 27 Branches 116 Tags
tweak/client-pattern-validator
Commit Graph
7520 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
DL6ER 0c3435d6df Rename validateHostnameStrict() -> validateHostname() 
The name only made sense next to a non-strict counterpart, and that one is
gone. Its comment claimed to reject characters invalid in DNS names, which
underscores are not - say what the regex actually does instead.

Signed-off-by: DL6ER <dl6er@dl6er.de>
 2026-08-22 07:48:32 +02:00
DL6ER e92e6b837b Fix and rename validateHostname() -> validateClientPattern() 
The regex was unanchored: `/[^<>;"]/` matched on the first character that was
not one of those four, so `evil<script>` passed. Output is escaped on render
anyway.

Its only caller is the client field in group management, which takes a host
name or an interface like `:eth0`. FTL matches both verbatim and only records
names of `[A-Za-z0-9._-]`, so we check exactly that.

Signed-off-by: DL6ER <dl6er@dl6er.de>
 2026-08-22 06:42:14 +02:00
yubiuserandGitHub e3f01cdaf4 build(deps-dev): bump the development-dependencies group with 3 updates (#3851) 2026-08-15 12:13:15 +02:00
dependabot[bot]andGitHub f4b7f88c1b build(deps-dev): bump the development-dependencies group with 3 updates 
Bumps the development-dependencies group with 3 updates: [eslint](https://github.com/eslint/eslint), [globals](https://github.com/sindresorhus/globals) and [postcss](https://github.com/postcss/postcss).


Updates `eslint` from 10.8.0 to 10.8.1
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](https://github.com/eslint/eslint/compare/v10.8.0...v10.8.1)

Updates `globals` from 17.9.0 to 17.10.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](https://github.com/sindresorhus/globals/compare/v17.9.0...v17.10.0)

Updates `postcss` from 8.5.25 to 8.5.26
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.5.25...8.5.26)

---
updated-dependencies:
- dependency-name: eslint
  dependency-version: 10.8.1
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: globals
  dependency-version: 17.10.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: postcss
  dependency-version: 8.5.26
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-08-15 10:02:49 +00:00
RD WebDesignandGitHub dddef4bcac Add data-bs-theme to unauthenticathed pages (#3849) 2026-08-14 15:26:54 -03:00
DominikandGitHub 9c8bd96415 Fix hexEncode() for code points above U+FFFF (#3846) 2026-08-14 20:22:42 +02:00
RD WebDesign 9394042586 Add data-bs-theme to unauthenticathed pages 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-08-13 19:42:34 -03:00
DL6ER 5ab5b26807 Encode six hex digits per code point in hexEncode() 
`hexEncode()` padded every code point to four hex digits and `hexDecode()`
chopped the string back into four-character groups. That works up to
`U+FFFF`, but code points go up to `U+10FFFF`: an emoji such as `U+1F4D2`
is encoded as the five-digit group `1f4d2`, after which the decoder is out
of step and returns garbage for the remainder of the string.

The tables carry the address/domain/client/name of each row in a
`data-address` (resp. `data-id`) attribute in this encoding, so a list
subscribed with an emoji in its address could neither be deleted nor
edited - we asked FTL to remove something that is not in the database and
it correctly answered `404`.

Widen both functions to six digits, which covers the whole Unicode range.
The encoding never leaves the page, so there is nothing to migrate.

Signed-off-by: DL6ER <dl6er@dl6er.de>
 2026-08-08 21:17:18 +02:00
yubiuserandGitHub b3fb926a69 build(deps): bump the github_action-dependencies group with 3 updates (#3844) 2026-08-08 12:45:36 +02:00
dependabot[bot]andGitHub 3b59f78a83 build(deps): bump the github_action-dependencies group with 3 updates 
Bumps the github_action-dependencies group with 3 updates: [github/codeql-action/init](https://github.com/github/codeql-action), [github/codeql-action/autobuild](https://github.com/github/codeql-action) and [github/codeql-action/analyze](https://github.com/github/codeql-action).


Updates `github/codeql-action/init` from 4.37.3 to 4.37.6
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81...5595ccaf912efad79be6eef63a5619ff05969be3)

Updates `github/codeql-action/autobuild` from 4.37.3 to 4.37.6
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81...5595ccaf912efad79be6eef63a5619ff05969be3)

Updates `github/codeql-action/analyze` from 4.37.3 to 4.37.6
- [Release notes](https://github.com/github/codeql-action/releases)
- [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md)
- [Commits](https://github.com/github/codeql-action/compare/e4fba868fa4b1b91e1fdab776edc8cfbe6e9fb81...5595ccaf912efad79be6eef63a5619ff05969be3)

---
updated-dependencies:
- dependency-name: github/codeql-action/init
  dependency-version: 4.37.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github_action-dependencies
- dependency-name: github/codeql-action/autobuild
  dependency-version: 4.37.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github_action-dependencies
- dependency-name: github/codeql-action/analyze
  dependency-version: 4.37.6
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: github_action-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-08-08 10:06:18 +00:00
RD WebDesignandGitHub d1836fda0b Fix #revServers-table after migrating to datatables v2 (#3839) 2026-08-06 04:50:58 -03:00
yubiuserandGitHub 9017c1a759 Update fontawesom in package.json to 7.3.1 (#3838) 2026-08-06 09:08:25 +02:00
yubiuser 174f5d637c Update fontawesom in package.json to 7.3.1 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-08-06 07:49:37 +02:00
RD WebDesign e21c6203a9 Fix revServers table after migrating to datatables v2 
- remove from the table footer some elements created by datatables.
  These elements are automatically created to allow table sorting, but the
  footer here is used as an interface to add new reverser servers. We
  don't need them. Also, the elements will interfere with the placeholder
  text (added using CSS, but only to completely empty cells).
- adjust CSS `.actions` class to force right aligned text on the footer.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-08-05 22:36:07 -03:00
yubiuserandGitHub 8e09bd063e build(deps-dev): bump the development-dependencies group across 1 directory with 6 updates (#3816) 2026-08-05 22:57:09 +02:00
yubiuser ddae3ef2bf Fix xo errors after AdminLTE4 rebase 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-08-05 22:25:12 +02:00
yubiuser ef5df418f2 Disable unicorn/name-replacements rule 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-08-05 22:15:03 +02:00
yubiuser d3eaf1c0f9 Revert "Fix unicorn/name-replacements errors" 
This reverts commit a16a6d67e2.
 2026-08-05 22:14:49 +02:00
yubiuser 2b27d3752e Fix unicorn/name-replacements errors 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-08-05 22:09:04 +02:00
yubiuser 07b56328dc Disable unicorn/consistent-boolean-name 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-08-05 21:57:30 +02:00
yubiuser d330f86540 Fix xo errors 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-08-05 21:57:30 +02:00
yubiuser 8124a01a8d Fix prettier complaints 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-08-05 21:56:52 +02:00
dependabot[bot]andyubiuser e4792c376b build(deps-dev): bump the development-dependencies group across 1 directory with 6 updates 
Bumps the development-dependencies group with 6 updates in the / directory:

| Package | From | To |
| --- | --- | --- |
| [autoprefixer](https://github.com/postcss/autoprefixer) | `10.5.0` | `10.5.4` |
| [eslint](https://github.com/eslint/eslint) | `10.5.0` | `10.7.0` |
| [globals](https://github.com/sindresorhus/globals) | `17.6.0` | `17.7.0` |
| [postcss](https://github.com/postcss/postcss) | `8.5.15` | `8.5.19` |
| [prettier](https://github.com/prettier/prettier) | `3.8.4` | `3.9.5` |
| [xo](https://github.com/xojs/xo) | `3.0.2` | `4.0.0` |

Updates `autoprefixer` from 10.5.0 to 10.5.4
- [Release notes](https://github.com/postcss/autoprefixer/releases)
- [Changelog](https://github.com/postcss/autoprefixer/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/autoprefixer/compare/10.5.0...10.5.4)

Updates `eslint` from 10.5.0 to 10.7.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Commits](https://github.com/eslint/eslint/compare/v10.5.0...v10.7.0)

Updates `globals` from 17.6.0 to 17.7.0
- [Release notes](https://github.com/sindresorhus/globals/releases)
- [Commits](https://github.com/sindresorhus/globals/compare/v17.6.0...v17.7.0)

Updates `postcss` from 8.5.15 to 8.5.19
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](https://github.com/postcss/postcss/compare/8.5.15...8.5.19)

Updates `prettier` from 3.8.4 to 3.9.5
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](https://github.com/prettier/prettier/compare/3.8.4...3.9.5)

Updates `xo` from 3.0.2 to 4.0.0
- [Release notes](https://github.com/xojs/xo/releases)
- [Commits](https://github.com/xojs/xo/compare/v3.0.2...v4.0.0)

---
updated-dependencies:
- dependency-name: autoprefixer
  dependency-version: 10.5.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: eslint
  dependency-version: 10.7.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: globals
  dependency-version: 17.7.0
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: postcss
  dependency-version: 8.5.16
  dependency-type: direct:development
  update-type: version-update:semver-patch
  dependency-group: development-dependencies
- dependency-name: prettier
  dependency-version: 3.9.5
  dependency-type: direct:development
  update-type: version-update:semver-minor
  dependency-group: development-dependencies
- dependency-name: xo
  dependency-version: 4.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: development-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-08-05 21:56:52 +02:00
Adam WarnerandGitHub 355815a83e Migrate to AdminLTE 4 / Bootstrap 5 (#3809) 2026-08-05 20:43:47 +01:00
RD WebDesign 64ced6c9e3 Update Fontawesome to version 7.3.1 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-08-05 00:25:36 -03:00
Adam WarnerandGitHub e16162ab0d Introduce agents.md (#3835) 2026-08-04 13:18:40 +01:00
Adam Warnerandyubiuser 03e4a6be95 applying reviewer suggestions 
Co-authored-by: yubiuser <yubiuser@users.noreply.github.com>
Signed-off-by: Adam Warner <github@promofaux.dev>
 2026-08-02 22:52:54 +01:00
RD WebDesignandGitHub 01e8530944 Fix merge conflict 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-08-02 18:27:06 -03:00
RD WebDesignandGitHub d156625334 Merge branch 'development' into new/adminLTE4 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-08-02 17:51:10 -03:00
Adam Warner ba6620148b Introduce agents.md 
Signed-off-by: Adam Warner <github@promofaux.dev>
 2026-08-02 17:48:29 +01:00
yubiuserandGitHub 3d7f5818e6 build(deps): bump actions/stale from 10.4.0 to 11.0.0 in the github_action-dependencies group (#3834) 2026-08-01 12:25:59 +02:00
dependabot[bot]andGitHub 2f4d70b46d build(deps): bump actions/stale in the github_action-dependencies group 
Bumps the github_action-dependencies group with 1 update: [actions/stale](https://github.com/actions/stale).


Updates `actions/stale` from 10.4.0 to 11.0.0
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](https://github.com/actions/stale/compare/1e223db275d687790206a7acac4d1a11bd6fe629...4391f3da665fdf50b6810c1a66712fb9ba21aa93)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: 11.0.0
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: github_action-dependencies
...

Signed-off-by: dependabot[bot] <support@github.com>
 2026-08-01 10:06:59 +00:00
yubiuserandGitHub af2bb6d7f5 Improve DNS upstream table (#3827) 2026-08-01 06:54:49 +02:00
yubiuser db57bf1e06 Filter table-selected upstreams from the custom upstream server input field 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-07-31 21:17:10 +02:00
yubiuserGitHubCopilot Autofix powered by AI
 		3fb6e7ad88 Also remove empty lines 
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-07-31 17:29:11 +02:00
RD WebDesignandGitHub 326eb0bcf4 Fix the functions used to validate CF server IPs (#3830) 2026-07-30 04:27:06 -03:00
RD WebDesign 527fe63e17 Remove duplicated selectors and adjust colors of card elements 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-30 02:11:12 -03:00
RD WebDesign 6a205a2c17 Replace class d-lg-none with d-xl-none on the query log table 
The previous theme used the `hidden-lg` class to hide this element on
screens larger than 1200px.

Now, we need to use `d-xl-none` to do the same.
 2026-07-30 01:47:01 -03:00
RD WebDesign 787815e757 Use new HTML markup for nav-tabs 
- put nav-tabs inside a card;
- the tabs (<ul> element) should be inside card-header;
- the tab-content should be inside card-body;
- adjust the margins of the nav-tab and remove the rounded corners

TODO:
  in some themes, the the selected tab background color and the tab-pane
  background are not matching. Also, all themes are showing different
  colors than we had before the migration. This is just a cosmetic issue
  and it will be adjusted later.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-29 23:19:16 -03:00
RD WebDesign eadba811e2 Fix the functions used to validate CF server IPs 
The functions should only accept IPs with an optional port:
- IPs are valid: "a.b.c.d"
- IPs with port ("a.b.c.d#p") are allowed if the port is valid
- network ranges (CIDR) should be rejected
- empty ports ("a.b.c.d#") should be rejected
- all other strings should be rejected

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-29 18:24:34 -03:00
RD WebDesignandGitHub 6bf0fb3571 Merge branch 'development' into new/adminLTE4 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-29 16:15:24 -03:00
RD WebDesignandGitHub e127974356 Show the API error message when adding from the query log fails (#3824) 2026-07-29 16:10:21 -03:00
RD WebDesignandGitHub a429cae2eb Fix typo in the validation regex (static DHCP lease table) (#3828) 2026-07-29 15:41:24 -03:00
RD WebDesign bc01ac0ce0 Fix modal markup 
- move buttons to the end of the modal-header
- remove the "hidden" attribute from the QR code element
- replace the old `.col-md-offset-3` class with the new `.offset-md-3`

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-29 01:31:14 -03:00
RD WebDesign af53bf7108 Fix typo in the validation regex (static DHCP lease table) 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-29 00:14:48 -03:00
RD WebDesignGitHubyubiuser
 		4378690c1d Include the domain in the error message title 
Co-authored-by: yubiuser <github@yubiuser.dev>
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-28 23:24:59 -03:00
yubiuser 4914bf747e Simplify selector 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-07-28 22:14:48 +02:00
yubiuser 2691919645 Fix DNS upstream table 
Signed-off-by: yubiuser <github@yubiuser.dev>
 2026-07-28 15:26:40 +02:00
RD WebDesignandGitHub 5027793d61 Merge branch 'development' into fix/query-log-cname-allow 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-28 00:45:15 -03:00
RD WebDesign 951acc599e Remove the old Alert Modal with and use showAlert() function 
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
 2026-07-28 00:44:39 -03:00