Commit Graph
27 Commits
Author SHA1 Message Date
DL6ERandAdam Warner 63d576b036 Fix interface tree, network row colours, chart tooltips and wide-table scrollbar
- The vendored bstreeview still emitted Bootstrap 3 collapse attributes
  (`data-toggle`/`data-target`), which Bootstrap 5 ignores, so expanding an
  interface only rotated the caret without revealing its details. Emit the
  `data-bs-*` attributes instead.
- The network overview colours each row by device activity, but Bootstrap 5
  paints the cell background over the row's `background-color`. Drop the
  now-conflicting `table-striped` and colour the row through the
  `--bs-table-bg` variable so the status colours (and the legend) apply again.
- Chart tooltips are positioned relative to their card's parent, but that
  element was not the tooltip's offset parent in the boxed layout, so tooltips
  were shifted far to the side. Make the ancestor `position: relative`.
- Keep the horizontal scrollbar visible on wide `.table-responsive` tables so
  it is clear the content scrolls rather than being cut off.

Signed-off-by: DL6ER <dl6er@dl6er.de>
2026-07-17 22:39:59 +01:00
89e65d8d08 Migrate layout shell to AdminLTE 4 / Bootstrap 5
Swap vendored AdminLTE 2.4.18 + Bootstrap 3.4.1 for AdminLTE 4.1.0 +
Bootstrap 5.3.8 (AdminLTE's dist CSS now bundles Bootstrap, so the
separate Bootstrap stylesheet is dropped; only its JS bundle remains).

Rewrite the page shell (header, header_authenticated, sidebar, footer)
to AdminLTE 4's app-wrapper/app-header/app-sidebar/app-main/app-content
structure and nav-sidebar/nav-treeview markup, and convert the dashboard
(index.lp) box/small-box markup to Bootstrap 5 cards as the first fully
migrated page.

Verified against a live container: fixed a chart.js tooltip lookup that
still targeted the old .box selector, restored the header logo mini/full
swap and sidebar user-panel collapse behavior that AdminLTE 2 used to
provide for free, and resolved a duplicate id="navigation" collision
with AdminLTE 4's own accessibility skip-link script.

Every other page still uses the old box/Bootstrap-3-grid/BS3-plugin
markup and will render incorrectly until the remaining migration phases
land.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Signed-off-by: Adam Warner <me@adamwarner.co.uk>
2026-07-17 22:38:11 +01:00
yubiuser 6f4186f7f2 Apply Copilit's suggestions III
Signed-off-by: yubiuser <github@yubiuser.dev>
2026-07-08 11:49:10 +02:00
yubiuser d335628c24 Fix remaining files
Signed-off-by: yubiuser <github@yubiuser.dev>
2026-07-08 09:59:52 +02:00
yubiuser 0876bdcb61 Fix chart.js
Signed-off-by: yubiuser <github@yubiuser.dev>
2026-07-08 09:23:47 +02:00
yubiuser 39504966a6 Use xo --fix to fix huge load of fixable issues, revert fixes to regex for manual inspection
Signed-off-by: yubiuser <github@yubiuser.dev>
2026-07-07 16:30:05 +02:00
vinayandvinaykulk621 4f8b47ddc1 fix: make changes as suggested and rebase with development branch
Signed-off-by: vinaykulk621 <kulkarnivinay621@gmail.com>
2026-05-23 13:50:23 +05:30
vinayandvinaykulk621 96e3a55f77 bug: multiline comments on doughnut chart
Signed-off-by: vinaykulk621 <kulkarnivinay621@gmail.com>
2026-05-23 13:48:28 +05:30
RD WebDesign e82df84638 Escape hostnames and IP addresses to avoid Stored XSS on network page and
charts tooltips (dashboard page)

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2026-03-19 19:38:26 -03:00
yubiuserandGitHub 94e8e909b7 Improve line graph tooltip (#3601) 2025-10-04 08:58:29 +02:00
RD WebDesign c6a2e8572e Trigger the offset effect when the mouse is over a legend item
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2025-09-19 17:11:10 -03:00
RD WebDesign ca57bcfb5c Include the upstream DNS server name to the link, when needed
The link must send the "upstream" parameter in exactly the same format used
by the "suggestions" API.
The format is: "upstream=<IP>#<port> (<servername>)".
This will ensure that when a link is clicked, the correct server name will
be highlighted in the SELECT element on the queries.lp page and no other
OPTION element will be created.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2025-09-16 16:47:03 -03:00
RD WebDesign af471bec94 Show the upstream server IP on the title tooltip
Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2025-09-15 23:03:26 -03:00
RD WebDesign 48666e1ffd Use an array to store upstream server IPs
This will avoid overwritting the IP when more than one upstream DNS server uses the same name

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2025-09-15 22:34:06 -03:00
RD WebDesign 52441b7b1b Remove unnecessary code
The outer `if` (line 92) already guarantees only 2 possible values.
If `isQueryTypeChart` is false, `isForwardDestinationChart` must be true.

Signed-off-by: RD WebDesign <github@rdwebdesign.com.br>
2025-09-15 22:11:44 -03:00
yubiuser 9dc305c2b5 Show tooltip of bar graphs below x-axis
Signed-off-by: yubiuser <github@yubiuser.dev>
2025-09-10 11:11:52 +02:00
yubiuser 41cdc9728c Show pointer only for clickable items
Signed-off-by: yubiuser <github@yubiuser.dev>
2025-07-12 09:20:05 +02:00
yubiuser a89fdda77e Only underline clickable legend items in pie charts
Signed-off-by: yubiuser <github@yubiuser.dev>
2025-07-12 09:10:34 +02:00
XhmikosR 0fa650d9bb charts.js: refactor to reduce complexity, improve readability and performance
Also

* drop jQuery usage
* move inline styles to CSS when possible
* switch to `a` tags for links otherwise use `p`

Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2025-06-28 07:45:11 +03:00
XhmikosRandGitHub 907441ca92 charts.j: use textContent when we don't need HTML
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2025-05-17 08:40:47 +03:00
XhmikosR 756239a6dd xo: enable strict mode
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2025-04-23 20:50:12 +03:00
XhmikosR f598a8e35c Manual xo fixes and suppressions
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2025-04-23 07:53:16 +03:00
XhmikosR f8a0a1d4ec Tighten xo rules
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2025-04-23 07:53:13 +03:00
DL6ER b524a2f4b6 Always use document.body.dataset.apiurl instead of the intermediate const apiUrl
Signed-off-by: DL6ER <dl6er@dl6er.de>
2025-03-31 22:00:16 +02:00
XhmikosR ac24b73312 Use pretty URLs when possible
Signed-off-by: XhmikosR <xhmikosr@gmail.com>
2025-03-29 09:54:05 +02:00
yubiuser e7f97baab1 Fix prefer-global-this error
Signed-off-by: yubiuser <github@yubiuser.dev>
2024-12-07 16:11:35 +01:00
yubiuser 1e922a8b29 Move all files from /scripts/pi-hole/ to /scripts/
Signed-off-by: yubiuser <github@yubiuser.dev>
2024-10-28 20:22:09 +01:00