Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-02 00:17:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix network crash when unpinning.

Browse Source
This commit is contained in:
Michelle Tang
2026-02-27 15:19:48 -05:00
parent 8fca0c69ac
commit 0bf54e6b45
1 changed files with 12 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/src/main/java/org/thoughtcrime/securesms/service/PinnedMessageManager.kt
View File

@@ -11,6 +11,7 @@ import org.thoughtcrime.securesms.database.model.MmsMessageRecord
import org.thoughtcrime.securesms.dependencies.AppDependencies
import org.thoughtcrime.securesms.recipients.RecipientId
import org.thoughtcrime.securesms.util.GroupUtil
import org.thoughtcrime.securesms.util.NetworkUtil
import org.whispersystems.signalservice.api.messages.SignalServiceDataMessage
/**
@@ -63,7 +64,17 @@ class PinnedMessageManager(
if (conversationRecipient.isGroup) {
GroupUtil.setDataMessageGroupContext(application, dataMessageBuilder, conversationRecipient.requireGroupId().requirePush())
}
AppDependencies.signalServiceMessageSender.sendSyncMessage(dataMessageBuilder.build())
// Best-effort attempt so that messages expire at the same time across devices but if it fails, we can ignore.
if (NetworkUtil.isConnected(application)) {
try {
AppDependencies.signalServiceMessageSender.sendSyncMessage(dataMessageBuilder.build())
} catch (e: Exception) {
Log.w(TAG, "Failed to send unpin sync message for message ${record.id}. Other devices will expire the pin independently.", e)
}
} else {
Log.w(TAG, "Failed to send unpin sync message for message ${record.id}. Other devices will expire the pin independently.")
}
}
}