Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-10-02 01:41:13 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix stale sheet heights when reporting expanded keyboard overlap.

Browse Source
This commit is contained in:
Alex Hart
2026-09-30 10:41:51 -03:00
parent 7820b43d4f
commit 0c137020fe
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
core/ui/src/main/java/org/signal/core/ui/compose/keyboard/KeyboardSheetScaffold.kt
+8 -4
View File
@@ -414,13 +414,17 @@ fun KeyboardSheetScaffold(
}
}
// Picks up drags as well as requests, so the controller reports where the sheet is heading.
// Picks up drags as well as requests, so the controller reports where the sheet is heading. The heights are read
// through rememberUpdatedState because this effect outlives the composition that launched it, which ran before any
// keyboard (and so any expandable height) was known.
val currentSheetHeightPx by rememberUpdatedState(sheetHeightPx)
val currentHeightPx by rememberUpdatedState(heightPx)
LaunchedEffect(sheetState) {
snapshotFlow { sheetState.targetValue == SheetAnchor.Expanded }
snapshotFlow { (sheetState.targetValue == SheetAnchor.Expanded) to (currentSheetHeightPx - currentHeightPx) }
.distinctUntilChanged()
.collect { expanded ->
.collect { (expanded, overlapPx) ->
controller.isExpanded = expanded
controller.expandedOverlapPx = if (expanded) sheetHeightPx - heightPx else 0
controller.expandedOverlapPx = if (expanded) overlapPx else 0
}
}