Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2026-04-02 00:17:41 +01:00
Code Issues Packages Projects Releases Wiki Activity

Improve video transcoding error logging.

Browse Source
This commit is contained in:
Greyson Parrelli
2026-02-20 14:22:45 -05:00
committed by Cody Henthorne
parent 7b31383b88
commit 1968438ebb
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
app/src/main/java/org/thoughtcrime/securesms/jobs/AttachmentCompressionJob.java
View File

@@ -45,6 +45,7 @@ import org.thoughtcrime.securesms.video.exceptions.VideoPostProcessingException;
import org.thoughtcrime.securesms.video.exceptions.VideoSourceException;
import org.thoughtcrime.securesms.video.interfaces.TranscoderCancelationSignal;
import org.thoughtcrime.securesms.video.postprocessing.Mp4FaststartPostProcessor;
import org.thoughtcrime.securesms.video.videoconverter.exceptions.CodecUnavailableException;
import org.thoughtcrime.securesms.video.videoconverter.exceptions.EncodingException;
import java.io.ByteArrayInputStream;
@@ -280,6 +281,11 @@ public final class AttachmentCompressionJob extends BaseJob {
percent));
}, outputStream, cancelationSignal);
} catch (EncodingException e) {
Log.w(TAG, "Video encoding failed"
+ " (hdr=" + e.isHdrInput
+ ", toneMap=" + e.toneMapApplied
+ ", decoder=" + e.decoderName
+ ", encoder=" + e.encoderName + ")", e);
throw new UndeliverableMessageException("Failure during encoding", e);
}
@@ -333,6 +339,16 @@ public final class AttachmentCompressionJob extends BaseJob {
}
}
} catch (VideoSourceException | EncodingException | MemoryFileException e) {
if (e instanceof EncodingException) {
EncodingException ee = (EncodingException) e;
Log.w(TAG, "Video encoding failed"
+ " (hdr=" + ee.isHdrInput
+ ", toneMap=" + ee.toneMapApplied
+ ", decoder=" + ee.decoderName
+ ", encoder=" + ee.encoderName + ")", e);
} else {
Log.w(TAG, "Video transcode failed: " + e.getClass().getSimpleName(), e);
}
if (attachment.size > constraints.getVideoMaxSize()) {
throw new UndeliverableMessageException("Duration not found, attachment too large to skip transcode", e);
} else {
@@ -343,8 +359,14 @@ public final class AttachmentCompressionJob extends BaseJob {
}
}
} catch (IOException | MmsException e) {
if (e instanceof CodecUnavailableException) {
Log.w(TAG, "All video codecs exhausted for this content: " + e.getMessage(), e);
} else {
Log.w(TAG, "Video transcode failed: " + e.getClass().getSimpleName(), e);
}
throw new UndeliverableMessageException("Failed to transcode", e);
} catch (RuntimeException e) {
Log.w(TAG, "Video transcode failed with runtime exception", e);
if (e.getCause() instanceof IOException) {
throw new UndeliverableMessageException("Failed to transcode", e);
} else {