Signal/Android
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Android.git synced 2025-12-27 14:40:22 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent flicker of user avatar in MyStories when moving between tabs.

Browse Source
This commit is contained in:
Alex Hart
2022-04-14 09:46:23 -03:00
committed by Greyson Parrelli
parent 35a9fddbb2
commit d4d3124a90
4 changed files with 22 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/src/main/java/org/thoughtcrime/securesms/stories/landing/LandingPayload.kt Normal file
View File

@@ -0,0 +1,12 @@
package org.thoughtcrime.securesms.stories.landing
/**
* Global Landing page payloads. Currently the only "pulse" we send out
* to ViewHolders is RESUMED.
*/
enum class LandingPayload {
/**
* Notifies view holders when the fragment is resumed.
*/
RESUMED
}

4
app/src/main/java/org/thoughtcrime/securesms/stories/landing/MyStoriesItem.kt
View File

@@ -33,6 +33,10 @@ object MyStoriesItem {
private val badgeView: BadgeImageView = itemView.findViewById(R.id.badge)
override fun bind(model: Model) {
if (payload.contains(LandingPayload.RESUMED)) {
return
}
itemView.setOnClickListener { model.onClick() }
thumbnail.setOnClickListener { model.onClickThumbnail() }

8
app/src/main/java/org/thoughtcrime/securesms/stories/landing/StoriesLandingFragment.kt
View File

@@ -79,7 +79,7 @@ class StoriesLandingFragment : DSLSettingsFragment(layoutId = R.layout.stories_l
override fun onResume() {
super.onResume()
adapter.notifyItemRangeChanged(0, adapter.itemCount)
adapter.notifyItemRangeChanged(0, adapter.itemCount, LandingPayload.RESUMED)
}
override fun bindAdapter(adapter: DSLSettingsAdapter) {
@@ -117,8 +117,10 @@ class StoriesLandingFragment : DSLSettingsFragment(layoutId = R.layout.stories_l
}
viewModel.state.observe(viewLifecycleOwner) {
adapter.submitList(getConfiguration(it).toMappingModelList())
emptyNotice.visible = it.hasNoStories
if (it.loadingState == StoriesLandingState.LoadingState.LOADED) {
adapter.submitList(getConfiguration(it).toMappingModelList())
emptyNotice.visible = it.hasNoStories
}
}
requireActivity().onBackPressedDispatcher.addCallback(

2
app/src/main/java/org/thoughtcrime/securesms/stories/landing/StoriesLandingItem.kt
View File

@@ -107,7 +107,7 @@ object StoriesLandingItem {
presentDateOrStatus(model)
setUpClickListeners(model)
if (payload.contains(STATUS_CHANGE)) {
if (payload.contains(STATUS_CHANGE) || payload.contains(LandingPayload.RESUMED)) {
return
}