Improve performance of link preview parsing

Co-authored-by: trevor-signal <131492920+trevor-signal@users.noreply.github.com>
This commit is contained in:
automated-signal
2024-08-02 17:47:55 -05:00
committed by GitHub
parent a6773ed710
commit 0ad4cf47b6

View File

@@ -290,8 +290,6 @@ const getHtmlDocument = async (
abortSignal: AbortSignal,
logger: Pick<LoggerType, 'warn'> = log
): Promise<HTMLDocument> => {
let result: HTMLDocument = emptyHtmlDocument();
const buffer = new Uint8Array(MAX_HTML_BYTES_TO_LOAD);
let bytesLoadedSoFar = 0;
@@ -313,8 +311,6 @@ const getHtmlDocument = async (
buffer.set(truncatedChunk, bytesLoadedSoFar);
bytesLoadedSoFar += truncatedChunk.byteLength;
result = parseHtmlBytes(buffer.slice(0, bytesLoadedSoFar), httpCharset);
const hasLoadedMaxBytes = bytesLoadedSoFar >= buffer.length;
if (hasLoadedMaxBytes) {
break;
@@ -326,6 +322,7 @@ const getHtmlDocument = async (
);
}
const result = parseHtmlBytes(buffer.slice(0, bytesLoadedSoFar), httpCharset);
return result;
};