Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-02-14 23:18:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix placeholder in Key Transparency string

Browse Source
This commit is contained in:
Fedor Indutny
2026-01-28 13:34:44 -08:00
committed by GitHub
parent b5d7179ae8
commit 369d1a3fdd
2 changed files with 20 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
_locales/en/messages.json
View File

@@ -835,7 +835,7 @@
"description": "A title of an education modal in Key Transparency section of SafetyNumberViewer when verification was unsuccessful"
},
"icu:SafetyNumberViewer__KeyTransparency__popup--fail__body": {
"messageformat": "Signal can no longer automatically verify the encryption for this chat. This is likely because Katie Hall changed their phone number. Verify end-to-end encryption manually by comparing the numbers on the previous screen or scanning the code on their device.",
"messageformat": "Signal can no longer automatically verify the encryption for this chat. This is likely because {name} changed their phone number. Verify end-to-end encryption manually by comparing the numbers on the previous screen or scanning the code on their device.",
"description": "A body of an education modal in Key Transparency section of SafetyNumberViewer when verification was unsuccessful"
},
"icu:SafetyNumberViewer__KeyTransparency__popup--unavailable__body": {

22
ts/components/SafetyNumberViewer.dom.tsx
View File

@@ -107,6 +107,7 @@ export function SafetyNumberViewer({
<KeyTransparency
i18n={i18n}
status={keyTransparencyStatus}
contact={contact}
checkKeyTransparency={checkKeyTransparency}
/>
);
@@ -140,6 +141,7 @@ export function SafetyNumberViewer({
type KeyTransparencyPropsType = Readonly<{
i18n: LocalizerType;
contact: ConversationType;
status: KeyTransparencyStatusType;
checkKeyTransparency: () => unknown;
}>;
@@ -147,6 +149,7 @@ type KeyTransparencyPropsType = Readonly<{
function KeyTransparency({
i18n,
status,
contact,
checkKeyTransparency,
}: KeyTransparencyPropsType): JSX.Element {
const [popup, setPopup] = useState<undefined | PopupPropsType['type']>();
@@ -298,18 +301,26 @@ function KeyTransparency({
</a>
</div>
{popup && <Popup i18n={i18n} type={popup} onClose={resetPopup} />}
{popup && (
<Popup
i18n={i18n}
contact={contact}
type={popup}
onClose={resetPopup}
/>
)}
</div>
);
}
type PopupPropsType = Readonly<{
i18n: LocalizerType;
contact: ConversationType;
type: 'ok' | 'fail' | 'unavailable';
onClose: () => void;
}>;
function Popup({ i18n, type, onClose }: PopupPropsType): JSX.Element {
function Popup({ i18n, contact, type, onClose }: PopupPropsType): JSX.Element {
let icon: 'check-circle' | 'info';
let title: string;
let body: string;
@@ -325,7 +336,12 @@ function Popup({ i18n, type, onClose }: PopupPropsType): JSX.Element {
title = i18n(
'icu:SafetyNumberViewer__KeyTransparency__popup--fail__title'
);
body = i18n('icu:SafetyNumberViewer__KeyTransparency__popup--fail__body');
body = i18n(
'icu:SafetyNumberViewer__KeyTransparency__popup--fail__body',
{
name: contact.title,
}
);
break;
case 'unavailable':
icon = 'info';