Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-02-15 07:28:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Release Notes Channel: Fix behavior when conversation is blocked

Browse Source
This commit is contained in:
yash-signal
2025-02-12 15:36:29 -05:00
committed by GitHub
parent 214de5b460
commit 5e73e1ae97
1 changed files with 23 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
ts/services/releaseNotesFetcher.ts
View File

@@ -172,11 +172,34 @@ export class ReleaseNotesFetcher {
log.info('ReleaseNotesFetcher: WebAPI unavailable');
throw new Error('WebAPI unavailable');
}
log.info('ReleaseNotesFetcher: Ensuring Signal conversation');
const signalConversation =
await window.ConversationController.getOrCreateSignalConversation();
const sortedNotes = [...notes].sort(
(a: ManifestReleaseNoteType, b: ManifestReleaseNoteType) =>
semver.compare(a.desktopMinVersion, b.desktopMinVersion)
);
const newestNote = last(sortedNotes);
strictAssert(newestNote, 'processReleaseNotes requires at least 1 note');
const versionWatermark = newestNote.desktopMinVersion;
if (signalConversation.isBlocked()) {
log.info(
`ReleaseNotesFetcher: Signal conversation is blocked, updating watermark to ${versionWatermark}`
);
drop(
window.textsecure.storage.put(
VERSION_WATERMARK_STORAGE_KEY,
versionWatermark
)
);
return;
}
const hydratedNotesWithRawAttachments = (
await Promise.all(
sortedNotes.map(async note => {
@@ -242,10 +265,6 @@ export class ReleaseNotesFetcher {
return;
}
log.info('ReleaseNotesFetcher: Ensuring Signal conversation');
const signalConversation =
await window.ConversationController.getOrCreateSignalConversation();
const messages: Array<MessageAttributesType> = [];
hydratedNotes.forEach(
({ hydratedNote: note, processedAttachment }, index) => {
@@ -320,10 +339,6 @@ export class ReleaseNotesFetcher {
signalConversation.set({ active_at: Date.now(), isArchived: false });
drop(signalConversation.updateUnread());
const newestNote = last(sortedNotes);
strictAssert(newestNote, 'processReleaseNotes requires at least 1 note');
const versionWatermark = newestNote.desktopMinVersion;
log.info(
`ReleaseNotesFetcher: Updating version watermark to ${versionWatermark}`
);