Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-02-25 12:16:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

Use socket timeout on updater downloads

Browse Source 
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
This commit is contained in:
automated-signal
2021-07-15 21:43:39 -07:00
committed by GitHub
parent d039b99eb5
commit d808ffb3ea
3 changed files with 33 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
ts/updater/common.ts
View File

@@ -39,6 +39,9 @@ const rimrafPromise = pify(rimraf);
const { platform } = process;
export const ACK_RENDER_TIMEOUT = 10000;
export const GOT_CONNECT_TIMEOUT = 2 * 60 * 1000;
export const GOT_LOOKUP_TIMEOUT = 2 * 60 * 1000;
export const GOT_SOCKET_TIMEOUT = 2 * 60 * 1000;
export type UpdaterInterface = {
force(): Promise<void>;
@@ -337,6 +340,13 @@ function getGotOptions(): GotOptions<null> {
'User-Agent': getUserAgent(packageJson.version),
},
useElectronNet: false,
timeout: {
connect: GOT_CONNECT_TIMEOUT,
lookup: GOT_LOOKUP_TIMEOUT,
// This timeout is reset whenever we get new data on the socket
socket: GOT_SOCKET_TIMEOUT,
},
};
}

12
ts/updater/macos.ts
View File

@@ -82,10 +82,20 @@ async function checkDownloadAndInstall(
const { fileName: newFileName, version: newVersion } = result;
if (fileName !== newFileName || !version || gt(newVersion, version)) {
const oldFileName = fileName;
const oldVersion = version;
deleteCache(updateFilePath, logger);
fileName = newFileName;
version = newVersion;
updateFilePath = await downloadUpdate(fileName, logger);
try {
updateFilePath = await downloadUpdate(fileName, logger);
} catch (error) {
// Restore state in case of download error
fileName = oldFileName;
version = oldVersion;
throw error;
}
}
if (!updateFilePath) {

13
ts/updater/windows.ts
View File

@@ -83,10 +83,21 @@ async function checkDownloadAndInstall(
const { fileName: newFileName, version: newVersion } = result;
if (fileName !== newFileName || !version || gt(newVersion, version)) {
const oldFileName = fileName;
const oldVersion = version;
deleteCache(updateFilePath, logger);
fileName = newFileName;
version = newVersion;
updateFilePath = await downloadUpdate(fileName, logger);
try {
updateFilePath = await downloadUpdate(fileName, logger);
} catch (error) {
// Restore state in case of download error
fileName = oldFileName;
version = oldVersion;
throw error;
}
}
const publicKey = hexToBinary(getFromConfig('updatesPublicKey'));