Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-02 00:07:56 +01:00
Code Issues Packages Projects Releases Wiki Activity

Limit embedded groupChange size

Browse Source
This commit is contained in:
trevor-signal
2026-02-19 13:20:27 -05:00
committed by GitHub
parent b9f88c1b65
commit de214384e0
1 changed files with 15 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
ts/textsecure/SendMessage.preload.ts
View File

@@ -112,6 +112,8 @@ import type {
const log = createLogger('SendMessage');
const MAX_EMBEDDED_GROUP_CHANGE_BYTES = 2048;
export type SendIdentifierData =
| {
accessKey: string;
@@ -416,7 +418,19 @@ class Message {
proto.groupV2 = new Proto.GroupContextV2();
proto.groupV2.masterKey = this.groupV2.masterKey;
proto.groupV2.revision = this.groupV2.revision;
proto.groupV2.groupChange = this.groupV2.groupChange || null;
const { groupChange } = this.groupV2;
if (groupChange) {
if (groupChange.byteLength <= MAX_EMBEDDED_GROUP_CHANGE_BYTES) {
proto.groupV2.groupChange = groupChange;
} else {
// As a message-size optimization, we do not embed large updates and receiving
// devices fetch them from the group server instead
log.info(
`Discarding oversized group change proto (${groupChange.byteLength} bytes)`
);
}
}
}
if (this.sticker) {
proto.sticker = new Proto.DataMessage.Sticker();