mirror of
https://github.com/signalapp/Signal-Desktop.git
synced 2026-04-02 00:07:56 +01:00
Send zero speakerHeight when someone is presenting
Co-authored-by: trevor-signal <trevor@signal.org>
This commit is contained in:
@@ -167,7 +167,11 @@ export function CallingPipRemoteVideo({
|
||||
}
|
||||
return nonRenderedRemoteParticipant(participant);
|
||||
});
|
||||
setGroupCallVideoRequest(participants, newHeight);
|
||||
setGroupCallVideoRequest(
|
||||
participants,
|
||||
// When there's a presenter, we do not want the SFU to prioritize the speaker feed
|
||||
activeGroupCallSpeaker.presenting ? 0 : newHeight
|
||||
);
|
||||
} else {
|
||||
setGroupCallVideoRequest(
|
||||
activeCall.remoteParticipants.map(nonRenderedRemoteParticipant),
|
||||
|
||||
@@ -220,6 +220,10 @@ export function GroupCallRemoteParticipants({
|
||||
prioritySortedParticipants,
|
||||
]);
|
||||
|
||||
const isSomeonePresenting =
|
||||
prioritySortedParticipants.length &&
|
||||
prioritySortedParticipants[0].presenting;
|
||||
|
||||
// Make sure we're not on a page that no longer exists (e.g. if people left the call)
|
||||
if (
|
||||
pageIndex >= gridParticipantsByPage.length &&
|
||||
@@ -457,7 +461,10 @@ export function GroupCallRemoteParticipants({
|
||||
}
|
||||
setGroupCallVideoRequest(
|
||||
videoRequest,
|
||||
clamp(gridParticipantHeight, 0, MAX_FRAME_HEIGHT)
|
||||
// When there's a presenter, we do not want the SFU to prioritize the speaker
|
||||
isSomeonePresenting
|
||||
? 0
|
||||
: clamp(gridParticipantHeight, 0, MAX_FRAME_HEIGHT)
|
||||
);
|
||||
}, [
|
||||
devicePixelRatio,
|
||||
@@ -469,6 +476,7 @@ export function GroupCallRemoteParticipants({
|
||||
setGroupCallVideoRequest,
|
||||
videoRequestMode,
|
||||
participantsOnOtherPages,
|
||||
isSomeonePresenting,
|
||||
]);
|
||||
|
||||
return (
|
||||
|
||||
Reference in New Issue
Block a user