Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-04-02 08:13:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix optimization path for unicodeSlice

Browse Source 
Co-authored-by: trevor-signal <131492920+trevor-signal@users.noreply.github.com>
This commit is contained in:
automated-signal
2026-03-16 15:37:51 -05:00
committed by GitHub
parent f87188015e
commit fdfecdb5d9
2 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
ts/test-node/util/unicodeSlice_test.node.ts
View File

@@ -31,6 +31,7 @@ describe('unicodeSlice()', () => {
test('multi-byte char', 'x€x', 1, 4, '€', 3);
test('multi-byte char slice before end', '€', 1, 3, '', 0);
test('multi-byte char slice after start', '€', 2, 4, '', 0);
test('ignores utf-16 length', '€123', 0, 4, '€1', 4);
test('emoji', 'x👩‍👩‍👧‍👦x', 1, 26, '👩‍👩‍👧‍👦', 25);
test('emoji slice before end', 'x👩‍👩‍👧‍👦x', 1, 25, '', 0);

2
ts/util/unicodeSlice.std.ts
View File

@@ -21,7 +21,7 @@ export function unicodeSlice(
end: number
): string {
// Optimization: whole string fits into the range, return as is
if (begin === 0 && end >= input.length) {
if (begin === 0 && end >= Buffer.byteLength(input)) {
return input;
}