Commit Graph

3703 Commits

Author SHA1 Message Date
Scott Nonnenberg 3bbbf65a6b Fix iOS: tail, blue partial border, extra attachment space
Turns out that display: inline on the img tag resulted in a mysterious
3px of space added below it.
2018-04-13 18:10:52 -07:00
Scott Nonnenberg feb68b24b4 Fix lint issues in message_receiver.js 2018-04-13 18:10:52 -07:00
Scott Nonnenberg a806f32675 Fix message_receiver 2018-04-13 18:10:52 -07:00
Scott Nonnenberg 04d186c05a Conversation.loadQuoteThumbnail: Be resilient to no attachments 2018-04-13 18:10:52 -07:00
Scott Nonnenberg a6467d4fda Constrain 'start recording' event listener to capture-audio only
(it was firing when clicking on a microphone icon in quotation!)
2018-04-13 18:10:52 -07:00
Scott Nonnenberg 06c70b0ff4 Don't fail message load if we can't load quote thumbnail 2018-04-13 18:10:51 -07:00
Scott Nonnenberg 3bbb9f535a Load thumbnail even if we have the full message in hand
This is important for now, when we aren't generating our own thumbnails
2018-04-13 18:10:51 -07:00
Scott Nonnenberg c283ba1a12 Remove pointer cursor when clicking on quote won't do anything 2018-04-13 18:10:51 -07:00
Scott Nonnenberg 9ad55c803f Fix handling attachment thumbnails using thumbnail key 2018-04-13 18:10:51 -07:00
Scott Nonnenberg 6413e75f82 iOS: Handle portrait image that doesn't fill message box
It would have rounded corners inside of the bubble, which is not what
we want. This makes the bubble itself have the rounded corners, and then
it cuts off anything that would extend past its edges.
2018-04-13 18:10:51 -07:00
Scott Nonnenberg fce9bb7342 Move to central MIME functions, remove some console.log
And generally address PR feedback.
2018-04-13 18:10:51 -07:00
Scott Nonnenberg f255cbcbe3 Move to white background for ios replies, hairline bottom border 2018-04-13 18:10:50 -07:00
Scott Nonnenberg 32925ed026 Load attachment data for quotedMessages, processMessage on add
Not ideal that it loads it twice, but AttachmentView is so selfish with
its blob and objectUrl!
2018-04-13 18:10:50 -07:00
Scott Nonnenberg d91f40177e Quote.tsx: Fix tslint errors
I really need to get tslint editor integration in place.
2018-04-13 18:10:50 -07:00
Scott Nonnenberg 557ea55531 Quotes/iOS: Fix bug where large quote content would smoosh icon 2018-04-13 18:10:50 -07:00
Scott Nonnenberg a0b1dea693 Introduce a bit of color to the message/attachment style guide 2018-04-13 18:10:50 -07:00
Scott Nonnenberg c747c55b37 MessageReceiver: Translate from BigNumber to number for quote id 2018-04-13 18:10:50 -07:00
Scott Nonnenberg 0100e279f5 MessageView: Make Quotes resilient to re-renders 2018-04-13 18:10:50 -07:00
Scott Nonnenberg b458c7d449 android-dark: Constrain light play icon to with peer image 2018-04-13 18:10:49 -07:00
Scott Nonnenberg bdaebc24ae A few tweaks for the android-dark theme 2018-04-13 18:10:49 -07:00
Scott Nonnenberg 087dd0f758 Support for iOS theme 2018-04-13 18:10:49 -07:00
Scott Nonnenberg 644bc9e6fb Fix problem of squished quote icons and images 2018-04-13 18:10:49 -07:00
Scott Nonnenberg 127a90c4f6 Removed unused aspect ratio mixin 2018-04-13 18:10:49 -07:00
Scott Nonnenberg 5412ce051e preload.js: Fix quote support, load Quote properly 2018-04-13 18:10:49 -07:00
Scott Nonnenberg fc330ef854 Quote loading: Check for in-memory message until we get one 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 92a89a8e41 Fix MessageView test: p -> div 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 2243e348f1 Wire up fake window.Signal.HTML because it's captured on load 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 0f8dd7e2db Fix a number of lint failures 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 1cc0633786 Full support for quotations in Android theme 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 47a3acd5c9 Remove models/messages + models/messages from jscs run 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 5602241a0c Eliminate eslint-generated triple-parents 2018-04-13 18:10:47 -07:00
Scott Nonnenberg 5c2936bdd6 Turns out that we call validateNumber() on group conversations! 2018-04-13 18:10:47 -07:00
Scott Nonnenberg d5043eb9cf MessageReceiver: Can't use arrow function if it is to be new'd 2018-04-13 18:10:47 -07:00
Scott Nonnenberg e99192dca7 Unleash eslint on models/messages.js
Fun fact: eslint was not running on this file, despite the eslint
directives previously in the file!
2018-04-13 18:10:47 -07:00
Scott Nonnenberg 33ef967dd7 Unleash eslint on models/conversations.js 2018-04-13 18:10:45 -07:00
Scott Nonnenberg 054d3887a1 Quotes: The full pipeline into the database
1. MessageReceiver always pulls down thumbnails included in quotes
2. Message.upgradeSchema has a new schema that puts all thumbnails on
   disk just like happens with full attachments.
3. handleDataMessage pipes quote from dataMessage into the final message
   destined for the database
2018-04-13 18:05:45 -07:00
Scott Nonnenberg e69586200a Unleash eslint on message_receiver.js - lots of change 2018-04-13 18:05:45 -07:00
Scott Nonnenberg 21bf02c94d Fixed examples in Quote.md, rough Android visuals 2018-04-13 18:05:44 -07:00
Scott Nonnenberg 6653123671 Move quote-related examples from Message.md to Quote.md 2018-04-13 18:05:44 -07:00
Scott Nonnenberg b4ce79cac0 Reply -> Quote 2018-04-13 18:05:43 -07:00
Scott Nonnenberg 2def6afe45 message_view.js: eslint fixes and a bit of fixup 2018-04-13 18:05:43 -07:00
Scott Nonnenberg 09c3fbc5e2 Style guide: All permutations of text reply to diff. quote types 2018-04-13 18:05:43 -07:00
Scott Nonnenberg ad58799269 Update protos to reflect recent quotation-related updates
Updating to be current with these two comments in libsignal-service-java

https://github.com/signalapp/libsignal-service-java/commit/2e4aa848960d8a634457c3aa947824b4631ff608#diff-c525e47fbed26da2110c8a7c37a37031

https://github.com/signalapp/libsignal-service-java/commit/4f07b9e85ebd4bf2dc2a9b3b33a748d523803c5f#diff-c525e47fbed26da2110c8a7c37a37031
2018-04-13 18:05:42 -07:00
Scott Nonnenberg ae043bf239 In iOS theme, join attachment bubble with caption bubble 2018-04-13 18:05:42 -07:00
Scott Nonnenberg 3a76c3c86e Styleguide: Incoming/outgoing attachments of all types 2018-04-13 18:05:42 -07:00
Daniel Gasienica 1206b3c448 Remove Conversation Message Preview After Message Has Expired
- [x] Skip timestamp update for `verified-change` and expiring messages to
      prevent them to bump to the top of the conversation list.
- [x] Skip message preview (`lastMessage`) update for `verified-change` messages
      since they don’t contain any message body.
- [x] Reset last message if conversation is empty.

Fixes https://github.com/signalapp/Signal-Desktop/issues/980.
2018-04-13 14:27:02 -04:00
Daniel Gasienica 5f8148d3da Bind to Conversation lazily to prevent style guide errors 2018-04-13 14:26:01 -04:00
Daniel Gasienica 560cc4e149 Set dynamic parameter last 2018-04-11 19:46:23 -04:00
Daniel Gasienica 0daccee209 Enable TSLint Mocha rules 2018-04-11 19:45:48 -04:00
Daniel Gasienica 9d159da79c Add Microsoft contributed TSlint rules: tslint-microsoft-contrib 2018-04-11 19:45:31 -04:00