Commit Graph

3723 Commits

Author SHA1 Message Date
Scott Nonnenberg e66f9faf33 MessageView refactor: reply -> quote 2018-04-20 15:23:51 -07:00
Scott Nonnenberg d29162f3b6 CSS Refactor: Pull quote CSS out from parent classes
This is to prepare for it to be shown in the message composition area.
2018-04-20 15:23:50 -07:00
Scott Nonnenberg b4ff223d18 Refactor: Push selector logic for quote props into Message model 2018-04-20 15:23:49 -07:00
Scott Nonnenberg d0b11c59f5 Eslintify conversation_view.js 2018-04-20 15:23:49 -07:00
Scott Nonnenberg 26e4e97592 Tighten up CSS
- Remove extra padding at top of Android bubbles, via sibling selector
- Don't include .attachments, .quote-wrapper, .content in bubble unless
  we actually need them. This allows for sibling selectors.
- This is a different technique for adding the ReactWrapperView for
  quotes - it is now appended to the DOM instead of attaching to
  something already in the DOM. This allows us to use .remove(), so it's
  a bit cleaner.
- Users of ReactWrapperView can now specify tagName and className
2018-04-20 15:23:47 -07:00
Scott Nonnenberg 30957341e4 Show three dot icon next to message on hover
But only if it doesn't have an error.

Also: reformatted message template in legacy_templates.js to match what
is in background.html for easier diffing.
2018-04-20 15:23:47 -07:00
Scott Nonnenberg a563dc8b37 Style Guide: Additional message examples, a few fixes to enable 2018-04-20 15:23:47 -07:00
Scott Nonnenberg 6a4acc813c iOS: Center images in bubble, shrink bubble down to image size 2018-04-20 15:23:46 -07:00
Scott Nonnenberg 5af5bbdb0f Add style guide examples for portrait/landscape images 2018-04-20 15:23:46 -07:00
Bisaloo 89d3078e2a Fix beta install instructions for debian-based linux (#2262) 2018-04-19 08:56:08 -07:00
Scott Nonnenberg 3dbc550db2 v1.8.0-beta.1
Receive quoted replies (#2244)

iOS theme: one bubble for both attachment and message contents (#2244)

Improve URL Auto-Linking In Messages (#2240)

Redact More Variants Of Paths In Stack Traces (#2229)

Fixed: Conversation message preview would sometimes continue to show after message disappeared (https://github.com/signalapp/Signal-Desktop/commit/1206b3c448635c27dedb81378bdcb2e8fc194f4d)

Dev: Introduce React, TypeScript, TSLint and React-StyleGuidist (#2219 and #2232)
v1.8.0-beta.1
2018-04-16 13:14:18 -07:00
Scott Nonnenberg 8fa0912fb3 Receive quoted replies, collapsed iOS bubbles (#2244)
Complete support for receiving quoted replies, and a big change to the iOS theme. Instead of attachments showing up in a separate bubble from their associated caption, they are now in the same bubble.
2018-04-16 13:10:10 -07:00
Scott Nonnenberg e3d15d80f6 Quote.md: Fix image example, add examples for attachment + reply 2018-04-16 13:02:51 -07:00
Scott Nonnenberg bb9859ca61 Make iOS quote theming apply in the message detail screen 2018-04-16 12:30:28 -07:00
Scott Nonnenberg 000dc3a159 Handle attachment load failure for quoted message 2018-04-16 12:17:13 -07:00
Scott Nonnenberg f1ff040842 Finish type definition for _mapQuotedAttachments 2018-04-16 12:16:34 -07:00
Scott Nonnenberg 73e1498403 messages.json: Fix typo in replacement string 2018-04-16 12:16:11 -07:00
Scott Nonnenberg 4e9abdf348 MessageView: Call the proper render method on change event 2018-04-13 18:44:19 -07:00
Scott Nonnenberg 7bd747a796 ConversationContext: conversationType => type
And a group conversation example to messages.md
2018-04-13 18:10:52 -07:00
Scott Nonnenberg d8d803d36d Center and limit the size of non-square thumbnails in quotes 2018-04-13 18:10:52 -07:00
Scott Nonnenberg 3bbbf65a6b Fix iOS: tail, blue partial border, extra attachment space
Turns out that display: inline on the img tag resulted in a mysterious
3px of space added below it.
2018-04-13 18:10:52 -07:00
Scott Nonnenberg feb68b24b4 Fix lint issues in message_receiver.js 2018-04-13 18:10:52 -07:00
Scott Nonnenberg a806f32675 Fix message_receiver 2018-04-13 18:10:52 -07:00
Scott Nonnenberg 04d186c05a Conversation.loadQuoteThumbnail: Be resilient to no attachments 2018-04-13 18:10:52 -07:00
Scott Nonnenberg a6467d4fda Constrain 'start recording' event listener to capture-audio only
(it was firing when clicking on a microphone icon in quotation!)
2018-04-13 18:10:52 -07:00
Scott Nonnenberg 06c70b0ff4 Don't fail message load if we can't load quote thumbnail 2018-04-13 18:10:51 -07:00
Scott Nonnenberg 3bbb9f535a Load thumbnail even if we have the full message in hand
This is important for now, when we aren't generating our own thumbnails
2018-04-13 18:10:51 -07:00
Scott Nonnenberg c283ba1a12 Remove pointer cursor when clicking on quote won't do anything 2018-04-13 18:10:51 -07:00
Scott Nonnenberg 9ad55c803f Fix handling attachment thumbnails using thumbnail key 2018-04-13 18:10:51 -07:00
Scott Nonnenberg 6413e75f82 iOS: Handle portrait image that doesn't fill message box
It would have rounded corners inside of the bubble, which is not what
we want. This makes the bubble itself have the rounded corners, and then
it cuts off anything that would extend past its edges.
2018-04-13 18:10:51 -07:00
Scott Nonnenberg fce9bb7342 Move to central MIME functions, remove some console.log
And generally address PR feedback.
2018-04-13 18:10:51 -07:00
Scott Nonnenberg f255cbcbe3 Move to white background for ios replies, hairline bottom border 2018-04-13 18:10:50 -07:00
Scott Nonnenberg 32925ed026 Load attachment data for quotedMessages, processMessage on add
Not ideal that it loads it twice, but AttachmentView is so selfish with
its blob and objectUrl!
2018-04-13 18:10:50 -07:00
Scott Nonnenberg d91f40177e Quote.tsx: Fix tslint errors
I really need to get tslint editor integration in place.
2018-04-13 18:10:50 -07:00
Scott Nonnenberg 557ea55531 Quotes/iOS: Fix bug where large quote content would smoosh icon 2018-04-13 18:10:50 -07:00
Scott Nonnenberg a0b1dea693 Introduce a bit of color to the message/attachment style guide 2018-04-13 18:10:50 -07:00
Scott Nonnenberg c747c55b37 MessageReceiver: Translate from BigNumber to number for quote id 2018-04-13 18:10:50 -07:00
Scott Nonnenberg 0100e279f5 MessageView: Make Quotes resilient to re-renders 2018-04-13 18:10:50 -07:00
Scott Nonnenberg b458c7d449 android-dark: Constrain light play icon to with peer image 2018-04-13 18:10:49 -07:00
Scott Nonnenberg bdaebc24ae A few tweaks for the android-dark theme 2018-04-13 18:10:49 -07:00
Scott Nonnenberg 087dd0f758 Support for iOS theme 2018-04-13 18:10:49 -07:00
Scott Nonnenberg 644bc9e6fb Fix problem of squished quote icons and images 2018-04-13 18:10:49 -07:00
Scott Nonnenberg 127a90c4f6 Removed unused aspect ratio mixin 2018-04-13 18:10:49 -07:00
Scott Nonnenberg 5412ce051e preload.js: Fix quote support, load Quote properly 2018-04-13 18:10:49 -07:00
Scott Nonnenberg fc330ef854 Quote loading: Check for in-memory message until we get one 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 92a89a8e41 Fix MessageView test: p -> div 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 2243e348f1 Wire up fake window.Signal.HTML because it's captured on load 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 0f8dd7e2db Fix a number of lint failures 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 1cc0633786 Full support for quotations in Android theme 2018-04-13 18:10:48 -07:00
Scott Nonnenberg 47a3acd5c9 Remove models/messages + models/messages from jscs run 2018-04-13 18:10:48 -07:00