Remove explicit percentile configuration

2026-04-19 00:18:42 +01:00 · 2026-02-20 14:55:19 -06:00
parent d87cf01a9b
commit 541e93fc98
17 changed files with 0 additions and 25 deletions
--- a/service/src/main/java/org/whispersystems/textsecuregcm/auth/RegistrationLockVerificationManager.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/auth/RegistrationLockVerificationManager.java
@@ -125,7 +125,6 @@ public class RegistrationLockVerificationManager {
    final DistributionSummary registrationLockIdleDays = DistributionSummary
        .builder(name(RegistrationLockVerificationManager.class, "registrationLockIdleDays"))
        .tags(additionalTags)
-        .publishPercentiles(0.75, 0.95, 0.99, 0.999)
        .distributionStatisticExpiry(Duration.ofHours(2))
        .register(Metrics.globalRegistry);

--- a/service/src/main/java/org/whispersystems/textsecuregcm/backup/BackupManager.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/backup/BackupManager.java
@@ -210,12 +210,10 @@ public class BackupManager {

      DistributionSummary.builder(NUM_OBJECTS_SUMMARY_NAME)
          .tags(tags)
-          .publishPercentileHistogram()
          .register(Metrics.globalRegistry)
          .record(storedBackupAttributes.numObjects());
      DistributionSummary.builder(BYTES_USED_SUMMARY_NAME)
          .tags(tags)
-          .publishPercentileHistogram()
          .register(Metrics.globalRegistry)
          .record(storedBackupAttributes.bytesUsed());
    }
@@ -729,7 +727,6 @@ public class BackupManager {
            concurrentDeletes)
        .count()
        .doOnSuccess(itemsRemoved -> DistributionSummary.builder(DELETE_COUNT_DISTRIBUTION_NAME)
-            .publishPercentileHistogram(true)
            .register(Metrics.globalRegistry)
            .record(itemsRemoved))
        .then()
--- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/DeviceController.java
@@ -390,7 +390,6 @@ public class DeviceController {

              if (response != null && response.getStatus() == Response.Status.OK.getStatusCode()) {
                accountAndSample.second().stop(Timer.builder(WAIT_FOR_LINKED_DEVICE_TIMER_NAME)
-                    .publishPercentileHistogram(true)
                    .tags(Tags.of(UserAgentTagUtil.getPlatformTag(userAgent)))
                    .register(Metrics.globalRegistry));
              }
@@ -602,7 +601,6 @@ public class DeviceController {
            .whenComplete((response, throwable) -> {
              if (response != null && response.getStatus() == Response.Status.OK.getStatusCode()) {
                accountAndSample.second().stop(Timer.builder(WAIT_FOR_TRANSFER_ARCHIVE_TIMER_NAME)
-                    .publishPercentileHistogram(true)
                    .tags(Tags.of(
                        UserAgentTagUtil.getPlatformTag(userAgent),
                        primaryPlatformTag(accountAndSample.first())))
--- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/KeepAliveController.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/KeepAliveController.java
@@ -60,7 +60,6 @@ public class KeepAliveController {

        Timer.builder(CLOSED_CONNECTION_AGE_DISTRIBUTION_NAME)
            .tags(Tags.of(UserAgentTagUtil.getPlatformTag(context.getClient().getUserAgent())))
-            .publishPercentileHistogram(true)
            .register(Metrics.globalRegistry)
            .record(age);
      }
--- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/MessageController.java
@@ -147,12 +147,10 @@ public class MessageController {

    INDIVIDUAL_MESSAGE_LATENCY_TIMER = Timer.builder(timerName)
        .tags(multiRecipientTagName, "false")
-        .publishPercentileHistogram(true)
        .register(Metrics.globalRegistry);

    MULTI_RECIPIENT_MESSAGE_LATENCY_TIMER = Timer.builder(timerName)
        .tags(multiRecipientTagName, "true")
-        .publishPercentileHistogram(true)
        .register(Metrics.globalRegistry);
  }

--- a/service/src/main/java/org/whispersystems/textsecuregcm/controllers/RegistrationController.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/controllers/RegistrationController.java
@@ -56,7 +56,6 @@ public class RegistrationController {

  private static final DistributionSummary REREGISTRATION_IDLE_DAYS_DISTRIBUTION = DistributionSummary
      .builder(name(RegistrationController.class, "reregistrationIdleDays"))
-      .publishPercentiles(0.75, 0.95, 0.99, 0.999)
      .distributionStatisticExpiry(Duration.ofHours(2))
      .register(Metrics.globalRegistry);

--- a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/BackupMetrics.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/BackupMetrics.java
@@ -57,7 +57,6 @@ public class BackupMetrics {
      final boolean oversize,
      final Optional<Long> backupLength) {
    DistributionSummary.builder(MESSAGE_BACKUP_SIZE_NAME)
-        .publishPercentileHistogram(true)
        .tags(Tags.of(
            UserAgentTagUtil.getPlatformTag(authenticatedBackupUser.userAgent()),
            Tag.of("tier", authenticatedBackupUser.backupLevel().name().toLowerCase()),
--- a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MessageMetrics.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MessageMetrics.java
@@ -86,7 +86,6 @@ public final class MessageMetrics {
    UserAgentTagUtil.getClientVersionTag(userAgent, clientReleaseManager).ifPresent(tags::add);

    Timer.builder(DELIVERY_LATENCY_TIMER_NAME)
-        .publishPercentileHistogram(true)
        .tags(tags)
        .register(metricRegistry)
        .record(Duration.between(Instant.ofEpochMilli(serverTimestamp), Instant.now()));
--- a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MicrometerAwsSdkMetricPublisher.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/MicrometerAwsSdkMetricPublisher.java
@@ -149,7 +149,6 @@ public class MicrometerAwsSdkMetricPublisher implements MetricPublisher {

      DistributionSummary.builder(API_CALL_RETRY_COUNT_DISTRIBUTION_NAME)
          .tags(tags)
-          .publishPercentileHistogram(true)
          .register(Metrics.globalRegistry)
          .record(retryCount);

@@ -179,21 +178,18 @@ public class MicrometerAwsSdkMetricPublisher implements MetricPublisher {
      Optional.ofNullable(httpMetricsByName.get("ConcurrencyAcquireDuration"))
          .ifPresent(channelAcquisitionDurationMetricRecord -> Timer.builder(CHANNEL_ACQUISITION_TIMER_NAME)
              .tags(attemptTags)
-              .publishPercentileHistogram(true)
              .register(Metrics.globalRegistry)
              .record((Duration) channelAcquisitionDurationMetricRecord.value()));

      Optional.ofNullable(httpMetricsByName.get("LeasedConcurrency"))
          .ifPresent(concurrentRequestsMetricRecord -> DistributionSummary.builder(CONCURRENT_REQUESTS_DISTRIBUTION_NAME)
              .tags(attemptTags)
-              .publishPercentileHistogram(true)
              .register(Metrics.globalRegistry)
              .record((int) concurrentRequestsMetricRecord.value()));

      Optional.ofNullable(httpMetricsByName.get("PendingConcurrencyAcquires"))
          .ifPresent(pendingChannelAcquisitionsMetricRecord -> DistributionSummary.builder(PENDING_CHANNEL_ACQUISITIONS_DISTRIBUTION_NAME)
              .tags(attemptTags)
-              .publishPercentileHistogram(true)
              .register(Metrics.globalRegistry)
              .record((int) pendingChannelAcquisitionsMetricRecord.value()));
    });
--- a/service/src/main/java/org/whispersystems/textsecuregcm/metrics/OpenWebSocketCounter.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/metrics/OpenWebSocketCounter.java
@@ -85,7 +85,6 @@ public class OpenWebSocketCounter {

    context.addWebsocketClosedListener((_, statusCode, _) -> {
      sample.stop(Timer.builder(durationTimerName)
-          .publishPercentileHistogram(true)
          .tags(tagsWithClientPlatform)
          .register(Metrics.globalRegistry));

--- a/service/src/main/java/org/whispersystems/textsecuregcm/providers/MultiRecipientMessageProvider.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/providers/MultiRecipientMessageProvider.java
@@ -36,7 +36,6 @@ public class MultiRecipientMessageProvider implements MessageBodyReader<SealedSe

  private static final DistributionSummary RECIPIENT_COUNT_DISTRIBUTION = DistributionSummary
      .builder(name(MultiRecipientMessageProvider.class, "recipients"))
-      .publishPercentileHistogram(true)
      .register(Metrics.globalRegistry);

  @Override
--- a/service/src/main/java/org/whispersystems/textsecuregcm/push/MessageSender.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/push/MessageSender.java
@@ -352,7 +352,6 @@ public class MessageSender {
            Tag.of("multiRecipientMessage", String.valueOf(isMultiRecipientMessage)),
            Tag.of("syncMessage", String.valueOf(isSyncMessage)),
            Tag.of("story", String.valueOf(isStory))))
-        .publishPercentileHistogram(true)
        .register(Metrics.globalRegistry)
        .record(contentLength);

--- a/service/src/main/java/org/whispersystems/textsecuregcm/storage/MessagePersister.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/storage/MessagePersister.java
@@ -236,7 +236,6 @@ public class MessagePersister implements Managed {

      DistributionSummary.builder(QUEUE_SIZE_DISTRIBUTION_SUMMARY_NAME)
          .tags(Tags.of(platformTag))
-          .publishPercentileHistogram(true)
          .register(Metrics.globalRegistry)
          .record(messageCount);
    } catch (ItemCollectionSizeLimitExceededException e) {
--- a/service/src/main/java/org/whispersystems/textsecuregcm/storage/PagedSingleUseKEMPreKeyStore.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/storage/PagedSingleUseKEMPreKeyStore.java
@@ -73,7 +73,6 @@ public class PagedSingleUseKEMPreKeyStore {

  final DistributionSummary availableKeyCountDistributionSummary = DistributionSummary
      .builder(name(getClass(), "availableKeyCount"))
-      .publishPercentileHistogram()
      .register(Metrics.globalRegistry);

  private final String takeKeyTimerName = name(getClass(), "takeKey");
--- a/service/src/main/java/org/whispersystems/textsecuregcm/storage/ReportMessageDynamoDb.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/storage/ReportMessageDynamoDb.java
@@ -30,7 +30,6 @@ public class ReportMessageDynamoDb {
  private static final String REMOVED_MESSAGE_COUNTER_NAME = name(ReportMessageDynamoDb.class, "removed");
  private static final Timer REMOVED_MESSAGE_AGE_TIMER = Timer
      .builder(name(ReportMessageDynamoDb.class, "removedMessageAge"))
-      .publishPercentiles(0.5, 0.75, 0.95, 0.99)
      .distributionStatisticExpiry(Duration.ofDays(1))
      .register(Metrics.globalRegistry);

--- a/service/src/main/java/org/whispersystems/textsecuregcm/storage/SingleUseECPreKeyStore.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/storage/SingleUseECPreKeyStore.java
@@ -61,13 +61,11 @@ public class SingleUseECPreKeyStore {

  final DistributionSummary keysConsideredForTakeDistributionSummary = DistributionSummary
      .builder(name(getClass(), "keysConsideredForTake"))
-      .publishPercentiles(0.5, 0.75, 0.95, 0.99, 0.999)
      .distributionStatisticExpiry(Duration.ofMinutes(10))
      .register(Metrics.globalRegistry);

  final DistributionSummary availableKeyCountDistributionSummary = DistributionSummary
      .builder(name(getClass(), "availableKeyCount"))
-      .publishPercentiles(0.5, 0.75, 0.95, 0.99, 0.999)
      .distributionStatisticExpiry(Duration.ofMinutes(10))
      .register(Metrics.globalRegistry);

--- a/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java
+++ b/service/src/main/java/org/whispersystems/textsecuregcm/websocket/WebSocketConnection.java
@@ -287,7 +287,6 @@ public class WebSocketConnection implements DisconnectionRequestListener {
          return result;
        })
        .thenRun(() -> sample.stop(Timer.builder(SEND_MESSAGE_DURATION_TIMER_NAME)
-            .publishPercentileHistogram(true)
            .tags(platformTag)
            .register(Metrics.globalRegistry)));
  }