Signal/Signal-Server
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Server synced 2026-08-04 22:13:42 +01:00
Code Issues Packages Projects Releases Wiki Activity

Handle MCC-only HLR responses

Browse Source
This commit is contained in:
Chris Eager
2026-01-30 15:57:34 -06:00
committed by Chris Eager
parent f390aabb3a
commit c0432d828d
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
service/src/main/java/org/whispersystems/textsecuregcm/telephony/hlrlookup/HlrLookupCarrierDataProvider.java
+1 -1
View File
@@ -171,7 +171,7 @@ public class HlrLookupCarrierDataProvider implements CarrierDataProvider {
static Optional<String> mncFromMccMnc(@Nullable final String mccMnc) {
// MNCs may be 2 or 3 digits, but always come after a 3-digit MCC
return Optional.ofNullable(StringUtils.stripToNull(mccMnc))
.map(trimmedMccMnc -> trimmedMccMnc.substring(3));
.map(trimmedMccMnc -> StringUtils.stripToNull(trimmedMccMnc.substring(3)));
}
@VisibleForTesting
service/src/test/java/org/whispersystems/textsecuregcm/telephony/hlrlookup/HlrLookupCarrierDataProviderTest.java
+4 -2
View File
@@ -187,7 +187,8 @@ class HlrLookupCarrierDataProviderTest {
Arguments.argumentSet("Empty mccMnc string", "", Optional.empty()),
Arguments.argumentSet("Blank mccMnc string", " ", Optional.empty()),
Arguments.argumentSet("Two-digit MNC", "12345", Optional.of("123")),
Arguments.argumentSet("Three-digit MNC", "123456", Optional.of("123"))
Arguments.argumentSet("Three-digit MNC", "123456", Optional.of("123")),
Arguments.argumentSet("MCC-only", "123", Optional.of("123"))
);
}
@@ -204,7 +205,8 @@ class HlrLookupCarrierDataProviderTest {
Arguments.argumentSet("Empty mccMnc string", "", Optional.empty()),
Arguments.argumentSet("Blank mccMnc string", " ", Optional.empty()),
Arguments.argumentSet("Two-digit MNC", "12345", Optional.of("45")),
Arguments.argumentSet("Three-digit MNC", "123456", Optional.of("456"))
Arguments.argumentSet("Three-digit MNC", "123456", Optional.of("456")),
Arguments.argumentSet("MCC-only", "123", Optional.empty())
);
}