Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-04-02 00:27:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

refactor: compare_failed spaceship (#8634)

Browse Source
This commit is contained in:
Yat Ho
2026-03-05 06:04:10 +08:00
committed by GitHub
parent 59abf6e1db
commit 4eaf91fda5
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
libtransmission/announcer-common.h
View File

@@ -11,6 +11,7 @@
#include <array>
#include <chrono>
#include <compare>
#include <cstdint> // uint64_t
#include <ctime>
#include <optional>
@@ -145,20 +146,20 @@ struct tr_announce_response
* https://www.bittorrent.org/beps/bep_0024.html */
std::optional<tr_address> external_ip;
static constexpr int compare_failed(tr_announce_response const& lhs, tr_announce_response const& rhs) noexcept
static constexpr auto compare_failed(tr_announce_response const& lhs, tr_announce_response const& rhs) noexcept
{
if (auto val = tr_compare_3way(lhs.did_connect, rhs.did_connect); val != 0)
if (auto const val = static_cast<int>(lhs.did_connect) <=> static_cast<int>(rhs.did_connect); val != 0)
{
return val;
}
if (auto val = tr_compare_3way(lhs.did_timeout, rhs.did_timeout); val != 0)
if (auto const val = static_cast<int>(rhs.did_timeout) <=> static_cast<int>(lhs.did_timeout); val != 0)
{
return -val;
return val;
}
// Non-empty error message most likely means we reached the tracker
return -tr_compare_3way(std::empty(lhs.errmsg), std::empty(rhs.errmsg));
return static_cast<int>(std::empty(rhs.errmsg)) <=> static_cast<int>(std::empty(lhs.errmsg));
}
};