Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-20 02:18:42 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: remove unused quarks from libtransmission (#7799)

Browse Source 
* chore: remove unused TR_KEY_comment_utf_8

chore: remove unused TR_KEY_created_by_utf_8

chore: remove unused TR_KEY_name_utf_8

chore: remove unused TR_KEY_path_utf_8

These keys have been unused since fe288b45 (#2542)

* chore: remove unused TR_KEY_ut_comment

chore: remove unused TR_KEY_ut_recommend

Never used. We can add these back when we support them

* remove unused TR_KEY_queue_move_bottom

remove unused TR_KEY_queue_move_down

remove unused TR_KEY_queue_move_top

remove unused TR_KEY_queue_move_up

Added in c1559f3c, but never used.

* chore: remove unused TR_KEY_play_download_complete_sound

Never used and is a duplicate of TR_KEY_torrent_complete_sound_enabled.
Maybe it was a draft name that accidentally snuck into production?

* chore: remove unused TR_KEY_downloaders

chore: remove unused TR_KEY_min_announce_interval

Unused since 7f60738c (#2529)

* chore: remove unused TR_KEY_recent_download_dir_1

chore: remove unused TR_KEY_recent_download_dir_2

chore: remove unused TR_KEY_recent_download_dir_3

chore: remove unused TR_KEY_recent_download_dir_4

chore: remove unused TR_KEY_recent_relocate_dir_1

chore: remove unused TR_KEY_recent_relocate_dir_2

chore: remove unused TR_KEY_recent_relocate_dir_3

chore: remove unused TR_KEY_recent_relocate_dir_4

Looks like these were intended for the GTK client's recent dirs
feature (see gtr_save_recent_dir() and gtr_get_recent_dirs()),
but that code does it better without quarks.
This commit is contained in:
Charles Kerr
2025-11-10 23:58:30 -06:00
committed by GitHub
parent 78238ec3de
commit 995dfe567e
2 changed files with 0 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

21
libtransmission/quark.cc
View File

@@ -66,7 +66,6 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"clientIsInterested"sv,
"clientName"sv,
"comment"sv,
"comment_utf_8"sv,
"compact-view"sv,
"complete"sv,
"config-dir"sv,
@@ -74,7 +73,6 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"corrupt"sv,
"corruptEver"sv,
"created by"sv,
"created by.utf-8"sv,
"creation date"sv,
"creator"sv,
"cumulative-stats"sv,
@@ -104,7 +102,6 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"downloaded-bytes"sv,
"downloadedBytes"sv,
"downloadedEver"sv,
"downloaders"sv,
"downloading-time-seconds"sv,
"dropped"sv,
"dropped6"sv,
@@ -207,12 +204,10 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"metadata_size"sv,
"metainfo"sv,
"method"sv,
"min_request_interval"sv,
"move"sv,
"msg_type"sv,
"mtimes"sv,
"name"sv,
"name.utf-8"sv,
"nextAnnounceTime"sv,
"nextScrapeTime"sv,
"nodes"sv,
@@ -220,7 +215,6 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"open-dialog-dir"sv,
"p"sv,
"path"sv,
"path.utf-8"sv,
"paused"sv,
"pausedTorrentCount"sv,
"peer-congestion-algorithm"sv,
@@ -251,7 +245,6 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"pieceCount"sv,
"pieceSize"sv,
"pieces"sv,
"play-download-complete-sound"sv,
"port"sv,
"port-forwarding-enabled"sv,
"port-is-open"sv,
@@ -267,10 +260,6 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"progress"sv,
"prompt-before-exit"sv,
"proxy_url"sv,
"queue-move-bottom"sv,
"queue-move-down"sv,
"queue-move-top"sv,
"queue-move-up"sv,
"queue-stalled-enabled"sv,
"queue-stalled-minutes"sv,
"queuePosition"sv,
@@ -282,14 +271,6 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"ratio-limit-enabled"sv,
"ratio-mode"sv,
"read-clipboard"sv,
"recent-download-dir-1"sv,
"recent-download-dir-2"sv,
"recent-download-dir-3"sv,
"recent-download-dir-4"sv,
"recent-relocate-dir-1"sv,
"recent-relocate-dir-2"sv,
"recent-relocate-dir-3"sv,
"recent-relocate-dir-4"sv,
"recheckProgress"sv,
"remote-session-enabled"sv,
"remote-session-host"sv,
@@ -420,11 +401,9 @@ auto constexpr MyStatic = std::array<std::string_view, TR_N_KEYS>{
"use-global-speed-limit"sv,
"use-speed-limit"sv,
"user-has-given-informed-consent"sv,
"ut_comment"sv,
"ut_holepunch"sv,
"ut_metadata"sv,
"ut_pex"sv,
"ut_recommend"sv,
"utp-enabled"sv,
"v"sv,
"version"sv,

21
libtransmission/quark.h
View File

@@ -68,7 +68,6 @@ enum // NOLINT(performance-enum-size)
TR_KEY_clientIsInterested,
TR_KEY_clientName,
TR_KEY_comment,
TR_KEY_comment_utf_8,
TR_KEY_compact_view,
TR_KEY_complete,
TR_KEY_config_dir,
@@ -76,7 +75,6 @@ enum // NOLINT(performance-enum-size)
TR_KEY_corrupt,
TR_KEY_corruptEver,
TR_KEY_created_by,
TR_KEY_created_by_utf_8,
TR_KEY_creation_date,
TR_KEY_creator,
TR_KEY_cumulative_stats,
@@ -106,7 +104,6 @@ enum // NOLINT(performance-enum-size)
TR_KEY_downloaded_bytes,
TR_KEY_downloadedBytes,
TR_KEY_downloadedEver,
TR_KEY_downloaders,
TR_KEY_downloading_time_seconds,
TR_KEY_dropped,
TR_KEY_dropped6,
@@ -209,12 +206,10 @@ enum // NOLINT(performance-enum-size)
TR_KEY_metadata_size,
TR_KEY_metainfo,
TR_KEY_method,
TR_KEY_min_request_interval,
TR_KEY_move,
TR_KEY_msg_type,
TR_KEY_mtimes,
TR_KEY_name,
TR_KEY_name_utf_8,
TR_KEY_nextAnnounceTime,
TR_KEY_nextScrapeTime,
TR_KEY_nodes,
@@ -222,7 +217,6 @@ enum // NOLINT(performance-enum-size)
TR_KEY_open_dialog_dir,
TR_KEY_p,
TR_KEY_path,
TR_KEY_path_utf_8,
TR_KEY_paused,
TR_KEY_pausedTorrentCount,
TR_KEY_peer_congestion_algorithm,
@@ -253,7 +247,6 @@ enum // NOLINT(performance-enum-size)
TR_KEY_pieceCount,
TR_KEY_pieceSize,
TR_KEY_pieces,
TR_KEY_play_download_complete_sound,
TR_KEY_port,
TR_KEY_port_forwarding_enabled,
TR_KEY_port_is_open,
@@ -269,10 +262,6 @@ enum // NOLINT(performance-enum-size)
TR_KEY_progress,
TR_KEY_prompt_before_exit,
TR_KEY_proxy_url,
TR_KEY_queue_move_bottom,
TR_KEY_queue_move_down,
TR_KEY_queue_move_top,
TR_KEY_queue_move_up,
TR_KEY_queue_stalled_enabled,
TR_KEY_queue_stalled_minutes,
TR_KEY_queuePosition,
@@ -284,14 +273,6 @@ enum // NOLINT(performance-enum-size)
TR_KEY_ratio_limit_enabled,
TR_KEY_ratio_mode,
TR_KEY_read_clipboard,
TR_KEY_recent_download_dir_1,
TR_KEY_recent_download_dir_2,
TR_KEY_recent_download_dir_3,
TR_KEY_recent_download_dir_4,
TR_KEY_recent_relocate_dir_1,
TR_KEY_recent_relocate_dir_2,
TR_KEY_recent_relocate_dir_3,
TR_KEY_recent_relocate_dir_4,
TR_KEY_recheckProgress,
TR_KEY_remote_session_enabled,
TR_KEY_remote_session_host,
@@ -422,11 +403,9 @@ enum // NOLINT(performance-enum-size)
TR_KEY_use_global_speed_limit,
TR_KEY_use_speed_limit,
TR_KEY_user_has_given_informed_consent,
TR_KEY_ut_comment,
TR_KEY_ut_holepunch,
TR_KEY_ut_metadata,
TR_KEY_ut_pex,
TR_KEY_ut_recommend,
TR_KEY_utp_enabled,
TR_KEY_v,
TR_KEY_version,