Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-02-14 23:19:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: incorrectly set error when moving across filesystems (#8167)

Browse Source
This commit is contained in:
Yat Ho
2026-01-21 01:16:47 +08:00
committed by GitHub
parent 7de5795cde
commit a3202cbe47
1 changed files with 12 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
libtransmission/utils.cc
View File

@@ -599,14 +599,21 @@ bool tr_file_move(std::string_view oldpath_in, std::string_view newpath_in, bool
return false;
}
/* they might be on the same filesystem... */
if (tr_sys_path_rename(oldpath, newpath, error))
if (allow_copy)
{
return true;
// they might be on the same filesystem...
if (tr_sys_path_rename(oldpath, newpath))
{
return true;
}
}
if (!allow_copy)
else
{
// do the actual moving
if (tr_sys_path_rename(oldpath, newpath, error))
{
return true;
}
error->prefix_message("Unable to move file: ");
return false;
}