Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-04-17 23:54:19 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix: don't overwrite *_enabled if preferred_transports is not in settings.json (#8658)

Browse Source 
(cherry picked from commit b40adc411e)
This commit is contained in:
Yat Ho
2026-03-09 01:21:55 +08:00
committed by GitHub
parent 9a44fce49d
commit ae89503dc3
1 changed files with 15 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
libtransmission/session.cc
View File

@@ -474,6 +474,21 @@ tr_variant tr_sessionGetDefaultSettings()
ret.merge(tr_rpc_server::Settings{}.save());
ret.merge(tr_session_alt_speeds::Settings{}.save());
ret.merge(tr_session::Settings{}.save());
// TODO(5.0.0): remove this if block
if (auto* const map = ret.get_if<tr_variant::Map>())
{
// N.B. Because `tr_session::Settings::load()` calls
// `tr_session::Settings::fixup_to_preferred_transports()`,
// the defaults of `preferred_transports` essentially
// just repeats `utp_enabled` + `tcp_enabled`.
//
// Erase `preferred_transports` from the defaults to avoid
// overwriting `utp_enabled` and `tcp_enabled` that is set
// by the user.
map->erase(TR_KEY_preferred_transports);
}
return ret;
}