Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-05-08 09:39:08 +01:00
Code Issues Packages Projects Releases Wiki Activity

(trunk libT) make the RPC 409 error message easier to understand

Browse Source
This commit is contained in:
Charles Kerr
2009-08-13 16:50:50 +00:00
parent 784464450a
commit d08d53d8ed
1 changed files with 10 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
libtransmission/rpc-server.c
+10 -11
View File
@@ -629,17 +629,16 @@ handle_request( struct evhttp_request * req, void * arg )
{
const char * sessionId = get_current_session_id( server );
char * tmp = tr_strdup_printf(
"<p>Please add this header to your HTTP requests:</p>"
"<p style=\"padding-left: 20pt;\"><code>%s: %s</code></p>"
"<p><b>RPC Application Developers:</b></p>"
"<p style=\"padding-left: 20pt;\">As of Transmission 1.53 and 1.61, RPC clients "
"need to look for this 409 response containing the phrase \"invalid session-id\". "
"It occurs when the request's "TR_RPC_SESSION_ID_HEADER" header was missing "
"(such as during bootstrapping) or expired. "
"Either way, you can parse this response's headers for the new session-id.</p>"
"<p style=\"padding-left: 20pt;\">This requirement has been added to make "
"<a href=\"http://en.wikipedia.org/wiki/Cross-site_request_forgery\">CSRF</a>"
" attacks more difficult.</p>",
"<p>Your request had an invalid session-id header.</p>"
"<p>To fix this, follow these steps:"
"<ol><li> When reading a response, get its X-Transmission-Session-Id header and remember it"
"<li> Add the updated header to your outgoing requests"
"<li> When you get this 409 error message, resend your request with the updated header"
"</ol></p>"
"<p>This requirement has been added to help prevent "
"<a href=\"http://en.wikipedia.org/wiki/Cross-site_request_forgery\">CSRF</a> "
"attacks.</p>"
"<p><code>%s: %s</code></p>",
TR_RPC_SESSION_ID_HEADER, sessionId );
evhttp_add_header( req->output_headers, TR_RPC_SESSION_ID_HEADER, sessionId );
send_simple_response( req, 409, tmp );