Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2026-02-14 23:19:34 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: convert tr_bandwidth::RateControl::newest_ to unsigned (#8094)

Browse Source
This commit is contained in:
Yat Ho
2026-01-09 21:25:30 +08:00
committed by GitHub
parent a3b4b0a87f
commit d7babab6ba
2 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
libtransmission/bandwidth.cc
View File

@@ -39,18 +39,18 @@ Speed tr_bandwidth::get_speed(RateControl& r, unsigned int interval_msec, uint64
uint64_t bytes = 0U;
uint64_t const cutoff = now - interval_msec;
for (int i = r.newest_; r.date_[i] > cutoff;)
for (auto i = r.newest_; r.date_[i] > cutoff;)
{
bytes += r.size_[i];
if (--i == -1)
if (--i >= HistorySize) // overflowed below zero
{
i = HistorySize - 1; /* circular history */
i = HistorySize - 1U; // circular history
}
if (i == r.newest_)
{
break; /* we've come all the way around */
break; // we've come all the way around
}
}
@@ -71,7 +71,7 @@ void tr_bandwidth::notify_bandwidth_consumed_bytes(uint64_t const now, RateContr
{
if (++r.newest_ == HistorySize)
{
r.newest_ = 0;
r.newest_ = 0U;
}
r.date_[r.newest_] = now;

2
libtransmission/bandwidth.h
View File

@@ -237,7 +237,7 @@ private:
std::array<size_t, HistorySize> size_;
uint64_t cache_time_;
Speed cache_val_;
int newest_;
size_t newest_;
};
struct Band