Transmission/transmission
1
0
Fork 0
mirror of https://github.com/transmission/transmission.git synced 2025-12-24 20:35:36 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: remove unused function tr_env_get_int() (#5682)

Browse Source
This commit is contained in:
Charles Kerr
2023-06-28 22:04:07 -05:00
committed by GitHub
parent 7e1ecf2f0f
commit fd4a0b1d16
3 changed files with 0 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
libtransmission/utils.cc
View File

@@ -907,21 +907,6 @@ bool tr_env_key_exists(char const* key)
#endif
}
int tr_env_get_int(char const* key, int default_value)
{
TR_ASSERT(key != nullptr);
if (auto const valstr = tr_env_get_string(key); !std::empty(valstr))
{
if (auto const valint = tr_parseNum<int>(valstr); valint)
{
return *valint;
}
}
return default_value;
}
std::string tr_env_get_string(std::string_view key, std::string_view default_value)
{
#ifdef _WIN32

3
libtransmission/utils.h
View File

@@ -357,9 +357,6 @@ void tr_formatter_get_units(void* dict);
/** @brief Check if environment variable exists. */
[[nodiscard]] bool tr_env_key_exists(char const* key);
/** @brief Get environment variable value as int. */
[[nodiscard]] int tr_env_get_int(char const* key, int default_value);
/** @brief Get environment variable value as string. */
[[nodiscard]] std::string tr_env_get_string(std::string_view key, std::string_view default_value = {});

3
tests/libtransmission/utils-test.cc
View File

@@ -283,21 +283,18 @@ TEST_F(UtilsTest, env)
unsetenv(test_key);
EXPECT_FALSE(tr_env_key_exists(test_key));
EXPECT_EQ(123, tr_env_get_int(test_key, 123));
EXPECT_EQ(""sv, tr_env_get_string(test_key));
EXPECT_EQ("a"sv, tr_env_get_string(test_key, "a"sv));
setenv(test_key, "", 1);
EXPECT_TRUE(tr_env_key_exists(test_key));
EXPECT_EQ(456, tr_env_get_int(test_key, 456));
EXPECT_EQ("", tr_env_get_string(test_key, ""));
EXPECT_EQ("", tr_env_get_string(test_key, "b"));
setenv(test_key, "135", 1);
EXPECT_TRUE(tr_env_key_exists(test_key));
EXPECT_EQ(135, tr_env_get_int(test_key, 789));
EXPECT_EQ("135", tr_env_get_string(test_key, ""));
EXPECT_EQ("135", tr_env_get_string(test_key, "c"));
}