* perf: when selection changes, only update the rows whose selection changed
previously we were updating all rows
* perf: coalesce pending reloads in TorrentTableView
* refactor: return a copy rather thabn a mutable index
* refactor: move the assignment out of the if statement
* make symmetricDifference an NSIndexSet method
* refactor: callers now own the return value of tr_torrentStat()
fix one potential thread issue by simplifying ownership
* refactor: make tr_stat_errtype an enum class; move into tr_stat
* refactor: order tr_stat fields to reduce padding
* chore: fix branch shear
* fix: int-to-enum-class comparison
* fix: namespace regression
* chore: make clang-tidy happy
* refactor: tr_torrentPeers() now returns a std::vector<tr_peer_stat>
* refactor: make tr_peer_stat.client a std::string_view
* refactor: make tr_peer_stat.flag_str a std::string
* refactor: make tr_peer_stat.addr a std::string
* refactor: rename tr_peer_stat field names to camel_case
* refactor: use Speed type for tr_peer_stat speed fields
* refactor: add default initializers to tr_peer_stat fields
* refactor: order tr_peer_stat fields to reduce padding
* fix: typo in [Torrent peers] getter
* refactor: make tr_peer_stat.user_agent a std::string
* refactor: pass by reference instead of by pointer in DetailsDialog
* fixup! refactor: add default initializers to tr_peer_stat fields
* refactor: tr_ctorGetDownloadDir() returns a std::optional<std::string>
* refactor: tr_sessionGetConfigDir() now returns a std::string
* refactor: tr_sessionGetDownloadDir() now returns a std::string
* refactor: tr_sessionGetIncompleteDir() now returns a std::string
* refactor: tr_sessionGetRPCWhitelist() now returns a std::string
* refactor: tr_sessionGetRPCPassword() now returns a std::string
* refactor: tr_sessionGetRPCUsername() now returns a std::string
* refactor: tr_sessionGetScript() now returns a std::string
* refactor: tr_blocklistGetURL() now returns a std::string
* refactor: tr_ctorGetSourceFile() now returns a std::optional<std::string>
* refactor: tr_torrentFile() now returns a std::string
* refactor: gtr_open_file() now takes a std::string_view
refactor: gtr_open_file() now calls Glib::filename_to_uri()
refactor: add gtr_open_file() variant that takes basedir and relative path
refactor: gtr_open_uri() now takes a relative_path std::string_view
* refactor: tr_torrentGetCurrentDir() now returns a std::string_view
refactor: tr_torrentGetDownloadDir() now returns a std::string_view
* refactor: replace TR_RPC_SESSION_ID_HEADER macro with TrRpcSessionIdHeader constant
refactor: replace TR_RPC_RPC_VERSION_HEADER macro with TrRpcVersionHeader constant
* refactor: remove macro TR_DEFAULT_RPC_PORT_STR
* refactor: remove macro TR_DEFAULT_PEER_PORT_STR
* refactor: remove macro TR_DEFAULT_PEER_LIMIT_GLOBAL_STR
* refactor: remove macro TR_DEFAULT_PEER_LIMIT_TORRENT_STR
* refactor: remove macro TR_DEFAULT_PEER_SOCKET_TOS_STR
* refactor: replace DEFAULT_BLOCKLIST_FILENAME macro with TrDefaultBlocklistFilename constant
* refactor: rename TrHttpServerDefaultBasePath to TrDefaultHttpServerBasePath for consistency with other defaults
* refactor: group constants together near the top of transmission.h
* refactor: hardcode string lengths to avoid FTBFS on older C++17 compilers
* refactor: move macros to the tr_getopt clients
* refactor: explicitly specify the parameter index to avoid passing in TrRpcSessionIdHeader twice
* refactor: add an error message to new static_asserts
* refactor: add [Torrent updateTorrents]
refactor: use updateTorrents in Controller
* refactor: add a batch variant of tr_torrentStat()
* refactor: use batch variant of tr_torrentStat() in GTK details dialog
* refactor: use batch variant of tr_torrentStat() in gtr_confirm_remove()
* refactor: use batch variant of tr_torrentStat() in updateTorrents
* refactor: add Session::find_torrents()
* refactor: remove the raw ptr variant of updateTorrents()
* refactor: remove tr_sessionLock()
* fixup! refactor: add [Torrent updateTorrents]
remove duplicate method declaration
* fix: readability-avoid-const-params-in-decls
* fix: iwyu in transmission.h
* chore: remove an #include that was added in a draft that did not get used
* refactor: use nullptr instead of NULL
* chore(mac): fix copyright year
* chore(mac): use em dash in copyright notice
* fix(ci): check for emdash in copyright notice
* fix(ci): process QuickLookExtension plist files
This will make the icons only appear in macOS 26+, without having to manually remove them for earlier releases. This also will allow us to use newer symbol images.
* chore: update copyright year in COPYING
* chore: update copyright year in user-facing files (1)
* chore: update copyright year in user-facing files (2)
* chore: update copyright year in cmake/transmission.rc.in
---------
Co-authored-by: github-actions <github-actions@github.com>
* Set filter to "All" when hiding the filter bar
Otherwise the filters will reset but the tab, for example "Downloading" will still be selected
when the filter is shown again. We want to keep the tabs synchronized with filters state.
* Remove unused BOOL parameter (the method is always called with YES)
---------
Co-authored-by: beyondcompute <beyondcompute@users.noreply.github.com>
* Adopt NSTitlebarAccessoryViewController for filter and status bars
Also remove custom views as separator is drawn with Horizontal Line.
Simplifies maintainance a bit.
* Unembed main content and status bar from NSStackView
Stack is no longer needed, as bars are moved into titlebar.
* macOS 26: set icons on most menu items
This is a first pass, and likely needs some adjustments and updated.
This also removes Select None, which does not seem to be in favor in Mac apps anymore.
* Explicitly set the image on toolbar items' menu representation
* Icons for Info > Files context menu
- Use modern APIs to prevent idle system sleep.
- Consolidate all related logic.
- Make Controller class a little bit less huge.
Signed-off-by: Dzmitry Neviadomski <nevack.d@gmail.com>
