Commit Graph

14525 Commits

Author SHA1 Message Date
Dzmitry Neviadomski
f8264ce957 [macOS] Fix global popover clipping. (#3264)
* [macOS] Fix global popover clipping.

Fixes #3263

* [macOS] Detach global popover via ugly hack.
2022-06-13 12:26:30 -05:00
SweetPPro
955091ce12 macOS - fix some window drawing issues (#3278)
* macOS - fix some window drawing issues

fixes an issue with  torrent clipping when number of torrents displayed overflows the screen height
2022-06-13 09:48:09 -05:00
Charles Kerr
bf1d668f9a refactor: make accessor functions constexpr (#3276) 2022-06-12 22:59:30 -05:00
SweetPPro
dd85cd20bd replace macOS Groups indicators with dots (#3268)
* replace macOS Groups indicators with dots

the current Group indicator PR #3183 used bars. I feel using circles is a better fit with the overall theme of Transmission #3224

* simplified calculations
2022-06-12 20:56:12 -05:00
SweetPPro
c3cd9cffad re-add macOS Fullscreen support (#3261)
* re-add macOS Fullscreen support

re added Full Screen support for macOS. Also refactored window methods in Controller.mm and moved to their own category - ControllerWindowMethods.mm

This has currently only been tested on macOS Monterey, and should be good on earlier versions - but perhaps needs testing on earlier versions of macOS.

fixes #3231 #3234
2022-06-12 19:54:52 -05:00
Dzmitry Neviadomski
da74fd21cc [macOS] Use DDG favicons service and migrate to NSURLSession (#3270)
```objc
+ (NSData *)sendSynchronousRequest:(NSURLRequest *)request
                 returningResponse:(NSURLResponse * _Nullable *)response
                             error:(NSError * _Nullable *)error;
```
is deprecated on 10.11+
2022-06-12 15:29:00 -05:00
Dzmitry Neviadomski
3fe2ed893f [macOS] Ignore warnings while building third-party projects in Xcode. (#3267)
Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-06-12 12:49:44 -05:00
Dzmitry Neviadomski
be092ebea6 [macOS] Fix Xcode warnings for non-incremental build script phases. (#3266) 2022-06-12 11:24:30 -05:00
Gary Elshaw
ed394af4d6 Replace gear icon with ellipsis in macOS client (#3178) 2022-06-11 23:24:31 -05:00
Charles Kerr
34cb56b2af refactor: remove unused tr_ptrArray class (#3262)
* refactor: remove unused tr_ptrArray class

* fixup! build: add sanitizer CI runs when libtransmission-test changes (#3260)
2022-06-11 21:45:00 -05:00
Dmytro Lytovchenko
d34bd0b4d6 refactor: modernize cache.cc (#3108)
* Modernize cache.cc: Convert tr_cache to a class

* Modernize cache.cc: Replaced ptrArray with vector

* refactor: Cache now takes a tr_torrents reference

* refactor: add Key type to Cache

* refactor: avoid std::back_inserter

* refactor: add Cache::flushOldest()
2022-06-11 19:46:30 -05:00
Charles Kerr
1e796477dc build: add sanitizer CI runs when libtransmission-test changes (#3260) 2022-06-11 16:56:34 -05:00
Charles Kerr
57c49437eb fix: filename too long warning when adding magnet links (#3259)
Fixes #3117.
2022-06-11 15:46:40 -05:00
Charles Kerr
cd592d0091 fix: clang-15 warnings (#3257) 2022-06-11 14:35:08 -05:00
Charles Kerr
61c1a0f1e8 feat: add rpc torrentGet.availability (#3252) 2022-06-11 12:06:07 -05:00
Charles Kerr
adc105ed2c fix: deadlock between session and web mutexes (#3251)
Fixes #3242.

Introduced by #2693.
2022-06-10 23:56:43 -05:00
Max Zettlmeißl
7269db2d45 Drop the leading zero for permissions in the settings file. (#3248)
This change has been in the back of my head since I made pull request #2984.
Dropping the zero does not change any of the behaviour.
And this way the format is more familiar to users of the unixoid
octal permissions. Those permissions would not be specified with
a leading zero.
If they were specified with a leading zero, it would mean that some
special permission bits (setuid, setgid or sticky) should be cleared.
Thus removing the leading zero in our settings format removes two
cases of possible confusion.
Additionally the permissions are always padded to three digits to avoid
strangely looking permission strings.
2022-06-10 19:04:34 -05:00
Max Zettlmeißl
30f56f94e6 Update the AUTHORS file. (#3247)
Readd Dean Ostetto who was wrongly removed.

Add myself, since the proper authorship information in the Git history
is lost when squashing the commits.
My contributions so far are: Pull request #2875 merged with commit hash
`738431169cce5cc60e935df44d0616891162dee9`, pull request #2889 merged with
commit hash `8d11f0bc22ec7e1f87e573d1232e8faa72e745a3`, pull request #2900
merged with commit hash `7c76d40a4d8748199903cf0a9d7cd0e38ec9e3f1` and
pull request #2984 merged with commit hash `d8c5c6572559136569f00e0c9c3cb068b6256938`.

All are currently attributed to `maxz <6818198+maxz@users.noreply.github.com>`,
while I expected them to be attributed to `Max Zettlmeißl <max@zettlmeissl.de>`.
2022-06-10 16:26:09 -05:00
A Cœur
4b61db1cad Adding icon.png for Sourcetree (#3250) 2022-06-10 12:34:46 -05:00
Gary Elshaw
d4bc5662fe Add files via upload (#3238) 2022-06-09 12:35:12 -05:00
Charles Kerr
0976e6259e docs: un-deprecate trackerAdd RPC (#3237)
Fixes #3226.
2022-06-08 19:52:37 -05:00
Charles Kerr
00386d03a6 fix: too-small scrape request packets may trip SYN flood detection (#3236)
Fixes #964.
2022-06-08 17:51:54 -05:00
A Cœur
af5db6e6f2 refactor: autogenerate the macOS client's Message Log dots (#3224)
* Replaces DotFlat png with generated icons

* code review: udating popup item icons

* code review: increasing inset
2022-06-08 16:35:51 -05:00
SweetPPro
7056765468 update macOS group indicators (#3183)
* update macOS group indicators

proposal for updated Group indicators, inspired by Xcode, and ios Calendar.

Discussion over here: https://github.com/transmission/transmission/issues/3058

* Update TorrentCell.mm

resolve some pr isssues

* Update TorrentCell.mm

add a group indicator width definition
2022-06-08 15:13:29 -05:00
SweetPPro
aabb8c809e macOS remove FullScreen support (#3220)
removed fullscreen support, as it opens a can of worms trying to fully support it....

https://github.com/transmission/transmission/issues/3215#issuecomment-1147477253
2022-06-08 14:15:51 -05:00
Charles Kerr
12592e20d6 build: remove unused function checks (#3233)
* build: remove unused -DHAVE_ASPRINTF from xcode build

* build: remove unused -DHAVE_ZLIB from cmake and xcode

we use libdeflate instead

* build: remove unused -DHAVE_LIBGEN from xcode
2022-06-08 13:35:07 -05:00
Balázs Meskó
0df6c23c7b fix: mark non-c-strings for gettext i18n (#3210) 2022-06-08 01:04:17 -05:00
A Cœur
7b6b87b0e6 fix: macOS build warning "cannot find protocol definition for 'PortCheckerDelegate'" (#3222) 2022-06-07 14:27:40 -05:00
orbital-mango
49b62319c3 feature: add missing accelerators for File menu (GTK) (#3213) 2022-06-07 12:17:35 -05:00
SweetPPro
5a140d205d feat: use system lock icon if available (#3221) 2022-06-06 17:56:05 -05:00
Charles Kerr
6c9c446734 docs: fix documented type of rpc-version-semver (#3209) 2022-06-05 21:17:05 -05:00
SweetPPro
8d61f07930 fix: missing source file in CMake macOS build (#3208)
* Update CMakeLists.txt

correctly add new files to xcode project
2022-06-05 13:33:18 -05:00
Ilkka
4d888ee8fb Move function declaration (#3207) 2022-06-05 12:08:58 -05:00
SweetPPro
9cbb4d3384 fix a number of UI render issues in the macOS torrent creator window (#3205)
* fixes a number of UI issues in the macOS torrent creator window listed in: https://github.com/transmission/transmission/issues/1891

* also fixes positioning of the source field, the piece info textfield, and the piece info stepper

* also updates the  tracker add/remove control to use the newer rounded trect style as in the rest of the UI
2022-06-05 11:14:33 -05:00
SweetPPro
70a54b3603 add gearshape temeplate to macOS CMakeLists.txt (#3202)
add missing macOS icon asset to CMakeLists.txt
https://github.com/transmission/transmission/issues/3199
2022-06-05 09:54:45 -05:00
SweetPPro
163f6c2544 more FullScreen fixes, and some toolbar animation fixes (#3195)
* Update Controller.mm

fix fullscreen behaviour as described here https://github.com/transmission/transmission/issues/1906

* more FullScreen fixes, and some toolbar animation fixes

https://github.com/transmission/transmission/issues/1906, https://github.com/transmission/transmission/issues/1903
2022-06-05 08:49:31 -05:00
Robin Seth Ekman
9eeb3db89c daemon: deprecated --log-error -> --log-level=error (#3201) 2022-06-05 01:13:11 -05:00
Charles Kerr
8806f9af68 fix: duplicate template instantiation on raspberry pi armv7 (#3200) 2022-06-05 00:01:23 -05:00
A Cœur
84195254ec Fix: "Cannot begin activity without reason string or empty reason string" (#3197) 2022-06-04 18:42:32 -05:00
SweetPPro
d31254df50 Update Controller.mm (#3191)
fix fullscreen behaviour as described here https://github.com/transmission/transmission/issues/1906
2022-06-04 14:30:03 -05:00
Charles Kerr
2ff4041074 fixup! fix: coverity warnings (#3168) (#3193) 2022-06-04 11:33:03 -05:00
Charles Kerr
7f1e12f220 refactor: do not prune peer atoms (#3192)
* refactor; do not prune peer atoms

* feat: improve connectivity check for peer candidates
2022-06-04 10:29:24 -05:00
A Cœur
4906349e3a Make Sparkle optional to allow running Transmission without Apple Developer Program (#3050)
* Make Sparkle optional to allow building without Apple Developer Program

* Display a nice alert for developers clicking "checkForUpdates" when app isn't signed for Sparkle

Co-authored-by: Charles Kerr <charles@charleskerr.com>
2022-06-03 12:47:33 -05:00
Charles Kerr
c5a73b0a79 refactor: remove peer_atom.shelfDate() (#3187) 2022-06-03 10:09:16 -05:00
Mike Gelfand
79d90167fd Sync translations (#3184)
* Sync translations with code

* Sync translations with Transifex
2022-06-03 10:06:59 +01:00
SweetPPro
df657e9a04 Updated macOS segmented control alignment and popup button style (#3156)
* updated macOS group popup button alignment

popup button alignment enhancements described in the following issue: https://github.com/transmission/transmission/issues/3143

* updated macOS segmented controls in Preferences window

as described in the following issue: https://github.com/transmission/transmission/issues/3143
2022-06-02 19:05:15 -05:00
Charles Kerr
c2cd09d8d7 fix: do not crash when pruning idle peer atoms (#3182) 2022-06-02 10:00:12 -05:00
Charles Kerr
654bc409d7 refactor: remove peer_atom.peer field (#3177) 2022-06-01 22:36:00 -05:00
Charles Kerr
75a7c5f080 refactor: add tr_peerMsgs.networkSocket() (#3175) 2022-06-01 21:33:33 -05:00
FX Coudert
f5e6c5b782 fix: minor xcode warnings in macOS client (#3174) 2022-06-01 19:51:09 -05:00