Commit Graph

16785 Commits

Author SHA1 Message Date
Yat Ho
fe879f5817 fix: revert percent-encoding announce urls and webseeds (#8620) 2026-02-25 08:48:34 -06:00
Yat Ho
6a6b0dbcc5 ci: run clang-tidy-libtransmission for app/test-only changes (#8612)
* ci: run `clang-tidy-libtransmission` for app/test-only changes

* fix: fix another new clang-tidy regression

---------

Co-authored-by: Charles Kerr <charles@charleskerr.com>
2026-02-24 23:49:55 -06:00
Charles Kerr
144871ed5e fix: 4.1.0 crash when parsing some RPC responses from older Transmission servers (#8607) 2026-02-24 22:44:06 -06:00
Charles Kerr
8c9eab9a96 fixup! fix: show translated logging level strings (#8609) (#8615)
fix new clang-tidy warning
2026-02-24 20:07:28 -06:00
Dmitry Lobanov
f7a48c3484 fix: eliminate torrents list retain cycles (#8603) 2026-02-24 08:47:53 -06:00
Yat Ho
4e26df6671 fix: modernize-use-ranges in peer-*.cc (#8599) 2026-02-24 07:48:36 -06:00
Charles Kerr
32d0daafd9 fix: show translated logging level strings (#8609) 2026-02-24 07:47:28 -06:00
Yat Ho
fa2dfe11b1 fix: reset metainfo before parsing new benc (#8590) 2026-02-23 09:07:26 -06:00
Yat Ho
33b2388a43 fix: modernize-use-ranges in peer-mgr-wishlist.cc (#8594) 2026-02-22 22:45:03 -06:00
Yat Ho
85e99a6927 feat(remote): display preferred_transports instead of utp_enabled (#8576) 2026-02-22 15:18:44 -06:00
github-actions[bot]
6b3d00b190 chore: update generated transmission-web files (#8593)
Co-authored-by: ckerr <70381+ckerr@users.noreply.github.com>
2026-02-22 03:19:03 -06:00
sionide0278
5e2ba3f8d7 Update prefs-dialog.js (#8588)
Without this, the Time dropdown displays 6:45 as 6.75:45
2026-02-21 18:24:25 -06:00
Tom Sullivan
0222d9d466 chore: bump to 4.2.0-dev (#8589) 2026-02-21 11:03:52 -06:00
Yat Ho
5b52ba92c0 fix: enable modernize-use-designated-initializers (#8592)
* fix(qt): enable `modernize-use-designated-initializers`

* fix(gtk): enable `modernize-use-designated-initializers`
2026-02-21 10:45:14 -06:00
Yat Ho
f89242c855 fix: enable modernize-loop-convert (#8579) 2026-02-21 09:06:59 -06:00
Yat Ho
1297bac26b fix: Use pre-clang-format-21 syntax (#8584) 2026-02-21 09:05:28 -06:00
Yat Ho
d06a4bc5af build: update .clang-format to latest format (#8578) 2026-02-20 07:57:48 -06:00
Yat Ho
a420577587 ci: use gtkmm4 for FreeBSD (#8580) 2026-02-20 07:57:28 -06:00
Yat Ho
ece1d7b6c2 fix: fail when encountering invalid benc character. (#8573)
* fix: fail when encountering invalid benc character

* fix(test): wrong `pieces` length in test string

* test: more benc test cases
2026-02-19 13:53:01 -06:00
Yat Ho
d18f48dae9 fix: respect umask when creating directories (#8574) 2026-02-19 11:14:24 -06:00
Yat Ho
f495047a33 ci(qt): run clang-tidy on Linux (#8557)
* ci(qt): run clang-tidy

* chore(qt): silence warnings
2026-02-19 09:30:05 -06:00
Charles Kerr
c5ec41e05e test: use QT_QPA_PLATFORM=offscreen for qt tests on posix (#8575)
Fix the qt tests on Jenkins
2026-02-19 09:24:58 -06:00
Yat Ho
642c12cbb5 ci: speed up by using native arm64 runners (#8571)
* ci: run x86_64 only for BSD

* ci: native arm64 runner
2026-02-19 00:20:43 -06:00
Charles Kerr
5856619fbc fix: FTBFS with glibmm 2.68 (#8565) 2026-02-18 18:46:54 -06:00
Yat Ho
851881b59f chore: update web dependencies (#8534)
* chore: bump esbuild@0.27

* chore: bump eslint-plugin-unicorn@63

* chore: bump globals@17

* chore: bump stylelint@17

* chore: pin eslint-plugin-sonarjs@3.0.5

https://github.com/SonarSource/SonarJS/pull/6148 added a dependency that's not declared in the package.json. And of course it's AI slop.

* chore: re-generate package-lock.json

* fix: lint errors

* ci: temporarily enable arm64 NetBSD runner

* Revert "ci: temporarily enable arm64 NetBSD runner"

This reverts commit 39c9be3978.
2026-02-18 15:20:47 -06:00
Charles Kerr
1b1ccc08dc ci: run fewer redundant jobs (#8543)
* ci: move crypto tests into their own matrix

they do not need to run on both bsd 14 and bsd 15

* ci: remove matrix for the DISABLE_UTP test

the "enabled" half of the matrix is redundant with other CI runs

* ci: cancel prior CI jobs when new commit(s) are pushed

* ci: futureproof fedora matrix by using aliases fedora-latest, fedora-rawhide

* ci: remove the -from-tarball job suffixes

* ci: fold the debian-11 job into the debian job matrix

* fixup! ci: fold the debian-11 job into the debian job matrix

fix: sh->bash mismatch

* ci: always use the default version of freebsd, openbsd

* ci: always use the default version of netbsd

* ci: always use the default version of dragonflybsd

* ci: remove unused fail-fast setting
2026-02-18 14:40:46 -06:00
Yat Ho
6ad5a4ae31 test: info hash for unordered info dict (#8558) 2026-02-18 12:02:24 -06:00
Charles Kerr
b9e9feafeb fix: crash when removing a torrent that the inspector is showing (#8496) (#8553) 2026-02-17 22:23:12 -06:00
Yat Ho
6abccce6c6 ci: delete leftover ENABLE_DEPRECATED references (#8535) 2026-02-17 18:00:10 -06:00
Charles Kerr
aa8039cfb5 refactor: safeguard against nullptr tr_torrent* args in tr_torrentFoo() methods (#8550)
* refactor: safeguard against nullptr `tr_torrent*` args in `tr_torrentFoo()` methods (#8504)

* feat: safeguard tr_torrentFoo() calls against nullptr torrents

* refactor: tr_log_if_fail(tr_isTorrent(tor))

* test: add tests for invalid args to torrent C API

* fix: cppcoreguidelines-pro-type-member-init

* fix: readability-simplify-boolean-expr
2026-02-17 17:58:34 -06:00
Charles Kerr
c3b5fab4f4 fix: FTBFS with glibmm-2.68 (#8552)
13:45:53 /home/fedora/jenkins/workspace/trunk-linux/transmission-4.1.0-beta.5+r6c92d06854/gtk/DetailsDialog.cc:974:52:   required from here
13:45:53   974 |         bool const is_uniform = std::ranges::all_of(stats, [&baseline](auto const& st) { return baseline == st.error_string; });
13:45:53       |                                 ~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
13:45:53 /usr/include/glibmm-2.68/glibmm/ustring.h:1501:22: error: no matching function for call to ‘Glib::ustring::compare(const std::__cxx11::basic_string<char>&) const’
13:45:53  1501 |   return (lhs.compare(rhs) == 0);
13:45:53       |           ~~~~~~~~~~~^~~~~
2026-02-17 17:58:21 -06:00
Yat Ho
fc309238ce ci(gtk): run clang-tidy (#8251)
* ci: infra for parallel clang-tidy runs

* ci(gtk): run clang-tidy

* chore(gtk): silence warnings

* code review: use constexpr auto

* code review: use constants over magic numbers in Utils.cc

* code review: use `std::ignore` to ignore return value

* code review: add back visibility labels that indicated sections

* fix: wrap each command argument in single quotes
2026-02-17 17:53:01 -06:00
Yat Ho
6c92d06854 refactor: store dynamic quarks as char8_t (#8546) 2026-02-17 13:26:28 -06:00
Charles Kerr
ae332d575c Revert "ci: run big-endian tests in GitHub Actions (#8539)" (#8548)
This reverts commit 7eeb78174c.
2026-02-17 09:36:16 -06:00
Yat Ho
e44b261f92 refactor: store static quarks as char8_t (#8532) 2026-02-17 00:41:17 -06:00
Charles Kerr
7eeb78174c ci: run big-endian tests in GitHub Actions (#8539)
* ci: run big-endian tests in GitHub Actions

* ci: use debian:stable-slim and ubuntu-latest for big-endian tests

this way we will not have to periodically bump them

* ci: do not use -j nproc in qemu

* ci: cross-compile and then run the big-endian tests in qemu
2026-02-16 21:51:38 -06:00
Charles Kerr
27f2fa88ed perf: permanently cache Torrent.hashString (#8505) (#8536) 2026-02-16 12:16:35 -06:00
Dmitry Lobanov
5dbe953152 perf: remove torrents group title field setup. (#8498)
* Remove torrents group title field setup.

* Return selected color in group cell.

* Apply linter rules.
2026-02-16 12:00:57 -05:00
reardonia
31047493f5 UTF8-clean torrent 'path' (#8328)
* fix: mask non-UTF-8 characters in torrent file paths

BEP-3 requires strings to be UTF-8. Run path components through
tr_strv_to_utf8_string() to replace invalid bytes with U+FFFD
before sanitizing. Adds test with good and bad UTF-8 paths.

* replace ctrl characters in 'name' and 'path'

* Revert "replace ctrl characters in 'name' and 'path'"

This reverts commit 6816f59295.

* fix: mask non-UTF-8 characters in torrent file paths

BEP-3 requires strings to be UTF-8. Run path components through
tr_strv_to_utf8_string() to replace invalid bytes with U+FFFD
before sanitizing. Adds test with good and bad UTF-8 paths.

* replace ctrl characters in 'name' and 'path'

* Revert "replace ctrl characters in 'name' and 'path'"

This reverts commit 6816f59295.

* prepare for future Bittorrent v2 usage
2026-02-16 08:49:20 -06:00
Charles Kerr
40ae72888c fix: potential fd leak when running scripts (#8524) 2026-02-15 23:06:49 -06:00
Charles Kerr
1e33e950b2 fix: limit the number of simultaneous connections libcurl can have (#8525) 2026-02-15 23:06:28 -06:00
Charles Kerr
a9068d73ad refactor: use spaceship operator in tr::Values (#8518) 2026-02-15 23:06:02 -06:00
Yat Ho
1e14cc605b refactor: migrate to Madler's crc32c (#8475) 2026-02-15 15:16:01 -06:00
Yat Ho
5e9e543caf fix: warning in tr-dht.cc (#8519) 2026-02-15 15:10:30 -06:00
github-actions[bot]
bbe7227b1f chore: update generated transmission-web files (#8515)
Co-authored-by: ckerr <70381+ckerr@users.noreply.github.com>
2026-02-15 11:51:00 -06:00
Charles Kerr
8b271236a5 fix: UI update regression (#8419)
introduced last week by 1dd096e77
2026-02-15 09:31:59 -06:00
Charles Kerr
e29acee865 fix: cannot add magnet links from the command line (#8415) (#8476) 2026-02-15 01:19:42 -06:00
Charles Kerr
f5961aa561 fix: crash in torrent rename dialog after torrent removal (#8425) (#8501) 2026-02-15 01:19:15 -06:00
Ivan Kara
30bc84ebc9 feat(web): torrent list virtualization (#7674)
* add clusterize

* fix include clusterize css

* fix scroll jumping on very large list

* fix rapid fire of rpc calls when inspector is visible

* ensure detailed torrent data is fetched on selection changes too

* stop dispatching selection changed event on refilter

* remove duplicate event listener for torrent row clicks

* fix scroll into view and remove unnecessary stuff

* fix missing context menu

* fix missing row click

* set last torrent clicked id on right click

* remove unused variable

* Reduce clusterize row render count

* Remove excessive context_menu

* Tidy up a bit

* Restore unnecessary changes

* Apply prettier fix
2026-02-15 01:17:01 -06:00
github-actions[bot]
1e68c41da8 chore: update generated transmission-web files (#8385)
Co-authored-by: ckerr <70381+ckerr@users.noreply.github.com>
2026-02-14 17:31:29 -06:00