* refactor: add quarks for the RPC method names
* update tr_quark_convert() to handle RPC method names
* refactor: use interned keys for RPC method names
* test: add torrentGetLegacy test
* refactor: use interned keys for RPC method names in tr-qt
* refactor: use interned keys for RPC method names in tr-remote
* refactor: use interned keys for RPC method names in tests
* refactor: use interned keys for RPC method names in tr-gtk
* chore: fix readability-identifier-naming regression
* chore: remove two unused quarks
looks like these were never used?
* chore: remove unused quark TR_KEY_have
unused since May 2024 3677e7a5
* chore: remove unused quark TR_KEY_date
unused since Oct 2021 9200d972
* fix: remove unused codepath
* chore: savepoint
* chore: code style
* refactor: add std::string_view constructor for NativeIcon::Spec
* chore: add TODO comment
* feat: honor per-desktop HIG on when to show menu icons
* chore: remove Faenza system-run icon
unused since b58e95910b
* chore: remove Faenza view-refresh icon
not needed due to b58e95910b
* chore: remove Faenza media-playback-pause icon
not needed due to b58e95910b
* chore: remove Faenza media-playback-start icon
not needed due to b58e95910b
* chore: add a safeguard against merging with incomplete TODO items
* feat: add more icons
refactor: remove some tracer cerr statements
* refactor: remove IconCache use from MainWindow
* chore: remove Faenza icon set
* chore: re-enable remote session network icon
* fix: FTBFS on Windows
* refactor: use symbolic names for Segoe icons
* docs: add links to Segoe MDL2 Assets icon list
* chore: savepoint
segoe icons work
still a WIP; includes test code that should not ship
* feat: use segoe::FastForward for action_StartNow
feat: use segoe::Move for action_SetLocation
refactor: make it easier for devs to force a font at compile time for development work
segoe license does not allow bundling but does allow dev work
chore: code_style.sh
* refactor: remove unused addEmblem()
* docs: add code comment on how to force an icon font
* fix: Win 10, 11 icons play nicely with dark mode
* chore: savepoint
add draft of SF Symbol -> QPixmap loader
* chore: remove dangling font reference from qrc file
* fix: FTBFS
* refactor: use bribri code for NSImage -> QPixmap
* feat: support dark, light mode when rendering SF Symbol monochrome icons
* fixup! feat: support dark, light mode when rendering SF Symbol monochrome icons
fix: fail gracefully on macOS 11
* chore: code style
* chore: tweak some SF Symbol icon choices
* chore: consistent uppercase for hex segoe QChars
* chore: undefine DEV_FORCE_FONT_FAMILY and DEV_FORCE_FONT_RESOURCE
* chore: savepoint
* refactor: clean up NativeIcon impl
* refactor: remove unused MenuMode::Other
* refactor: DRY in FilterBar::createActivityCombo()
* chore: remove obsolete code comment
* refactor: rename icons::Facet as icons::Type
* fix: oops
* refactor: minor cleanup
* fix: tyop
* chore: remove unused #includes
* fix: add modes for some icons
* refactor: tweak some icon choices on macOS
* fix: ensure icons are visible on File, Help menus
fix: remove unused local variable
* refactor: tweak some icon choices for XDG
* refactor: remove the fallback QStyle::StandardPixmaps
These interfere with deciding whether an icon is well-defined and
unambiguous as per the macOS and Windows HIG guidelines.
If a standard or unambiguous icon exists in the native icon sets,
specify it with an SF Symbols name, a Segoe codepoint,
or XDG standard icon name. Otherwise, leave those fields blank.
* refactor: remove unused #includes
* docs: add "choosing icons" section in NativeIcons.cc
* refactor: simplify icons::shouldBeShownInMenu()
* refactor: reduce unnecessary code shear from main
* refactor: make TorrentDelegate::warning_emblem_ const
* refactor: extract-method MainWindow::updateActionIcons()
* feat: update MainWindow icons when light/dark theme changes
* feat: restore the QStyle::StandardPixmaps as fallbacks
Can be used on older Windows / macOS if Segoe or SF Symbols are unavailable
* refactor: add button text for add/edit/remove tracker buttons
QStyle::StandardPixmap doesn't have good icons for these,
so let's ensure that these buttons have visible text.
* fix: building NativeIconMac.mm on mac even if not clang
* chore: iwyu in new code
* docs: tweak the "Choosing Icons" comments again
* fix: handle changed QStyles in icons::icon()
do not cache point_sizes set between calls
refactor: const correctness
* fixup! refactor: simplify icons::shouldBeShownInMenu()
refactor: minor code tweak, declare vars in order that they are used
Not all Qt styles seem to provide a `DirOpenIcon` icon (Windows 11 style
doesn't, which leads to no icon in the tree), and `DirIcon` is usually
the same (or worse) as the one returned by our icon cache. It's also not
clear why we'd want an _open_ folder icon specifically, given that the
condition in the `else` branch is essentially checking the same thing.
* build: clang-tidy headers when building libtransmission
* chore: revert `= default` workaround
It was introduced in 6909ec0bad to fix build issues with macOS 10.14. We
no longer support that version.
* fix: clang-tidy warnings for libtransmission
* build: clang-tidy headers when building tests
* fix: clang-tidy warnings for tests
* build: clang-tidy headers when building qt
* code review: don't manually edit mime-types.h
* code review: unify variable naming for static private members
* Sync translations with code
* Sync translations with Transifex
* Fix order of plurals for Slovenian
* Add new Mac translations
* Afrikaans (af)
* Greek (el)
Support special (optional) `--` argument to explicitly separate options
from filenames. Support special `---` argument to separate client
arguments from Qt arguments.
* Create a new shared location for icons and update qt scripts to package public icons
* Move the Faenza.qrc back to original location
* Revert "Move the Faenza.qrc back to original location"
This reverts commit 963e099d65.
* Replace Faenza to its original location
* Remove attribution for an image that does not exist
* chore: do not include <set> unless we use it
* chore: do not include <map> unless we use it
* chore: do not include <string> unless we use it
* chore: do not include <list> unless we use it
* chore: do not include <memory> unless we use it
* chore: do not include <optional> unless we use it
* chore: do not include <functional> unless we use it
* perf: make pref_is_savable() constexpr
* refactor: use std::vector in tr_torrents::removedSince()
* chore: remove unused typedef in OptionsDialog
* perf: use std::vector in tr_num_parse_range()
* perf: use small::max_size_set in FileTreeItem::update()
* perf: use small:set in Wishlist::next()
* perf: use small:map in FilterBar
* perf: use small::map for counts in tr_logAddMessage()
* perf: use small::max_size_map in FileTreeModel::twiddleWanted()
perf: use small::max_size_map in FileTreeModel::twiddlePriority()
* perf: use a std::array instead of std::map in TorrentFilter::update()
* perf: use a std::array instead of std::map in TorrentSorter::set_mode()
* perf: use a std::array instead of std::map in TorrentSorter::update()
* perf: use small::set in Application::Impl::on_rpc_changed_idle()
* perf: use std::array for MessageLogColumnsModel::level_names_
* fixup! perf: use std::array for MessageLogColumnsModel::level_names_
* fixup! perf: use small::map for counts in tr_logAddMessage()
* fix: specify `port-test` ip protocol in response when possible
* feat: IPv4 and IPv6 port test in Qt Client
* feat: shorten timeout of `port-test`
* feat: IPv4 and IPv6 port test in Gtk Client
* chore: housekeeping
* refactor: remove IP protocol error message
* code review: mikedld gtk
* feat: return tag in qt rpc response
* code review: mikedld qt
* feat: move port test button up alongside spin button
* fixup! code review: mikedld gtk
* fixup! code review: mikedld qt
* code review: port status initial text
* feat: decouple ipv4 and ipv6 status updates (GTK)
* feat: decouple ipv4 and ipv6 status updates (Qt)
* code review: unknown protocols are non-pending
Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>
* code review: simplify status text when the statuses are the same
* Revert "feat: return tag in qt rpc response"
This reverts commit 2a022c2bb0ee7ddad81f8176839cf0d043422368.
* code review: add translation context for status text (GTK)
* code review: move `port_test_pending_` to `Impl` (GTK)
* fixup! code review: move `port_test_pending_` to `Impl` (GTK)
---------
Co-authored-by: Mike Gelfand <mikedld@users.noreply.github.com>
Label update is made when slider changes its value, and on source change
slider value is being set to a newly calculated, but not necessarily
different from the previous one, value. This means that the slider
change signal may not be emitted, in which case label continues to show
previous text, including "No source selected", which is misleading.
Expose label text as accessible value instead of accessible name, and
get accessible name from buddy label as any proper input widget does.
Don't expose label tooltip as accessible description unless it's
different from its text (which isn't the case when displayed text is
truncated). Notify on label text and selection changes.
Switch to `SqueezeLabel` for values in statistics dialog which has
similar layout to information tab of torrent properties dialog.
