Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-09-20 02:34:37 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixes #112652: A disposed IPC channel should reject all requests with a canceled error, not resolve them

Browse Source
This commit is contained in:
Alexandru Dima
2020-12-16 13:54:06 +01:00
parent 39bd9df739
commit 1abefb9be2
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/base/parts/ipc/common/ipc.ts
+2 -2
View File
@@ -527,13 +527,13 @@ export class ChannelClient implements IChannelClient, IDisposable {
return {
call(command: string, arg?: any, cancellationToken?: CancellationToken) {
if (that.isDisposed) {
return Promise.resolve(errors.canceled());
return Promise.reject(errors.canceled());
}
return that.requestPromise(channelName, command, arg, cancellationToken);
},
listen(event: string, arg: any) {
if (that.isDisposed) {
return Promise.resolve(errors.canceled());
return Promise.reject(errors.canceled());
}
return that.requestEvent(channelName, event, arg);
}