Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-08-19 22:42:35 +01:00
Code Issues Packages Projects Releases Wiki Activity

The TestTextFileEditor doesn't use editor contribution anymore.

Browse Source 
This is because not every test disposes its code editors correctly and leaking contributions (like the `FoldingController`) have weird side-effects (still listening etc). Also, tests at the workbench level don't need editor contribution and editor construction is faster without them

fyi @bpasero
This commit is contained in:
Johannes
2022-08-30 12:40:47 +02:00
parent 59e8b5fb5d
commit 675806facf
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/vs/workbench/test/browser/workbenchTestServices.ts
+1 -1
View File
@@ -194,7 +194,7 @@ export class TestTextResourceEditor extends TextResourceEditor {
export class TestTextFileEditor extends TextFileEditor {
protected override createEditorControl(parent: HTMLElement, configuration: any): void {
this.editorControl = this.instantiationService.createInstance(TestCodeEditor, parent, configuration, {});
this.editorControl = this.instantiationService.createInstance(TestCodeEditor, parent, configuration, { contributions: [] });
}
setSelection(selection: Selection | undefined, reason: EditorPaneSelectionChangeReason): void {