Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-07-07 15:26:49 +01:00
Code Issues Packages Projects Releases Wiki Activity

do not sanitize remote url

Browse Source
This commit is contained in:
Joao Moreno
2019-03-08 10:15:28 +01:00
parent 9fb1a067b6
commit 7ccfdd3a00
1 changed files with 3 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
extensions/git/src/commands.ts
+3 -10
View File
@@ -1809,12 +1809,7 @@ export class CommandCenter {
const sanitize = (name: string) => {
name = name.trim();
if (!name) {
return name;
}
return name.replace(/^\.|\/\.|\.\.|~|\^|:|\/$|\.lock$|\.lock\/|\\|\*|\s|^\s*$|\.$|\[|\]$/g, '-');
return name && name.replace(/^\.|\/\.|\.\.|~|\^|:|\/$|\.lock$|\.lock\/|\\|\*|\s|^\s*$|\.$|\[|\]$/g, '-');
};
const resultName = await window.showInputBox({
@@ -1836,18 +1831,16 @@ export class CommandCenter {
}
if (remotes.find(r => r.name === name)) {
window.showErrorMessage(localize('remote already exists', 'Remote by name \"{0}\" already exists.', name));
window.showErrorMessage(localize('remote already exists', "Remote '{0}' already exists.", name));
return;
}
const resultUrl = await window.showInputBox({
const url = await window.showInputBox({
placeHolder: localize('remote url', "Remote URL"),
prompt: localize('provide remote URL', "Enter URL for remote \"{0}\"", name),
ignoreFocusOut: true
});
const url = sanitize(resultUrl || '');
if (!url) {
return;
}