Remove waitOnExit option from Terminal API

This may turn into an enum or change behavior soon pending on the result of
task-terminal integration. Removing from the API until more thought has been
put into it.

Part of #15583
Part of #18661

src/vs/vscode.d.ts

@@ -3739,11 +3739,6 @@ declare module 'vscode' {
 		 * Args for the custom shell executable, this does not work on Windows (see #8429)
 		 */
 		shellArgs?: string[];
-
-		/**
-		 * Whether the terminal should wait on exit for a keypress before closing the instance.
-		 */
-		waitOnExit?: boolean;
 	}
 
 	/**

src/vs/workbench/api/node/extHostTerminalService.ts

@@ -114,7 +114,7 @@ export class ExtHostTerminalService implements ExtHostTerminalServiceShape {
 	}
 
 	public createTerminalFromOptions(options: vscode.TerminalOptions): vscode.Terminal {
-		let terminal = new ExtHostTerminal(this._proxy, options.name, options.shellPath, options.shellArgs, options.waitOnExit);
+		let terminal = new ExtHostTerminal(this._proxy, options.name, options.shellPath, options.shellArgs/*, options.waitOnExit*/);
 		this._terminals.push(terminal);
 		return terminal;
 	}