Microsoft/vscode
1
0
Fork 0
mirror of https://github.com/microsoft/vscode.git synced 2026-05-02 06:21:50 +01:00
Code Issues Packages Projects Releases Wiki Activity
140,247 Commits 3,759 Branches 361 Tags
4a1c2aebdb9949f8a1e26df9daf865a3a665f5cf
Commit Graph

140247 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Benjamin Pasero
4a1c2aebdb debt - enable no-restricted-syntax for all our code and use local overrides (#274722) 2025-11-03 11:32:53 +00:00
Benjamin Christopher Simmonds
226d88883e Merge pull request #274721 from microsoft/benibenj/revertColorChange 
Revert "Issue #210694 add hoverforeground and hoverbackground to activity bars"
 2025-11-03 12:29:54 +01:00
Daniel Imms
728b4f07cd Merge pull request #274719 from microsoft/tyriar/273177_win 
Only disable tree sitter parser/pwsh on Windows
 2025-11-03 03:25:05 -08:00
Alex Ross
84b460abeb Use dimension equals (#274717) 
from Copilot code review feedback
 2025-11-03 11:17:19 +00:00
BeniBenj
12f4872e2d Revert "Issue #210694 add hoverforeground and hoverbackground to activity bars (#263146)" 
This reverts commit 619c243e4d.
 2025-11-03 12:10:17 +01:00
Ladislau Szomoru
c24799b069 Graph - fix text/icon color when items is selected and focused (#274713) 
* Graph - fix text/icon color when items is selected and focused

* Use the correct color variable
 2025-11-03 10:58:16 +00:00
Johannes Rieken
aced6a179e v2 - collapse selection on keep/undo (#274714) 2025-11-03 10:46:38 +00:00
Johannes Rieken
f6a99cfe76 add unit tests for sound edits in chat editing service, (#274709) 
* add unit tests for sound edits in chat editing service,

https://github.com/microsoft/vscode/issues/272679

* Update src/vs/workbench/contrib/chat/browser/chatEditing/chatEditingTextModelChangeService.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2025-11-03 10:33:40 +00:00
Alex Ross
81ce6774f4 Editing a comment freezes VS Code (#274708) 
Fixes #274455
 2025-11-03 11:16:29 +01:00
Daniel Imms
17d0636ed1 Only disable tree sitter parser/pwsh on Windows 
Part of #273177
 2025-11-03 02:05:47 -08:00
Ladislau Szomoru
2e0c50a661 SCM - polish setting description (#274701) 2025-11-03 10:51:05 +01:00
Tyler James Leonhardt
bf0fa4c73f Finalize idToken API (#274464) 
Fixes https://github.com/microsoft/vscode/issues/140929
 2025-11-03 10:25:57 +01:00
Benjamin Pasero
149668421c update eslint.config.js (#274690) 2025-11-03 08:37:58 +01:00
Ladislau Szomoru
f9a961e0bf Engineering - update .CODENOTIFY (#274687) 2025-11-03 08:11:26 +01:00
Benjamin Pasero
234b127eff debt - apply more linting fixes (#274677) 2025-11-03 06:34:57 +00:00
Rob Lourens
13330e1420 Implement runSubagent2 in core (#274658) 
* Subagent in core

* Support custom subagent id

* Update src/vs/workbench/contrib/chat/common/tools/runSubagentTool.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2025-11-02 20:22:21 -08:00
Justin Chen
34199d40fc thinking settings cleanup and style fix (#274656) 
* thinking settings cleanup and style fix

* update setting description

* Update src/vs/workbench/contrib/chat/browser/chatListRenderer.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2025-11-02 17:43:58 -08:00
Ben Villalobos
4c2ed1a2e7 Add screenreader warning on terminal tool notifications (#274228) 
Enables markdown message parts to receive accessibility information on when to announce statusUpdates (and apply ariaLabel)
 2025-11-02 17:26:25 -08:00
Copilot
9996e714c5 Fix sendToNewChat to cancel in-progress requests (#274629) 
* Initial plan

* Fix sendToNewChat to cancel current request when in progress

Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: roblourens <323878+roblourens@users.noreply.github.com>
 2025-11-03 00:40:52 +00:00
Rob Lourens
7ca2d43133 Fix leaked disposables in BreakpointWidget (#274649) 
* Fix leaked disposables in BreakpointWidget

* Remove dupe registration
 2025-11-03 00:40:20 +00:00
Benjamin Christopher Simmonds
d5d90bed7b extension unification ignore settings validation (#274376) 
* extension unification ignore settings validation

* Update src/vs/workbench/services/configuration/common/configuration.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2025-11-02 23:44:23 +01:00
Amin Sajedian
619c243e4d Issue #210694 add hoverforeground and hoverbackground to activity bars (#263146) 
* Add hover colors for side/top/bottom activity bar in theme and styles

Modified Files Summary

1. Theme Color Definition
[src/vs/workbench/common/theme.ts]
- Define new theme color tokens:
  - `ACTIVITY_BAR_HOVER_FOREGROUND`
  - `ACTIVITY_BAR_HOVER_BACKGROUND`
  - `ACTIVITY_BAR_TOP_HOVER_FOREGROUND`
  - `ACTIVITY_BAR_TOP_HOVER_BACKGROUND`

2. Activity Bar: Theming + Wiring
[src/vs/workbench/browser/parts/activitybar/activitybarPart.ts]
- Register new hover tokens in theme registry
- Map hover tokens to CSS variables for stylesheet consumption
- Wire hover colors into composite bar configuration

3. Activity Bar CSS (Hover Styles)
[src/vs/workbench/browser/parts/activitybar/media/activityaction.css]
- Apply hover styles using new CSS variables:
  - `--vscode-activityBar-hoverForeground`
  - `--vscode-activityBar-hoverBackground`
- Integrate hover states with existing active/focus styling

4. Sidebar: Theming Integration
[src/vs/workbench/browser/parts/sidebar/sidebarPart.ts]
- Reference top-position hover tokens for consistency:
  - `ACTIVITY_BAR_TOP_HOVER_FOREGROUND`
  - `ACTIVITY_BAR_TOP_HOVER_BACKGROUND`
- Ensure sidebar hover behavior aligns with activity bar when positioned at top or bottom

5. Sidebar CSS (Hover Styles)
`src/vs/workbench/browser/parts/sidebar/media/sidebarpart.css`
- Apply hover styling using activity bar CSS variables
- Maintain visual consistency between sidebar and activity bar hover states

6. Stylelint Allowlist
[build/lib/stylelint/vscode-known-variables.json]
- Add CSS custom properties to prevent lint errors:
  - `--vscode-activityBar-hoverForeground`
  - `--vscode-activityBar-hoverBackground`

Usage

settings.json
{
  "workbench.activityBar.location": "default", // "top"
  "workbench.colorCustomizations": {
    // Left Activity Bar
    "activityBar.hoverForeground": "#ff0000",
    "activityBar.hoverBackground": "#00ff00",

    // Top Activity Bar
    "activityBarTop.hoverForeground": "#0000ff",
    "activityBarTop.hoverBackground": "#ffff00"
  }
}

* refactor: move default colors to theme.ts and remove CSS fallbacks in activityaction.css and sidebarpart.css, per feedback.

---------

Co-authored-by: Benjamin Christopher Simmonds <44439583+benibenj@users.noreply.github.com>
 2025-11-02 22:41:56 +00:00
Dmitriy Vasyura
cd5282247e Enable case-insensitive ignore files (#274232) 
* Enable case-insensitive ignore files

* Add unit-tests

* PR feedback
 2025-11-02 23:19:56 +01:00
Christof Marti
470d7704a6 Support loading system certificates with Node 2025-11-02 23:19:00 +01:00
Abinash Karmakar
351475e460 fix: include original URI in resource filtering for multi-file diff e… (#271512) 
fix: include original URI in resource filtering for multi-file diff editor (#271506)
 2025-11-02 18:38:10 +00:00
Alex Ross
a2a6d74b9f Allow git clone command to also always use the cache (#274354) 
* Allow git clone command to also always use the cache

* Fix redundant checks
 2025-11-02 19:27:13 +01:00
Benjamin Pasero
16b9d1ba2a Git - Missing action to "Open File" from a staged new file (fix #249963) (#274182) 2025-11-02 19:21:45 +01:00
Rob Lourens
e69420f2b5 Fix inconsistent tool progress opacity (#274613) 
I think this matches the original intent of this rule
Fix microsoft/vscode-copilot#18275
 2025-11-02 16:44:27 +00:00
Daniel Imms
eb9e7bfcd8 Merge pull request #274589 from microsoft/tyriar/classifier2 
Update classifier with missing labels
 2025-11-02 07:21:09 -08:00
Daniel Imms
95b6298742 Merge pull request #274587 from microsoft/tyriar/264754 
Fix git remote suggest descriptions
 2025-11-02 07:20:52 -08:00
Daniel Imms
544da13d30 Merge pull request #274586 from microsoft/tyriar/267861 
Increase confirmation button padding
 2025-11-02 07:20:27 -08:00
Raymond Zhao
ea01b7e2bb chore: fix SBOM names (#274460) 2025-11-02 14:35:48 +01:00
Daniel Imms
7d407da3ee Update classifier with missing labels 2025-11-02 03:11:04 -08:00
Daniel Imms
279df68391 Fix git remote suggest descriptions 
Fixes #264754
 2025-11-02 02:37:53 -08:00
Daniel Imms
4b4ab95427 Increase confirmation button padding 
Fixes #267861
 2025-11-02 02:27:34 -08:00
Daniel Imms
d8a36d120f Merge pull request #274577 from microsoft/tyriar/269213_unknown 
Use as unknown for unimportant as any cases in tests
 2025-11-02 01:45:23 -08:00
Daniel Imms
cc1cb8b397 Merge pull request #274579 from microsoft/tyriar/269213_api_tests 
Remove as any in vscode-api-tests
 2025-11-02 01:45:07 -08:00
Benjamin Pasero
b487c0264d eslint - disallow querySelector and friends (#274582) 2025-11-02 09:03:41 +00:00
Daniel Imms
1fa5e92868 Merge pull request #274581 from microsoft/tyriar/classifier 
Update my classifier entries
 2025-11-02 01:53:41 -07:00
Matt Bierner
ab44b03a82 Merge pull request #274574 from mjbvz/dev/mjbvz/liquid-toad 
Fix wrong session opened in new window
 2025-11-02 01:43:49 -07:00
Daniel Imms
bffe073ce1 Update my classifier entries 2025-11-02 01:35:10 -07:00
Daniel Imms
80ebe13f31 Remove as any in vscode-api-tests 
Part of #269213
 2025-11-02 01:21:53 -07:00
Daniel Imms
3709e948ed Use as unknown for unimportant as any cases in tests 
Part of #269213
 2025-11-02 01:14:39 -07:00
Matt Bierner
b98669fcbd Fix wrong session opened in new window 
Fixes #274552

We need to grab the session resource before clearing
 2025-11-02 01:01:33 -07:00
Connor Peet
ceb31bb8f5 edits: fix 'restore checkpoint' leaving the request (#274542) 
- For restoring to a request, we actually want to restore the request's
  initial checkpoint but put our pointer before it, so that further
  requests overwrite that request checkpoint.
- We previously didn't discard undone checkpoints when new ones were applied
- Refined the behavior of disablement to more explicitly provide the
  right UX (show up to and including the last checkpoint that contains
  any applied operation)
 2025-11-02 07:05:54 +00:00
Martin Aeschlimann
10650218a3 support disabling custom modes (#274553) 
* support disabling custom modes

* fix tests

* Update src/vs/workbench/contrib/chat/browser/promptSyntax/pickers/promptFilePickers.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix

* fix

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
 2025-11-01 19:02:19 -07:00
Martin Aeschlimann
321ee5586b Remove unused code (#274549) 
remove unused code
 2025-11-01 14:16:54 -07:00
Daniel Imms
61784ef809 Merge pull request #274543 from microsoft/tyriar/274470 
Fix rendering of markdown inside HEREDOC
 2025-11-01 13:52:53 -07:00
Daniel Imms
9ae0922644 Fix rendering of markdown inside HEREDOC 
Fixes #274470
 2025-11-01 13:18:01 -07:00
Connor Peet
ac19bb5794 Merge pull request #274453 from microsoft/connor4312/extensible-tool-confirmations 
tools: split out confirmation service from tools service
 2025-11-01 12:45:49 -07:00