Commit Graph

116669 Commits

Author SHA1 Message Date
Connor Peet
7bc7686565 aux window: add barrier waiting for styles to load (#199882)
* wip

* aux window: add barrier waiting for styles to load

The debug toolbar needs to compute its size and positioning, which without this fails if executed in onDidChangeActiveContainer. The result of these changes is a new property on the ILayoutService.

* address comments

* address comments

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-12-04 19:33:03 +01:00
Johannes Rieken
23f27634a4 fix https://github.com/microsoft/vscode/issues/188441 (#199967) 2023-12-04 09:06:27 -08:00
Matt Bierner
c7a0dee66f Add issue grooming notebook (#199966) 2023-12-04 17:56:05 +01:00
Johannes Rieken
97082b0ca5 warn/report invalid code lenses but don't surface them in the UI (#199962)
re https://github.com/microsoft/vscode/issues/197643
2023-12-04 16:45:25 +01:00
Johannes Rieken
d5fe76749a fix https://github.com/microsoft/vscode/issues/177059 (#199952) 2023-12-04 15:01:57 +01:00
Simon Siefke
38347ca237 fix: memory leak in color picker widget (#199815) 2023-12-04 15:00:02 +01:00
Johannes Rieken
56934582c3 fix https://github.com/microsoft/vscode/issues/173431 (#199951) 2023-12-04 14:48:29 +01:00
Ulugbek Abdullaev
3786cdcf9e meta: settings.json: wrap lines for github-issues notebooks (#199950) 2023-12-04 14:41:17 +01:00
Benjamin Pasero
7e67ab1991 aux window - allow AUX_WINDOW_GROUP in openEditor(s) to open in new window (#199945) 2023-12-04 14:13:37 +01:00
Johannes Rieken
dc732fc25e fix https://github.com/microsoft/vscode/issues/170041 (#199942) 2023-12-04 12:33:55 +01:00
Johannes Rieken
6ff96367c0 Merge pull request #195409 from RobbyCBennett/main
make gotoErrorWidget styling of relatedInformation more consistent with that of markerHoverParticipant
2023-12-04 12:18:25 +01:00
Johannes Rieken
0feb1e20dd Merge branch 'main' into main 2023-12-04 11:25:23 +01:00
Benjamin Pasero
b04250d322 output - allow to open any file backed channel as editor (#199850)
* output - allow to open any file backed channel as editor

* address feedback
2023-12-04 11:19:57 +01:00
João Moreno
8610f916a4 improve async data tree default collapsed state computation (#199899)
* improve async data tree default collapsed state computation

fixes #199441

* unset forceExpanded flag
2023-12-04 11:12:50 +01:00
Alexandru Dima
4276925e10 Schedule animation frame runners in each editor's window (#199933)
Schedule animation frame runners in each editor's window (fixes #199868)
2023-12-04 10:29:34 +01:00
Johannes Rieken
86f1cc0eaf update feature-labels list (#199930) 2023-12-04 09:55:44 +01:00
Benjamin Pasero
07eba0ac37 Aux window: show screen reader status entry everywhere (fix #199428) (#199920)
* Aux window: show screen reader status entry everywhere (fix #199428)

* .
2023-12-04 09:49:08 +01:00
Sandeep Somavarapu
784bd835de Merge pull request #199902 from sandy081/sandy081/developing-swordfish
change log level format in argv file
2023-12-04 09:45:04 +01:00
Aiday Marlen Kyzy
83722efcc0 Do not show when sparkle icon when showAiIconMode is Off (#199642)
* using the setting in order to control if the AI icon is shown

* add a method to clear the classes before an early return is done

* reverting the code and placing the check inside of the _update method
2023-12-04 09:35:45 +01:00
Benjamin Pasero
a46fe7114a aux window - introduce and adopt methods to check on active and focused elements (#199897)
* aux window - introduce and adopt methods to check on active and focused elements

* simplify

* .

* .

* .

* .
2023-12-04 09:13:42 +01:00
Rob Lourens
ada980d563 Merge interactiveUserActions proposal into chatAgents2Additions, and get rid of the old global event (#199916)
Towards #197687
2023-12-04 05:58:17 +01:00
Rob Lourens
f0d15e2878 Let the chat open action take isPartialQuery to set text in the chat input (#199913) 2023-12-03 17:54:32 -08:00
Rob Lourens
ef7a4529be Fix chat history not being deduped (#199915)
Fix #199719
2023-12-04 01:45:18 +01:00
Rob Lourens
34d475b9c9 Fix cmd+up/down in chat input to match my expectations (#199912) 2023-12-04 11:38:02 +11:00
Rob Lourens
967abeaacb Fix error message: "Cannot read properties of undefined (reading 'chatDynamicVariableModel')" (#199909)
Fix #199818
2023-12-03 23:56:17 +01:00
Sandeep Somavarapu
dd998e0294 change log level format 2023-12-03 21:30:33 +01:00
Ladislau Szomoru
4b9608ccce SCM - SCMInputWidget toolbar 💄 (#199885) 2023-12-03 10:56:35 +01:00
Benjamin Pasero
21048de4d6 eng - fix hygiene (#199883) 2023-12-03 08:30:02 +01:00
Daniel Imms
d3799912b7 Merge pull request #199821 from cpendery/build/enable-suggestions
build: enable suggestions when 'shellIntegration.suggestEnabled' is true
2023-12-02 18:59:34 -08:00
Robo
ef804e738b chore: update electron@25.9.7 (#199854)
* chore: update electron@25.9.7

* chore: bump distro
2023-12-02 08:17:36 -07:00
Benjamin Pasero
f48cf5f196 aux window - patch HTMLElement.focus() to focus owning window (#199837)
* aux window - patch `HTMLElement.focus()` to focus owning window

* fix tests
2023-12-02 14:31:26 +01:00
Benjamin Pasero
8c24af1bf4 aux window - track input focus properly (#199729) (#199839) 2023-12-02 08:26:08 +01:00
Benjamin Pasero
0a13aeb3f4 aux window - fix web (#199836) (#199838) 2023-12-02 08:25:30 +01:00
Joyce Er
fda96c2ab0 fix: track empty editor content widget visibility in contrib (#199834) 2023-12-01 17:37:56 -08:00
Ladislau Szomoru
c8ba610046 SCM - more scm input box toolbar cleanup (#199833)
* Cleaning up context keys

* SCM - more scm input box toolbar cleanup

* Fix compilation error
2023-12-01 17:28:58 -08:00
Joyce Er
4fc3ed3527 feat: render keybinding label for chat /help command link (#199831) 2023-12-02 01:37:46 +01:00
Connor Peet
8a3a7a73bb testing: canonicalize uris upon deserialization (#199824)
Resolves cases of file sensitivity mishandling.

Fixes #199699
2023-12-01 15:21:04 -08:00
Daniel Imms
55166da35b Merge pull request #199817 from microsoft/tyriar/copilot_622
Prefer runCommand over sendText
2023-12-01 14:29:08 -08:00
Chapman Pendery
1341061b2c Merge branch 'main' into build/enable-suggestions 2023-12-01 14:25:06 -08:00
Chapman Pendery
613142b826 build: enable suggestions when 'shellIntegration.suggestEnabled' is true
Signed-off-by: Chapman Pendery <cpendery@microsoft.com>
2023-12-01 14:07:26 -08:00
Daniel Imms
dfc36257c1 Prefer runCommand over sendText
Fixes microsoft/vscode-copilot-release#622
2023-12-01 13:51:48 -08:00
Aaron Munger
dc5e66524d do not focus webview if the event originated from clicking the webview (#199816) 2023-12-01 13:43:59 -08:00
Daniel Imms
f3219b52c2 Merge pull request #199806 from microsoft/tyriar/199775
Only show devMode markers on hover
2023-12-01 12:53:49 -08:00
Connor Peet
9c3b7a5025 testing: allow opening peek for messages without an explicit location (#199810)
Fall back to peeking the test location.

Fixes #199552
2023-12-01 21:49:44 +01:00
Ladislau Szomoru
f84b90130d SCM - remove old action bar from SCMInputWidget (#199809) 2023-12-01 21:45:24 +01:00
Connor Peet
1cc9382ff5 trees: fix error on dispose during render (#199807)
Fixes #199264
2023-12-01 12:35:00 -08:00
Benjamin Pasero
c9a12137d4 aux window - fix action context for move/copy (#199797) 2023-12-01 12:04:53 -08:00
Daniel Imms
6506c6ef34 Merge pull request #199420 from cpendery/fix/terminal-suggestion-positioning
fix: terminal suggestion positioning
2023-12-01 11:59:32 -08:00
Daniel Imms
986a1770d9 Only show devMode markers on hover
Fixes #199775
2023-12-01 11:56:02 -08:00
Benjamin Pasero
c996ea1673 debt - move widget to where it is used 2023-12-01 20:17:16 +01:00