Benjamin Pasero
7d7dfa8f3e
debt - refer to tab height also in code
2023-09-09 13:28:26 +02:00
Benjamin Pasero
a54f99fec1
debt - rename titleControl to editorTabsControl
2023-09-09 13:25:56 +02:00
Benjamin Pasero
288532a45a
debt - rename tabsTitleControl to multiEditorTabsControl
2023-09-09 13:22:03 +02:00
Benjamin Pasero
f1679692cf
debt - rename noTabsTitleControl to singleEditorTabsControl
2023-09-09 13:19:42 +02:00
Benjamin Pasero
4948f9abe9
debt - move accessibilityStatus to contrib/accessibility
2023-09-09 13:15:33 +02:00
Benjamin Pasero
beada0b017
debt - inline iframe into base/iframe
2023-09-09 13:12:32 +02:00
Benjamin Pasero
57fd2d68d4
debt - inline tabFocus into editorStatus
2023-09-09 13:12:01 +02:00
Tyler James Leonhardt
41e940f76f
Use SequencerByKey to sequence operations of the same set of scopes ( #192638 )
...
The idea here is... if a token is currently being refreshed, well then getting a token of those scopes should wait for that to finish.
Core has a really nice `SequencerByKey` for exactly this kind of thing, and so I've stolen that and started to organize the code with a `common` folder.
Oh, I also noticed we were sorting twice and fixed that to only sort once.
ref https://github.com/microsoft/vscode/issues/186693
2023-09-09 07:09:20 +02:00
Peng Lyu
106ac0b4c0
Merge pull request #192480 from microsoft/rebornix/holy-canidae
...
Re #190503 . Dispose notebook land tests properly.
2023-09-08 22:08:52 -07:00
Tyler James Leonhardt
6fe1a14974
Have ChatView be default "Ask Chat" location ( #192608 )
...
and introduce a setting to change that behavior.
2023-09-08 17:18:25 -07:00
rebornix
976ea0f4e6
Fix leaks for language reg.
2023-09-08 16:53:22 -07:00
Joyce Er
08beac9889
fix: use markdown in terminal setting descriptions ( #192634 )
2023-09-08 16:50:32 -07:00
Joyce Er
7fa19c93cd
fix: don't show inline chat hint with ghost text ( #192642 )
...
Also disables inline chat hint in notebook cells.
`ICodeEditor.hasTextFocus()` is always false for notebook cells. We need
a way to ensure we only show the hint for the active notebook cell
2023-09-09 01:48:56 +02:00
Joyce Er
fe020f2369
fix: markdown for more descriptions in settings UI ( #192636 )
2023-09-09 00:48:37 +02:00
Aiday Marlen Kyzy
551aa2772b
Merge pull request #191464 from microsoft/aiday/notRebuildingFullStickyScroll
...
Minimizing the rebuild of sticky scroll
2023-09-08 23:53:14 +02:00
Tyler James Leonhardt
52f27e2e2f
Log a lot more of the Microsoft Auth extension ( #192629 )
...
This PR adds a ton more logging, a consistant format, and fixes the log levels of some.
Additionally, there are two small fixes that I have included:
* we were firing the `_sessionChangeEmitter` twice when a session was removed
* when processing updates from other windows, we returned instead of continued... thus were only processing the first account that was added in another window
2023-09-08 23:25:25 +02:00
Joyce Er
bb99b7452a
fix: render setting reference links in settings UI ( #192628 )
2023-09-08 23:21:31 +02:00
Connor Peet
fbdc92cac0
cli: fix delegated http requests not working ( #192620 )
...
From a refactor last literation. I don't think this is candidate worthy
as it's an uncommon path with remote-tunnels, and we can just toggle
this off for remote-ssh for this iteration.
2023-09-08 13:26:36 -07:00
Ladislau Szomoru
5ffa9573af
Git - remove extra character from the log message ( #192622 )
2023-09-08 16:25:12 -04:00
João Moreno
338e449e42
More test disposables cleanup (new attempt) ( #192618 )
...
* ensureNoDisposablesAreLeakedInTestSuite: async
* ensureNoDisposablesAreLeakedInTestSuite: actionbar
* ensureNoDisposablesAreLeakedInTestSuite: buffer
* ensureNoDisposablesAreLeakedInTestSuite: cancellation
* one more async fix
2023-09-08 20:45:35 +02:00
Joyce Er
9476bf37c1
fix: don't show inline chat hint in search editor ( #192614 )
2023-09-08 20:00:39 +02:00
Connor Peet
cd4bd7e64b
forwarding: add a warning for public ports ( #192599 )
...
* forwarding: add a warning for public ports
A number of users have raised some security concerns about port
forwarding. Forwarded ports are private (requiring auth with the same
GH account that did the forwarding) by default. When making a port
public, show the following dialog:

* Update extensions/tunnel-forwarding/src/extension.ts
Co-authored-by: Joyce Er <joyce.er@microsoft.com >
---------
Co-authored-by: Joyce Er <joyce.er@microsoft.com >
2023-09-08 19:19:50 +02:00
Sandeep Somavarapu
8627ee4504
preps for ensureNoDisposablesAreLeakedInTestSuite ( #192603 )
...
#190503 preps for ensureNoDisposablesAreLeakedInTestSuite
2023-09-08 19:16:20 +02:00
Alex Ross
b257cce9e7
Fix leaks from extHostTreeView and test ( #192578 )
...
* Fix leaks from extHostTreeView and test
Part of #190503
* Fix build break
---------
Co-authored-by: Joyce Er <joyce.er@microsoft.com >
2023-09-08 18:50:34 +02:00
Peng Lyu
53ddd1a6f2
Merge branch 'main' into rebornix/holy-canidae
2023-09-08 09:41:10 -07:00
Martin Aeschlimann
d97b7bbe5c
theme initialization: Do not wait for settings sync ( #192597 )
2023-09-08 09:37:19 -07:00
Joyce Er
079d0abf1c
fix: don't show inline chat hint for log language ( #192586 )
...
* fix: don't show inline chat hint for log language
* fix: don't show hint in readonly editors
2023-09-08 09:34:58 -07:00
Sandeep Somavarapu
b45439143e
adopt to ensureNoDisposablesAreLeakedInTestSuite ( #192596 )
...
#190503 adopt to ensureNoDisposablesAreLeakedInTestSuite
2023-09-08 18:34:41 +02:00
Andrea Mah
088d73042e
Unexpected logs in SearchModel unit tests ( #192501 )
...
Fixes #192428
2023-09-08 09:04:49 -07:00
Joyce Er
a5b244bbc8
revert: "More test disposables cleanup" ( #192593 )
...
Revert "More test disposables cleanup (#192575 )"
This reverts commit 35c2ce3aac .
2023-09-08 18:04:34 +02:00
Tyler James Leonhardt
a4a2d8f0f4
Rename --disable-keytar to --use-inmemory-secretstorage ( #192312 )
...
This renames the flag as the title suggests but keeps `--disable-keytar` in the `deprecates` section so it still works.
Fixes https://github.com/microsoft/vscode/issues/191498
2023-09-08 17:58:32 +02:00
Johannes Rieken
93b79352e4
Merge pull request #192589 from microsoft/joh/personal-snipe
...
more `ensureNoDisposablesAreLeakedInTestSuite` work
2023-09-08 17:56:50 +02:00
Johannes
2aa802458e
more ensureNoDisposablesAreLeakedInTestSuite work
2023-09-08 17:14:11 +02:00
João Moreno
35c2ce3aac
More test disposables cleanup ( #192575 )
...
* ensureNoDisposablesAreLeakedInTestSuite: async
* ensureNoDisposablesAreLeakedInTestSuite: actionbar
* ensureNoDisposablesAreLeakedInTestSuite: buffer
* ensureNoDisposablesAreLeakedInTestSuite: cancellation
2023-09-08 15:43:48 +02:00
Sandeep Somavarapu
89719831aa
adopt to ensureNoDisposablesAreLeakedInTestSuite ( #192574 )
...
#190503 adopt to ensureNoDisposablesAreLeakedInTestSuite
2023-09-08 15:27:34 +02:00
Martin Aeschlimann
79df0660a9
remove unused FormattingOptions.ranges ( #192573 )
2023-09-08 15:10:28 +02:00
Alex Ross
b93082f0c0
Use markAsSingleton in touch.ts ( #192572 )
2023-09-08 15:05:54 +02:00
Henning Dieterichs
83547819dc
Fixes #192446
2023-09-08 14:58:50 +02:00
Alex Ross
5ae46ad300
Cache last quick diff ( #188506 )
...
Fixes #179441
2023-09-08 14:48:44 +02:00
Joyce Er
0795888f65
fix: avoid fs dependency in web ( #192565 )
...
* feat: quick fix for redundant activation events
* fix: avoid `fs` dependency in web
2023-09-08 14:23:04 +02:00
Sandeep Somavarapu
f4700718ba
dispose throttler ( #192563 )
2023-09-08 14:20:37 +02:00
João Moreno
e2aa12d977
ensureNoDisposablesAreLeakedInTestSuite: paging ( #192477 )
...
* ensureNoDisposablesAreLeakedInTestSuite: paging
related to #190503
* fix hygiene
2023-09-08 14:16:40 +02:00
Henning Dieterichs
758b4561b2
Improves error reporting. FYI @jrieken
2023-09-08 14:16:07 +02:00
Alex Ross
91fa749999
Fix local port error message ( #192552 )
...
Fixes #191929
2023-09-08 14:15:36 +02:00
Benjamin Pasero
9238c19bf1
debt - fix more unit test disposables ( #192538 )
...
* debt - fix more unit test disposables
* input
* input
* input
* input
* input
* input
* input
2023-09-08 14:15:04 +02:00
Johannes Rieken
1a3cfcf0ae
Merge pull request #192528 from microsoft/joh/breakable-mule
...
Joh/breakable-mule
2023-09-08 11:57:21 +02:00
Aiday Marlen Kyzy
42f29fa3db
remove padding because now inline block
2023-09-08 11:50:35 +02:00
Aiday Marlen Kyzy
c35f9bc921
setting display of inner line number to inline-block
2023-09-08 11:33:19 +02:00
Aiday Marlen Kyzy
c3dc2d5761
continuing instead of early returning
2023-09-08 11:05:50 +02:00
Aiday Marlen Kyzy
a41404676c
Merge branch 'main' into aiday/notRebuildingFullStickyScroll
2023-09-08 11:03:10 +02:00