Commit Graph

1631 Commits

Author SHA1 Message Date
Tyler James Leonhardt
a4a2d8f0f4 Rename --disable-keytar to --use-inmemory-secretstorage (#192312)
This renames the flag as the title suggests but keeps `--disable-keytar` in the `deprecates` section so it still works.

Fixes https://github.com/microsoft/vscode/issues/191498
2023-09-08 17:58:32 +02:00
Sandeep Somavarapu
2aa8453e35 Merge pull request #192270 from microsoft/sandy081/dreadful-ferret
#191860 - retry if command is not found
2023-09-06 11:59:04 +02:00
Sandeep Somavarapu
9ed384ffe7 fix while check 2023-09-06 11:10:35 +02:00
Sandeep Somavarapu
7b15902db0 only check for No matching commands text 2023-09-06 10:58:27 +02:00
Sandeep Somavarapu
6e93ce037b feedback 2023-09-06 10:30:13 +02:00
Robo
ab2afd626f chore: disable hardware acceleration support for linux smoke tests (#192265) 2023-09-06 16:58:16 +09:00
Sandeep Somavarapu
7a0fecc0a7 #191860 - retry if command is not found 2023-09-06 09:36:50 +02:00
Johannes Rieken
137b724984 Merge branch 'main' into joh/corporate-canid 2023-09-05 13:50:57 +02:00
Johannes
8f4d4d4bad workaround browser bug, fix browser test debugging 2023-09-05 11:47:13 +02:00
Sandeep Somavarapu
eafe1c398d #191860 skip until insiders is released 2023-09-04 17:29:31 +02:00
Sandeep Somavarapu
63d4fe776b fix #191860 (#192121) 2023-09-04 13:30:46 +02:00
Tyler James Leonhardt
79277e0b8f Skip flakey smoke test (#191936)
* Skip flakey smoke test

ref https://github.com/microsoft/vscode/issues/191860

* skip at describe since there's only 1 test
2023-08-31 23:34:22 +02:00
Alpha Romer Coma
7ef754c2f6 Fix supported markdown-lint violations in markdown files (#190750)
docs: fix supported markdownlint violations
2023-08-24 08:37:25 +00:00
Raymond Zhao
a08322ae0a Add delay to Settings editor search for smoke tests (#190903)
Ref #190896
2023-08-21 20:54:48 +01:00
Connor Peet
6a847ba6d1 eng: add support for snapshot tests (#190444)
* eng: add support for snapshot tests

This adds Jest-like support for snapshot testing.
Developers can do something like:

```js
await assertSnapshot(myComplexObject)
```

The first time this is run, the snapshot expectation file is written
to a `__snapshots__` directory beside the test file. Subsequent runs
will compare the object to the snapshot, and fail if it doesn't match.

You can see an example of this in the test for snapshots themselves!

After a successful run, any unused snapshots are cleaned up. On a failed
run, a gitignored `.actual` snapshot file is created beside the
snapshot for easy processing and inspection.

Shortly I will do some integration with the selfhost test extension to
allow developers to easily update snapshots from the vscode UI.

For #189680

cc @ulugbekna @hediet

* fix async stacktraces getting clobbered

* random fixes

* comment out leak detector, for now

* add option to snapshot file extension
2023-08-15 12:03:51 -07:00
Raymond Zhao
42b4bf0670 Add Settings editor smoke tests (take 2) (#189867) 2023-08-08 13:01:53 -07:00
Raymond Zhao
39e5dafcd6 Revert "Add Settings editor smoke tests" (#189848)
Revert "Add Settings editor smoke tests (#189687)"

This reverts commit e1dfb2a559.
2023-08-07 18:40:37 +01:00
Raymond Zhao
e1dfb2a559 Add Settings editor smoke tests (#189687)
Fixes #141054
2023-08-07 08:22:07 -07:00
Robo
ea490e5545 chore: update to Electron 25 (#188268)
* chore: update electron@25.3.0

* ci: update NodeTool version

* chore: update @types/node

* add more common types to layers checker

* chore: update debian dependencies

* chore: update rpm dependencies

* fix: use legacy dns result order of Node.js

* ci: remove deprecated always-auth npm config

Refs npm/cli@72a7eeb

* chore: update deb and rpm dependencies

* chore: update armhf rpm dependencies

* chore: update x64 debian dependencies

* chore: update x64 rpm dependencies

* chore: update electron@25.3.1

* chore: update electron@25.4.0

* chore: bump distro

* chore: bump distro

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-08-07 21:46:27 +09:00
Benjamin Pasero
cbdfe4e0b4 Removal of feedback control (fix #188960) (#189027) 2023-07-28 10:12:52 +02:00
Raymond Zhao
5be539a588 Bump semver (#187654) 2023-07-12 01:49:45 +02:00
Raymond Zhao
c067a3bf81 chore: bump semver 7 dependencies (#187171) 2023-07-06 20:18:02 +02:00
Connor Peet
2138622b04 build: add watch/compile tasks for CLI (#182344)
* build: add watch/compile tasks for CLI

I spent time this morning working on the 'developer experience' of the
CLI in vscode, mainly getting the CLI to cross-compile chasing our
initial idea of having it auto-build in a devcontainer.

After some effort and disabling tunnels connections (to avoid having to
pull in OpenSSL which is a huge pain to cross compile), I was able to
get it to cross-compile from Linux to Windows, using the mingw linker.
I could probably figure out how to get macOS working as well with more
effort. However, I'm not a big fan of this, effectively it's one more
'platform' of build we need to support and test.

I think a better approach is downloading the latest compiled CLI from
the update server instead, as needed. That's what this PR does. It just
places the CLI where it _would_ normally get compiled to by cargo; so
far we don't need to do anything special outside of that.
A notice is shown to users if this fallback happens.

* update from review
2023-06-20 14:34:11 -07:00
Benjamin Pasero
424388032a tests - increase timeout when running in CI (#182288) 2023-05-12 13:02:15 +02:00
Benjamin Pasero
4c45cff558 Data loss smoke test failures (fix #181952) (#182059) 2023-05-10 14:23:12 +00:00
Benjamin Pasero
3f7bc08865 tests - do not break codeAutomationExit API (refs microsoft/vscode-test-web#82) (#181682) 2023-05-08 12:36:55 +02:00
Benjamin Pasero
1894181c08 logs - make sure to attach all logs in browser tests (#181578)
* logs - make sure to attach all logs in browser tests

* separate server logs into `server` folder
2023-05-05 07:02:40 +02:00
Benjamin Pasero
c4a46ef344 Expose client (browser) logs for integration tests running in browser (#180102) (#181513) 2023-05-04 15:28:25 +02:00
Benjamin Pasero
5eba2f631f Expose client (browser) logs for smoke tests running in browser (fix #180102) (#181491) 2023-05-04 12:05:03 +02:00
Tyler James Leonhardt
9af6054416 Hide details if there are none (#181384)
* try this again

* use display to follow separator and make smoke tests only grab label not description or detail
2023-05-03 09:34:14 +02:00
Robo
e5f61433b5 chore: update to Electron 22 (#177600)
* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* sandbox - cleanup from electron 22 update (#178919)

* Revert "chore: revert to Electron 19 (#175851)"

This reverts commit 3a11b47eee.

* chore: bump electron@22.3.3

* build: use custom version for V8 sandbox

* chore: update electron@22.4.1

* chore: enable forceAllocationsToV8Sandbox for extension host

* chore: bump electron@22.4.2

* chore: bump electron@22.4.3

* temp: update distro

* sandbox - cleanup from electron 22 update

* missing comile

* more changes

* fix build

* restore

* 💄

* compile

---------

Co-authored-by: deepak1556 <hop2deep@gmail.com>

---------

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-04-03 09:09:31 +02:00
Benjamin Pasero
b0b69338e8 debt - further reduce electron-browser layer (#178504)
* debt - move more tests out of `electron-browser`

* move more tests

* move preload script as well

* fix
2023-03-28 10:35:58 -07:00
Benjamin Pasero
bc9b50e2d7 smoke - fix timeouts waiting for window (#177984) 2023-03-22 10:15:52 +01:00
Tyler James Leonhardt
378b0d711f Implement titlebar logic using a new NLS property (#177426)
* Revert "Have English language return default result (#175157)"

This reverts commit 3c9f409888.

* Revert "Fix locale and language handling (#174779)"

This reverts commit 4e32196835.

* Revert "Add en as fallback osLocale (#175039)"

This reverts commit 7b6b6869e8.

* Revert "Ensuring locale is set to the OS locale and language is set to the Application Language (#174733)"

This reverts commit ecf479e662.

* Implement titlebar correctly using platformLocale
2023-03-17 09:32:40 +01:00
Benjamin Pasero
2c3a648d88 smoke - remove timeout from launches (#177204) 2023-03-15 13:35:17 +01:00
Benjamin Pasero
8bd4a421c0 smoke - fix electron window timeout (#176012) 2023-03-03 08:28:18 +01:00
Benjamin Pasero
6dfe534cca smoke - bring back better solution for waiting that target has loaded (#175415) 2023-02-25 17:41:18 +01:00
Benjamin Pasero
aa07f07339 smoke - update didFinishLoad solution (#175409) 2023-02-24 21:17:19 -08:00
Benjamin Pasero
def1c0dc47 smoke test - try to unblock CI (#175382)
* smoke test - try to fix runs

* comment
2023-02-24 21:35:41 +01:00
Raymond Zhao
7b6b6869e8 Add en as fallback osLocale (#175039) 2023-02-21 17:26:37 -08:00
Tyler James Leonhardt
4e32196835 Fix locale and language handling (#174779)
* Use language to get config and fix smoke test

* better check

* not

* fix a lot of mistakes

* skip test on linux
2023-02-19 08:17:04 +01:00
Martin Aeschlimann
dc619de8d9 Icons in problems view show black when not focused (#174487)
* Icons in problems view show black when not focused

* update smoke test
2023-02-15 22:34:14 +01:00
Rob Lourens
be54d2be91 Check notebook URIs in BulkCellEdits (#169669)
* Revert "Disallow cell URIs with NotebookEdit"

This reverts commit d7576eea81.

* Check notebook URIs in BulkCellEdits
Fix #146690
2023-01-07 17:35:25 -08:00
Benjamin Pasero
689624e401 tests - fix web integration tests to fail creating a page (#170613) 2023-01-05 02:54:56 -08:00
Alexandru Dima
06b97f6be7 Add more logging and perf markers around resolving the connection token and the socket factory (#170490)
* Add more logging and perf markers around resolving the connection token and the socket factory

* set `exposeFunction` earlier

* bla windows

* also expose function for unit tests beofre opening

Co-authored-by: Benjamin Pasero <benjamin.pasero@microsoft.com>
2023-01-05 10:17:19 +01:00
Matt Bierner
57dd298b47 Add typings for test runner scripts (#169196) 2022-12-15 02:19:24 +01:00
Connor Peet
812ef50afe smoke: adopt new vscode test version (#168373)
Has timeout logic that fixes #166092
2022-12-08 01:14:41 +01:00
Connor Peet
0899758dae ipc: use vql for uint types (#167407)
* ipc: use vql for uint types

On the plane I was reverse-engineering ipc.ts to implement it in Rust
and see if we could have a "service mode" for the CLI that we could
interact with like any other vscode process.

In doing so, I noticed that numbers in the protocol--which are used at
least twice in the message header and ID--were encoded as JSON. I was
curious what benefits we'd get from encoding them as variable-length
integers instead.

It makes the message shorter, as expected. Encode/decode time are very,
very slightly lower. I'm not sure it's worth the extra complexity, but
I have included it here for your consideration.

* fixup tests
2022-12-02 15:54:36 -08:00
Ladislau Szomoru
96d05578ac Test - update minimatch (#167101) 2022-11-23 21:33:27 +00:00
Johannes
d555777b1a simplify _VSCODE_NODE_MODULES util 2022-11-18 09:42:32 +01:00