Commit Graph

149541 Commits

Author SHA1 Message Date
Ladislau Szomoru
bdea2b4df8 Git - scaffold the git extension API (#305643)
* Git - scaffold the git extension API

* Pull request feedback
2026-03-27 13:56:36 +00:00
Benjamin Pasero
0ed75f3304 fix - remove experimental tags from useModal setting (#305616) 2026-03-27 13:51:54 +00:00
Benjamin Pasero
2ce60b1963 sessions - render pinned state from toolbar (#305620)
* sessions - render pinned state from toolbar

* Update src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* .

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 13:48:46 +00:00
Lee Murray
e2c78d20cb Improve accessibility labels and CSS styling for agent session sections (#305604)
* Improve accessibility labels for agent session sections and enhance CSS styling for section labels

* Enhance accessibility tests for agent session sections by updating aria label checks for singular and plural session counts

Co-authored-by: Copilot <copilot@github.com>

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot <copilot@github.com>
2026-03-27 14:40:14 +01:00
Lee Murray
67bafb26c5 Improve focus styles for action items in auxiliary bar and panel (#305594)
* Improve focus styles for action items in auxiliary bar and panel

* Update src/vs/sessions/browser/parts/media/panelPart.css

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/vs/sessions/browser/parts/media/auxiliaryBarPart.css

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/vs/sessions/browser/parts/media/panelPart.css

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 14:39:45 +01:00
Lee Murray
d4ca6e65d2 Enhance accessibility for changes title bar widget with ARIA attributes (#305574)
* Enhance accessibility for changes title bar widget with ARIA attributes

* Refactor ChangesTitleBarIndicator for improved accessibility and state management

---------

Co-authored-by: mrleemurray <mrleemurray@users.noreply.github.com>
2026-03-27 14:39:13 +01:00
Sandeep Somavarapu
9e092b19ef sessions: fix sticky section padding in sessions list (#305649)
sessions - add padding to sticky container in session list
2026-03-27 14:31:34 +01:00
Logan Ramos
3397429f95 Add EDU to chat entitlment handling (#305648) 2026-03-27 14:31:29 +01:00
Sandeep Somavarapu
d64acf25ce fix #304746 (#305641)
* fix #304746

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 13:17:35 +00:00
Benjamin Christopher Simmonds
0471cfb714 Merge pull request #305633 from microsoft/benibenj/brief-hawk
Add approval timestamp to session approval info
2026-03-27 14:03:39 +01:00
Benjamin Christopher Simmonds
d1532b9af7 Merge pull request #305630 from microsoft/benibenj/moral-salmon
Support rename and delete actions for chats
2026-03-27 14:02:39 +01:00
Benjamin Christopher Simmonds
9a61fdbede agentFeedback: enable edit for PR/code review comments with auto-convert to feedback (#305622)
* Refactor edit action handling for agent feedback comments
2026-03-27 13:48:19 +01:00
Ladislau Szomoru
dec614e501 Sessions - toggle isolationOption setting (#305621) 2026-03-27 13:14:30 +01:00
BeniBenj
6bfb9bcca9 fix: add missing 'since' property to IAgentSessionApprovalInfo literals in fixture 2026-03-27 13:06:55 +01:00
BeniBenj
afbafa7af9 fix test 2026-03-27 12:59:01 +01:00
BeniBenj
70072c5e4e sessions - add approval timestamp to session approval info and update approval retrieval logic 2026-03-27 12:54:22 +01:00
Benjamin Christopher Simmonds
f11491d1b0 sessions: show agent feedback count per file in changes view (#305613)
Add agent feedback count and badge to changes view

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-27 11:45:35 +00:00
BeniBenj
2662642786 support rename and delete 2026-03-27 12:16:21 +01:00
Benjamin Pasero
13956d46e5 sessions - hide 2nd row stuff when session in progress (#305549)
* sessions - hide 2nd row stuff when session in progress

* Update src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* sessions: clear timeDisposable when hideDetails is true to prevent timer leak

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/e0e96a2b-6b5b-49b9-bfe7-3161a5d7ed88

Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>

* Update src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Update src/vs/sessions/contrib/sessions/browser/views/sessionsList.ts

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: bpasero <900690+bpasero@users.noreply.github.com>
2026-03-27 11:48:21 +01:00
Benjamin Pasero
dd52de3c9a sessions - fix gap for diff indicator (#305556) 2026-03-27 11:46:56 +01:00
Benjamin Pasero
1c0268339d sessions - expand more when find is open (#305555) 2026-03-27 11:46:44 +01:00
Ladislau Szomoru
8394aa0cfc Sessions - fix changes inline toolbar and polish picker (#305593)
* Sessions - fix changes inline toolbar and polish picker

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Pull request feedback

* Fix compilation

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-27 10:27:04 +00:00
Abhitej John
78a390832f Skills usage telemetry (#303110)
* Add per-skill telemetry when skills are loaded into agent context

Add a new 'skillLoadedIntoContext' telemetry event that fires for each
skill loaded into agent context. This captures:
- Skill name
- Skill storage source (local, user, extension, plugin, internal)
- SHA-1 hash of the SKILL.md file content (integrity verification)

The event fires in computeAutomaticInstructions.ts where skills are
filtered and loaded into the chat system prompt, providing per-request
skill usage visibility.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Replace skillVersion/skillAuthor with extensionVersion in skill provenance telemetry

* Add skill telemetry tests for skillLoadedIntoContext events

* Send extensionVersion and pluginVersion as plain text instead of hashed

* Address PR review feedback: use ResourceMap for URI keys, remove skillContentHash, simplify plugin lookup

* Add try/catch for fire-and-forget telemetry, add extension/plugin provenance test

* Clearing out an unused import.

* update, avoid new IAgentSkillProvenance type

* use cheap hash

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Martin Aeschlimann <martinae@microsoft.com>
2026-03-27 10:17:00 +00:00
Isidor Nikolic
7c89420b96 Remove ChatAgentVoteDownReason and voteDownReason (#304878)
Remove the ChatAgentVoteDownReason enum and all voteDownReason
references from the model, view model, service, telemetry, and
UI layers. Fix snapshot test ordering to maintain backward compat
for the voteDownReason field position.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-27 11:01:26 +01:00
Benjamin Christopher Simmonds
9986a4378e Merge pull request #305569 from microsoft/benibenj/unusual-iguana
Use new session icon for add chat action
2026-03-27 10:45:08 +01:00
Isidor Nikolic
9c09f68f1b Merge pull request #305156 from microsoft/isidorn/private-pig
feat(telemetry): log terminal sandbox setting changes
2026-03-27 10:12:04 +01:00
BeniBenj
1049842e28 use new session icon instead of plus for add chat action 2026-03-27 10:05:10 +01:00
Matt Bierner
87d56f7104 Merge pull request #305550 from mjbvz/dev/mjbvz/tense-dragon
Use `areUrisEqual` helper for better uri checks
2026-03-27 01:01:26 -07:00
Matt Bierner
e54bc08fda Merge pull request #305548 from mjbvz/dev/mjbvz/related-rat
Also default to treating macos as case insensitive for md file checks
2026-03-27 00:58:57 -07:00
Matt Bierner
bd5b480c23 Use areUrisEqual helper for better uri checks 2026-03-27 00:42:39 -07:00
Justin Chen
3b3b067a1d make tool call confirmation content LARGER (#305538) 2026-03-27 07:39:51 +00:00
Matt Bierner
5f966ed2ed Also default to treating macos as case insensitive for md file checks 2026-03-27 00:38:30 -07:00
Copilot
e78b8ebc62 Fix inconsistent capitalization in permissions learn-more string (#305535)
* Initial plan

* Fix inconsistent capitalization: "Learn More about Permissions" → "Learn more about permissions"

Agent-Logs-Url: https://github.com/microsoft/vscode/sessions/23fe2cf9-916b-4fea-b014-2d98f21d2386

Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: justschen <54879025+justschen@users.noreply.github.com>
2026-03-27 07:38:16 +00:00
Justin Chen
d6638bd41d fix some thinking content rendering for edits + lazy markdown not rendering (#305531)
* fix some thinking content rendering

* don't skip hasValue
2026-03-27 08:37:22 +01:00
Matt Bierner
ddf0a3f8c6 Merge pull request #300691 from microsoft/copilot/fix-floating-window-focus-issue
Use container's window for ContextView viewport calculations
2026-03-27 00:26:46 -07:00
Benjamin Pasero
d1058a088d debt - clean up some todos (#305530) 2026-03-27 06:45:20 +00:00
xingsy97
befae3eaff timeline: fix memory leak when toggling pane visibility (#304668)
* timeline: dispose previous visibility subscriptions before recreating

* retrigger CI

---------

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2026-03-27 07:10:14 +01:00
Megan Rogge
3bafa7dc2a fix for chat tips (#304899)
fixes #303283
2026-03-27 05:51:59 +00:00
dileepyavan
6afe980a82 Preserve $TMPDIR when retrying terminal commands outside the sandbox (#304601)
* Changes to include environment variables for retry without sandboxing

* adding e2e tests

* fixing code formatting
2026-03-27 05:49:29 +00:00
Connor Peet
1d62cc626a agentPlugins: normalize to user data dir storage (#304977)
* agentPlugins: normalize to user data dir storage

Previously we stored plugins in a very internal way that was inaccessible
by other tooling. This sets up a `agent-plugins` folder beside `extensions`
and creates an `installed.json` which is easy to integrate with.

* comments

* fix compile

---------

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2026-03-27 05:46:59 +00:00
Yogeshwaran C
228f1b6987 Merge pull request #304959 from yogeshwaran-c/fix/testing-icon-color-inheritance
fix: make testing icon colors inherit from list error/warning foreground
2026-03-27 05:46:35 +00:00
Rob Lourens
248457df06 Adopt ISessionsProvider for remote agent hosts (#305353)
* Adopt ISessionsProvider for remote agent hosts

Co-authored-by: Copilot <copilot@github.com>

* fixes

Co-authored-by: Copilot <copilot@github.com>

* clean up

Co-authored-by: Copilot <copilot@github.com>

* Restore sendRequest

Co-authored-by: Copilot <copilot@github.com>

---------

Co-authored-by: Copilot <copilot@github.com>
2026-03-27 03:48:14 +00:00
Matt Bierner
93ca9c0929 Merge pull request #304958 from yogeshwaran-c/fix/image-preview-checkerboard-triangles
fix: use conic-gradient for image preview transparency checkerboard
2026-03-26 20:16:01 -07:00
Matt Bierner
c1a61a470d Merge branch 'main' into copilot/fix-floating-window-focus-issue 2026-03-26 20:14:35 -07:00
Josh Spicer
d7c19c5af6 chat: replace chatSessionCustomizations with chatSessionCustomizationProvider API (#303017)
* feat: add chat.registerCustomizationProvider extension API

Introduces a new proposed extension API (chatCustomizationProvider) that
enables extensions to register as customization providers for the AI
Customization UI. This replaces core-based harness filtering with
extension-driven discovery.

Key changes:
- New proposed API: vscode.proposed.chatCustomizationProvider.d.ts
  - ChatCustomizationProvider, ChatCustomizationItem, ChatCustomizationType
  - chat.registerCustomizationProvider(id, metadata, provider)
- ExtHost/MainThread RPC bridge for provider registration
- ICustomizationHarnessService extended with registerExternalHarness()
  for dynamic harness registration from extensions
- IHarnessDescriptor.itemProvider for extension-driven item discovery
- AICustomizationListWidget falls through to provider when active
  harness has an itemProvider
- Unit tests for dynamic harness registration and lifecycle

The static CLI/Claude harness descriptors remain as fallback until
extensions adopt the new API.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address code review issues

- Register chatCustomizationProvider in extensionsApiProposals.ts
- Fix duplicate 'descriptor' variable in fetchItemsForSection
- Add missing IExternalCustomizationItemProvider import

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: make management editor reactive to dynamic harness registration

- Track availableHarnesses in autorun (not just activeHarness)
- Add ensureHarnessDropdown() to lazily create/remove the dropdown
  when harnesses are dynamically registered/unregistered
- Store sidebarContent and harnessDropdownContainer refs for
  dynamic dropdown management

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: address API review feedback for ChatCustomizationProvider

- Replace ChatCustomizationType enum with TaskGroup-style class pattern
  (static instances with string-backed ids, extensible via constructor)
- Rename provideCustomizations → provideChatCustomizations to match
  VS Code provider naming conventions
- Add comprehensive JSDoc explaining customization lifecycle and
  caching semantics (cached until onDidChange fires)
- Simplify type converter to use class id directly
- Bump proposal version to 2

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: quality improvements for ChatCustomizationProvider plumbing

- Skip storage-based grouping for provider-backed items in the
  customization list widget. External providers manage their own
  items, so Workspace/User/Extension categories don't apply —
  render a flat sorted list instead.
- Use AICustomizationManagementSection constants instead of
  hardcoded string literals in hiddenSections mapping.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: make storage optional on IAICustomizationListItem

External provider items don't have a storage origin — the provider
manages discovery, so Workspace/User/Extension categories don't
apply. Make the storage field optional:

- Provider items omit storage entirely (no fake PromptsStorage.local)
- Context key overlay only sets storage key when present
- Management editor falls back gracefully for provider items
- Debug panel accepts optional storage
- Built-in path (promptsService) is unchanged — items always have storage

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: include external provider data in customization debug report

When the active harness has an external provider, the debug report
now shows the provider's raw items grouped by type, with name, URI,
and description for each item, plus a count of items matching the
current section. The promptsService stages are skipped since they
don't apply to provider-backed harnesses.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* refactor: rename ChatCustomization → ChatSessionCustomization per API review

Renames all types, methods, events, DTOs, and the proposal file to use
the ChatSession prefix as requested in API review feedback.

- ChatCustomizationType → ChatSessionCustomizationType
- ChatCustomizationItem → ChatSessionCustomizationItem
- ChatCustomizationProvider → ChatSessionCustomizationProvider
- provideChatCustomizations → provideChatSessionCustomizations
- onDidChangeChatCustomizations → onDidChangeChatSessionCustomizations
- registerCustomizationProvider → registerChatSessionCustomizationProvider
- Proposal: chatCustomizationProvider → chatSessionCustomizationProvider

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: resolve rebase conflicts and remove old ChatSessionCustomizations API

Remove the old group-based ChatSessionCustomizations API from the merged
PR #304532, which is superseded by our new ChatSessionCustomizationProvider
API. The old API used groups, storageLocation, and commands on the
chatSessionsService path; the new API uses a flat item model on the
customizationHarnessService path.

Removed:
- IChatSessionCustomizationItem/Group DTOs from extHost.protocol.ts
- registerChatSessionCustomizationsProvider from extHostChatSessions.ts,
  mainThreadChatSessions.ts, extHost.api.impl.ts, chatSessionsProvider.d.ts
- ChatSessionCustomizations converter namespace from extHostTypeConverters.ts
- mapProviderItemToListItem and old group command fields from list widget

Fixed:
- registerContributedHarness → registerExternalHarness in fixtures and
  mainThreadChatSessions.ts
- Missing AGENT_MD_FILENAME import in customizationHarnessService.ts
- Constructor arg mismatch in browser customizationHarnessService.ts

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: remove version number from new chatSessionCustomizationProvider proposal

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: rename id → chatSessionType in registerChatSessionCustomizationProvider

Aligns the parameter name with the chatSessions API convention.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: add AICustomizationManagementCreateMenuId for extension create actions

Extensions can now contribute create/add button actions to the
customizations management editor via contributes.menus targeting
'AICustomizationManagementCreate'. Use the aiCustomizationManagementSection
context key to scope commands to specific sections (agents, skills, etc.).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: register chat/customizations/create as extension menu contribution point

Extensions contribute to 'chat/customizations/create' in package.json
contributes.menus, gated by chatSessionCustomizationProvider proposal.
Uses MenuId.for() to avoid cross-layer import.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat: scope create menu to active harness, replace built-in actions

Add aiCustomizationManagementHarness context key set to the active
harness ID. Extensions scope create menu contributions using
'when: aiCustomizationManagementHarness == myHarness'.

When a harness has menu-contributed create actions, they fully replace
the built-in create buttons for that section.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address code review feedback

- Provider items without storage are now read-only (not editable/deletable)
- Wrap provideChatSessionCustomizations in try/catch to handle extension errors
- Use menuItem.run() instead of commandService.executeCommand for menu actions

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: gate customization provider registration on kill-switch setting

Registration is now blocked when chat.customizations.providerApi.enabled
is false (default), preventing providers from affecting the UI.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-27 13:42:19 +11:00
Sandeep Somavarapu
79c45657c3 sessions: rename "No Workspace" group to "Unknown" (#305352)
Update session grouping label from "No Workspace" to "Unknown"
2026-03-26 19:15:54 -07:00
Rob Lourens
5d35a554d5 Add multi-client agent host integration tests (#304867)
Add 7 new tests covering multi-client scenarios:
- sessionAdded/sessionRemoved notifications broadcast to all clients
- Cross-client message dispatch (client B sends on client A's session)
- Full tool progress updates delivered to both subscribers
- Action scoping: unsubscribed client gets no actions but still gets notifications
- Late subscriber gets current state via snapshot
- Cross-client permission flow (client B confirms tool started by client A)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-26 19:15:44 -07:00
Don Jayamanne
e1ab55e121 feat: add full reference name support for language model tools and related API updates (#304948)
* feat: add full reference name support for language model tools and related API updates

* Updates

* Updates

* Updates

* Updates

* Bump version number

* Updates

* Udpates

---------

Co-authored-by: Raymond Zhao <7199958+rzhao271@users.noreply.github.com>
2026-03-27 11:46:22 +11:00
Josh Spicer
201c439f3b sessions: convert built-in prompts to skills and add UI Integration badge (#305347)
* sessions: convert built-in prompts to skills and add UI Integration badge

- Move all 6 built-in prompts from vs/sessions/prompts/ to
  vs/sessions/skills/{name}/SKILL.md with proper frontmatter
- Remove the built-in prompt discovery system (discoverBuiltinPrompts,
  getBuiltinPromptFiles, BUILTIN_PROMPTS_URI) from AgenticPromptsService
- Simplify listPromptFiles/listPromptFilesForStorage to only handle
  skills as the built-in type
- Add getSkillUIIntegrations() to IAICustomizationWorkspaceService
  interface, returning a map of skill names with UI surface connections
- Sessions implementation maps act-on-feedback (Submit Feedback button)
  and generate-run-commands (Run button) to tooltips
- Show 'UI Integration' badge in the customizations editor for skills
  that drive UI surfaces, including user overrides of those skills
- Update AI_CUSTOMIZATIONS.md to reflect the simplified architecture

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* address review feedback: stable folder-name lookup, safe builtin fallback, shared empty map

- Use basename(dirname(skill.uri)) instead of skill.name for UI
  integration lookup so badge persists even if frontmatter name changes
- Return [] for BUILTIN_STORAGE on non-skill types instead of
  delegating to super (which would throw)
- Use a shared static empty map in the core VS Code implementation to
  avoid repeated allocations

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* add built-in skills with UI integration badges for sessions

* add missing UI Integration mappings for all toolbar-connected skills

Add create-pr, create-draft-pr, update-pr, merge-changes, and commit
to the skill UI integrations map. These are all triggered by buttons
in the Changes toolbar.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
2026-03-26 17:08:50 -07:00
Ladislau Szomoru
6e1a95ed84 Sessions - polish changes filter action (#305357)
* Sessions - polish changes filter action

* Apply suggestion from @Copilot

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-03-26 23:53:29 +00:00