Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-02-20 17:59:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add extra PNP string to settings

Browse Source 
Co-authored-by: Fedor Indutny <79877362+indutny-signal@users.noreply.github.com>
This commit is contained in:
automated-signal
2024-02-06 13:41:44 -06:00
committed by GitHub
parent 1cf640f74e
commit 4f249f690c
2 changed files with 22 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
_locales/en/messages.json
View File

@@ -5844,8 +5844,12 @@
"description": "Description for the phone number sharing setting row when the value is Everyone"
},
"icu:Preferences__pnp__sharing--description--nobody": {
"messageformat": "Nobody will see your phone number on Signal, even when you're messaging them.",
"description": "Description for the phone number sharing setting row when the value is Nobody"
"messageformat": "Your phone number will not be visible to anyone unless they have it saved in their phone’s contacts.",
"description": "Description for the phone number sharing setting row when the value is Nobody and phone number discoverability setting is Everyone"
},
"icu:Preferences__pnp__sharing--description--nobody--not-discoverable": {
"messageformat": "Your phone number will not be visible to anyone.",
"description": "Description for the phone number sharing setting row when the value is Nobody and phone number discoverability setting is Nobody"
},
"icu:Preferences__pnp--page-title": {
"messageformat": "Phone Number",

21
ts/components/Preferences.tsx
View File

@@ -1422,6 +1422,21 @@ export function Preferences({
</>
);
} else if (page === Page.PNP) {
let sharingDescription: string;
if (whoCanSeeMe === PhoneNumberSharingMode.Everybody) {
sharingDescription = i18n(
'icu:Preferences__pnp__sharing--description--everyone'
);
} else if (whoCanFindMe === PhoneNumberDiscoverability.Discoverable) {
sharingDescription = i18n(
'icu:Preferences__pnp__sharing--description--nobody'
);
} else {
sharingDescription = i18n(
'icu:Preferences__pnp__sharing--description--nobody--not-discoverable'
);
}
settings = (
<>
<div className="Preferences__title">
@@ -1458,11 +1473,7 @@ export function Preferences({
value={whoCanSeeMe}
/>
<div className="Preferences__padding">
<div className="Preferences__description">
{whoCanSeeMe === PhoneNumberSharingMode.Everybody
? i18n('icu:Preferences__pnp__sharing--description--everyone')
: i18n('icu:Preferences__pnp__sharing--description--nobody')}
</div>
<div className="Preferences__description">{sharingDescription}</div>
</div>
</SettingsRow>