Signal/Desktop
1
0
Fork 0
mirror of https://github.com/signalapp/Signal-Desktop.git synced 2026-02-15 07:28:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix pin message dialog submit with no warning step

Browse Source
This commit is contained in:
Jamie
2026-01-21 12:06:26 -08:00
committed by GitHub
parent a801862ef0
commit bf2b257736
1 changed files with 14 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
ts/components/conversation/pinned-messages/PinMessageDialog.dom.tsx
View File

@@ -93,34 +93,34 @@ export const PinMessageDialog = memo(function PinMessageDialog(
[onOpenChange]
);
const submit = useCallback(() => {
strictAssert(
duration != null,
'Duration should not be null when submitting'
);
const durationValue = DURATION_OPTIONS[duration];
onPinnedMessageAdd(messageId, durationValue);
handleOpenChange(false);
}, [onPinnedMessageAdd, messageId, duration, handleOpenChange]);
const submit = useCallback(
(selectedDuration: DurationOption) => {
const durationValue = DURATION_OPTIONS[selectedDuration];
onPinnedMessageAdd(messageId, durationValue);
handleOpenChange(false);
},
[onPinnedMessageAdd, messageId, handleOpenChange]
);
const handleConfirmReplaceOldestPin = useCallback(() => {
setConfirmedReplaceOldestPin(true);
}, []);
const handleSelectDuration = useCallback(
(selected: DurationOption) => {
setDuration(selected);
(selectedDuration: DurationOption) => {
setDuration(selectedDuration);
if (!needsConfirmDisappearingMessages) {
submit();
submit(selectedDuration);
}
},
[needsConfirmDisappearingMessages, submit]
);
const handleConfirmDisappearingMessages = useCallback(() => {
strictAssert(duration != null, 'Duration should not be null');
onSeenPinMessageDisappearingMessagesWarning();
submit();
}, [onSeenPinMessageDisappearingMessagesWarning, submit]);
submit(duration);
}, [onSeenPinMessageDisappearingMessagesWarning, duration, submit]);
let step: Step;
if (!props.open) {