Benjamin Pasero
1602957aa2
debt - remove no longer needed code
2019-10-05 08:10:21 +02:00
Matt Bierner
45c4f22894
Fixing more issues related to #81574
2019-10-04 17:57:33 -07:00
Daniel Imms
7f5a4a3f5b
Fix strictFunctionTypes errors in terminal proxy
...
Part of #81574
2019-10-04 17:39:05 -07:00
Daniel Imms
a0c6566f87
Fix strictFunctionTypes errors in terminalService
...
Part of #81574
2019-10-04 16:34:23 -07:00
Daniel Imms
4ddddcfb6d
Fix strictFunctionTypes errors in terminalInstance
...
Part of #81574
2019-10-04 16:34:22 -07:00
Matt Bierner
dc0ab50035
Use isEqual for comparing uris in more places vs .toString()
2019-10-04 15:22:42 -07:00
Matt Bierner
7e70b1dda0
Mark that preferredEncoding can be undefined / not initialized
...
Part of #78168
2019-10-04 14:58:42 -07:00
Matt Bierner
92514c469c
Fix a few more issues related to #81574
2019-10-04 14:25:55 -07:00
Matt Bierner
30120e4db6
Dont pass undefined as boolean
...
For #81574
2019-10-04 14:11:52 -07:00
Matt Bierner
831800d6d8
Make sure we also change webview theme data when editor config changes
2019-10-04 13:56:14 -07:00
Matt Bierner
b9693027bb
Use switch case
2019-10-04 13:43:08 -07:00
Matt Bierner
7f044c7903
Memoize webview theme data
...
Fixes #81788
2019-10-04 13:42:04 -07:00
Matt Bierner
41a26f0322
Fixing some TS 3.7 dom typing errors
...
TS 3.7 changes the many dom style typings to just be `string` instead of `string | null`. Use empty string in place of null for these cases
2019-10-04 13:18:07 -07:00
Miguel Solorio
94c9c09627
Update syntax
2019-10-04 09:20:09 -07:00
Johannes Rieken
c06c223ee9
more strict init work
2019-10-04 11:52:05 +02:00
Benjamin Pasero
c8252b63f5
Revert "fixes #80054 " ( #81942 )
...
This reverts commit d591cb7e6d .
2019-10-04 10:43:55 +02:00
Miguel Solorio
c836d5ae38
Include icons in the extension viewlet
2019-10-03 14:04:51 -07:00
Matt Bierner
d3eb24828e
Use strict compare for checking if an editor is active/visible
...
Fixes #81889
Using `.matches` can cause a custom editor to match all custom editors for that resource. Use a strict compare instead.
2019-10-03 13:53:30 -07:00
Matt Bierner
eacd477ea9
Only reuse existing custom editor input if we are opening an editor in the same group
2019-10-03 13:46:31 -07:00
Miguel Solorio
c7650e66b2
Merge remote-tracking branch 'origin/master' into misolori/icon-font-problems
2019-10-03 12:39:15 -07:00
Miguel Solorio
6a62058aae
Cleanup dead code
2019-10-03 12:36:11 -07:00
Pine Wu
8266e1c67b
Fix #81843
2019-10-03 12:05:21 -07:00
Miguel Solorio
17db07b22c
Adopt icon font in problems panel and error peek view
2019-10-03 11:36:11 -07:00
Matt Bierner
9a8f867129
Use name for custom editor title for data uri resources
...
Fixes #81791
2019-10-03 11:30:45 -07:00
Pine Wu
355676f84f
Fix #79840
2019-10-03 09:50:55 -07:00
Alex Ross
8892774174
Fix configuration resolver test
2019-10-03 17:22:18 +02:00
isidor
58c72545cd
explorer: add decoration provider to disposables
...
microsoft/vscode-remote-release#1598
2019-10-03 17:15:58 +02:00
Alex Ross
e0729a52ab
Fix to many messages whn cancelling resolution of contributed variables
...
Fixes https://github.com/microsoft/vscode/issues/81767
2019-10-03 17:09:16 +02:00
Johannes Rieken
53d6601137
strict init
2019-10-03 16:51:03 +02:00
Alex Ross
6ff7bf27c9
Fix settings conflict when opening files locally
...
Fixes https://github.com/microsoft/vscode-remote-release/issues/980
2019-10-03 14:52:59 +02:00
Benjamin Pasero
6bbe006248
💄 telemetry opt out
2019-10-03 11:12:27 +02:00
Benjamin Pasero
84391a4685
remove product.welcomePage
2019-10-03 10:20:19 +02:00
isidor
3b5e571ef5
fixes #81868
2019-10-03 08:57:30 +02:00
Matt Bierner
10309701ff
Don't show webview overlay by default
...
If there is an error while resolving the webview itself, this invisible container can end sticking around incorrectly until the input it destoryed. Better to make sure it is hidden so that it doesn't block user input
2019-10-02 18:17:33 -07:00
Matt Bierner
2cf9921ee5
Fixing name and description for custom editor on data uris
2019-10-02 14:30:35 -07:00
Matt Bierner
d91209b356
Fix image views not being activated properly
2019-10-02 14:13:01 -07:00
Rob Lourens
790c574ce4
Fix microsoft/vscode-remote-release#1573
2019-10-02 13:34:58 -07:00
SteVen Batten
e2f1ee3573
fixes #81838
2019-10-02 10:58:01 -07:00
Matt Bierner
e5557b7e6e
Reapply c057a4b9c7
...
Fixes integration tests
2019-10-02 10:35:11 -07:00
isidor
ab529dcd83
fixes #81852
2019-10-02 17:44:55 +02:00
Joao Moreno
0f4875f5e7
fixes #81846
2019-10-02 16:56:08 +02:00
isidor
2943151b3a
fixes #81567
2019-10-02 16:37:33 +02:00
Alex Ross
1e7a92b119
Fix double prompting for default build task when canceled
...
Fixes #81767
2019-10-02 16:14:50 +02:00
Sandeep Somavarapu
2f06eb9855
Fix #79116
2019-10-02 16:08:04 +02:00
isidor
a8a448d166
fixes #77837
2019-10-02 15:55:18 +02:00
Benjamin Pasero
fb10f85b4c
fix #81653
2019-10-02 15:45:08 +02:00
Alex Ross
1d8037c63c
Update default build task placeholder text for defaultBuildTask variable
...
Fixes https://github.com/microsoft/vscode/issues/81817
2019-10-02 15:36:09 +02:00
Benjamin Pasero
a8fc2bd9be
fix #81763
2019-10-02 15:27:10 +02:00
Joao Moreno
d09090927e
fixes #81731
2019-10-02 14:52:07 +02:00
Benjamin Pasero
c5e2892b29
urls - add option to disable confirm dialog
2019-10-02 14:38:37 +02:00