Commit Graph

29676 Commits

Author SHA1 Message Date
Benjamin Pasero
f8cdbe7421 host - reduce methods that are required 2019-09-30 11:32:31 +02:00
Fuchen Shi
7e18b80180 Merge branch 'master' into typo 2019-09-28 13:39:17 -07:00
Matt Bierner
f2d41726ba Mark that preferredMode can be undefined
As part of the fix for #81574, I discovered that a large number of callers were already passing `undefined` for this value. This fix just marks the type as possibly undefined as well
2019-09-27 17:58:30 -07:00
Matt Bierner
3dc33a7901 Extract constant 2019-09-27 17:58:30 -07:00
Fuchen Shi
3160940d25 Fix typo in batch replacement pop-up 2019-09-27 16:05:27 -07:00
Miguel Solorio
a939a80c4a Center gear icon 2019-09-27 14:07:13 -07:00
Miguel Solorio
9b3c041552 Center icon actions 2019-09-27 14:04:53 -07:00
Miguel Solorio
cedc081e73 Remove dead styles 2019-09-27 14:03:56 -07:00
Miguel Solorio
4b16948148 Allows icons to inherit color 2019-09-27 13:57:12 -07:00
Miguel Solorio
7292718c5e Adopt icon font in settings 2019-09-27 13:45:56 -07:00
Miguel Solorio
6f070c5a35 Update icons in Keybindings editor 2019-09-27 11:18:18 -07:00
Rob Lourens
62f6fe49c3 Hide settings editor row highlight interaction with editor focus outline
Partially fix #81564
2019-09-27 10:48:13 -07:00
Sandeep Somavarapu
cfb8230a9e register platform services directly 2019-09-27 17:56:23 +02:00
Sandeep Somavarapu
e707a51d85 Merge branch 'sandy081/settingsSyncAuth' 2019-09-27 16:16:57 +02:00
Sandeep Somavarapu
39fa5f4f7d fix layering issue 2019-09-27 16:15:03 +02:00
Sandeep Somavarapu
82d5c682c5 - Add disablement state for auth token
- Extract user data sync workbench contribution
- Make actions, notifications & badge respect states correctly
2019-09-27 15:50:15 +02:00
Sandeep Somavarapu
1c865c7a9d notificiation to sign in 2019-09-27 14:38:16 +02:00
Benjamin Pasero
ad5e5815ab web - introduce workspace provider 2019-09-27 14:10:32 +02:00
Sandeep Somavarapu
64396bf622 adopt to auth token service 2019-09-27 12:48:25 +02:00
Sandeep Somavarapu
57484e5d2b Introduce auth token service 2019-09-27 12:47:55 +02:00
Benjamin Pasero
1f80e3954c debt - extract node only window options 2019-09-27 11:56:47 +02:00
Alex Ross
b0bfcce0e8 Wire up configuration of user and workspace tasks 2019-09-27 11:24:12 +02:00
Benjamin Pasero
3f7bd94525 debt - lift a few service implementations from platform to workbench 2019-09-27 11:06:53 +02:00
Benjamin Pasero
f39e5c3c13 fix build 2019-09-27 10:48:18 +02:00
Benjamin Pasero
0f6305f4b2 debt - adopt channel proxy for localizations 2019-09-27 10:16:02 +02:00
Benjamin Pasero
ad1a0e6d9f debt - move ipcChannelCreator into ipc.ts 2019-09-27 10:05:04 +02:00
Benjamin Pasero
f132464a79 debt - adopt proxy channel for URL channel 2019-09-27 09:58:18 +02:00
Benjamin Pasero
6ee1da3dc5 debt - shuffle things around 2019-09-27 09:44:35 +02:00
Benjamin Pasero
4e4cb81c57 debt - merge workspaces and history into one 2019-09-27 09:33:43 +02:00
Benjamin Pasero
fa9c39ae35 Web: update PWA theme_color dynamically based on theme 2019-09-27 07:43:17 +02:00
Matt Bierner
e0762af258 Move webview content state into webviewPanel instead of webviewEditor
Split out from #77131

The current webview editor api is very procedural. This model has some problems when it comes to supporting editing resources, but actually does make a lot of sense for webviews that aren't backed by real file system resources. For example, if you have a webview that edits some document in the cloud, you should not be required to implement a custom file system provider just to enable basic saving.

This change moves the `onWillSave` and `webviewEditorState` properties back onto `WebviewPanel` instead of keeping them specific to `WebviewEditor`. The save implementation does not fully work yet, as the will require #81521
2019-09-26 18:05:37 -07:00
Matt Bierner
9b1bc4f06a Remove unused properties 2019-09-26 16:37:28 -07:00
Matt Bierner
1ef51e2c0e Add explicit types 2019-09-26 16:34:48 -07:00
Matt Bierner
c9ee5111a2 Marking events readonly 2019-09-26 16:10:48 -07:00
Matt Bierner
06dedcd016 Prefer using isEqual over string compare of uris 2019-09-26 16:10:48 -07:00
Matt Bierner
1077b27ce7 Extract method 2019-09-26 16:10:48 -07:00
Matt Bierner
0fb42f7ab2 Draw shadow for diff view with custom editors 2019-09-26 16:10:48 -07:00
Matt Bierner
3974fee167 Bail early in mime check 2019-09-26 16:10:48 -07:00
Matt Bierner
d8748101e3 Use isEqual instead of string compare 2019-09-26 16:10:48 -07:00
Miguel Solorio
2c373c2aac Fix edit icon in keybindings 2019-09-26 14:26:21 -07:00
Miguel Solorio
ff63dd119b Fix #81491, rotate splut terminal icon when panel is on right 2019-09-26 14:13:34 -07:00
SteVen Batten
bfcc5ad1cc no background change for compact menubar 2019-09-26 12:24:05 -07:00
Miguel Solorio
ff8614ec6c Merge branch 'master' into misolori/octicons 2019-09-26 11:59:55 -07:00
Rob Lourens
af76be4405 Rename remoteAuthority to remoteName for views contribution point 2019-09-26 11:17:36 -07:00
Benjamin Pasero
e193a680e3 debt - reduce isWeb usages 2019-09-26 19:01:58 +02:00
Benjamin Pasero
136dbe9e20 debt - move native dialog options 2019-09-26 19:01:58 +02:00
Benjamin Pasero
64eed745f5 💄 move a few services around 2019-09-26 18:37:58 +02:00
Miguel Solorio
199aa4f22a Inherit color for search viewlet icons 2019-09-26 09:37:24 -07:00
Benjamin Pasero
a3801764e3 💄 move things around 2019-09-26 18:16:29 +02:00
Miguel Solorio
ba3613e903 Update Octicons to new style 2019-09-26 09:15:15 -07:00