Commit Graph

29676 Commits

Author SHA1 Message Date
isidor
888f86f156 null guard 2019-10-02 14:26:22 +02:00
Johannes Rieken
741323bbb7 fix #81323 2019-10-02 12:41:17 +02:00
isidor
1f70a46308 fixes #81715 2019-10-02 11:59:52 +02:00
Joao Moreno
ff42be5d56 remove 64 bit suggestion
fixes #81792
2019-10-02 10:42:51 +02:00
Matt Bierner
8eaec303ea Revert "Make sure we dispose of any custom editor inputs when replacing them"
This reverts commit c057a4b9c7.
2019-10-01 21:50:08 -07:00
Matt Bierner
c057a4b9c7 Make sure we dispose of any custom editor inputs when replacing them
Fixes #81773
2019-10-01 17:09:46 -07:00
Matt Bierner
f735e062f3 Rename custom editors discretion to priority
Fixes #81785
2019-10-01 16:39:30 -07:00
Matt Bierner
214ee89df0 Use isEqual instead of tostring compare 2019-10-01 15:05:22 -07:00
Matt Bierner
af070ee0a0 Move custom editor extension activation out of input
Inputs should not need to know about extensions
2019-10-01 15:05:22 -07:00
Matt Bierner
64023bd18b Show loading indicator while a custom editor is resolving
Part of #81740
2019-10-01 15:05:22 -07:00
Miguel Solorio
ccf0a56243 Fix #81704 2019-10-01 14:49:44 -07:00
Daniel Imms
dc5a137ec4 Use US English in settings sync 2019-10-01 14:08:37 -07:00
Matt Bierner
f96527a7bd Document mime for custom editor selectors
Fixes #81789
2019-10-01 14:03:24 -07:00
Miguel Solorio
197c7f2718 Fix #81701 2019-10-01 12:58:46 -07:00
SteVen Batten
9341df363a add cancel id for custom dialog 2019-10-01 11:36:42 -07:00
Johannes Rieken
e520a1bcef make sure all, not some, decorations are unused before removing its css rule, #81467 2019-10-01 18:14:20 +02:00
Benjamin Pasero
20876ae53b telemetry - fix broken opt out 2019-10-01 12:10:38 +02:00
Matt Bierner
313ede61cb Also remove extHostWebview side of the api proposal for webview editor state/save 2019-09-30 20:36:21 -07:00
Matt Bierner
71c95a466f Disable open with command for now
It needs more polishing and should probably only be enabled for files that may have custom editors enabled
2019-09-30 20:15:34 -07:00
Matt Bierner
2aea209a3e Add fallback for invalid signature help data structure
Fixes #80617

Some extensions may provide us with bad data types (if they are js or don't have strict null enabled for example). Try to be more careful about handling such cases by falling back to an empty array instead of undefined
2019-09-30 16:10:18 -07:00
Matt Bierner
1c215ef3f6 Try different name for default editor
Fixes #80777
2019-09-30 16:03:16 -07:00
Rob Lourens
f832acfbd9 Settings editor fixes
- Fix keyboard shortcut to show context menu
- Fix showing gear icon when settings row is focused
2019-09-30 15:15:49 -07:00
Miguel Solorio
48e1250e2f Fix #81690 2019-09-30 15:09:49 -07:00
Rob Lourens
df0953c045 Fix setting row colors
Remove focus outline on settings editor. It's not tabbable so it doesn't serve any purpose and is annoying to see every time I click on the editor background. Just need to keep .editor-instance from getting focus on click.
Fix #81675
2019-09-30 14:41:58 -07:00
Matt Bierner
e904a5f646 Warn development webview extensions that use vscode-resource uris directly
Fixes #81685
2019-09-30 14:22:47 -07:00
Matt Bierner
8079ff0001 Rename resolveExternalUri to asExternalUri
#81131
2019-09-30 14:22:47 -07:00
Matt Bierner
3ae6f0bf93 Annotate that preferredEncoding can be undefined
Discovered as part of #81574
2019-09-30 14:22:47 -07:00
Miguel Solorio
b8a75a33dd Fix #81573, show beak in status bar 2019-09-30 12:17:57 -07:00
Miguel Solorio
3f3a9e30db Fix #81536, center git decorations 2019-09-30 11:42:36 -07:00
Miguel Solorio
2c704846d6 Show correct icon in HC mode for adding breakpoints 2019-09-30 10:46:24 -07:00
Miguel Solorio
83cd86bb36 Fix #81649, show collapse icon in debug viewlet 2019-09-30 10:45:44 -07:00
Miguel Solorio
3611cc7d07 Show collapse icon in Problems panel 2019-09-30 10:23:48 -07:00
Miguel Solorio
d26bc6e7d5 Fix #81662 2019-09-30 10:19:19 -07:00
Sandeep Somavarapu
5f8dec837f enable auth by config 2019-09-30 17:51:34 +02:00
Alexandru Dima
2de9a3629f Fixes #72798: Transport other error types (not just instances of Error) 2019-09-30 16:43:14 +02:00
Alexandru Dima
fe9e05d8d7 Adopt ILogger.flush() (#80862) 2019-09-30 16:26:16 +02:00
Alexandru Dima
215df67b0f Try to use the remote port number locally (microsoft/vscode-remote-release#1115) 2019-09-30 16:20:33 +02:00
Johannes Rieken
111c29c085 Merge pull request #80895 from mjbvz/use-const-enums-for-suggest-dto
Use const enums for minimized ISuggestDataDto field names
2019-09-30 15:34:48 +02:00
Sandeep Somavarapu
79978f96d3 Fix #81152 2019-09-30 15:31:04 +02:00
Benjamin Pasero
6b3006104a debt - if one workbench contribution fails to load, do not fail to load all others 2019-09-30 15:30:49 +02:00
Alex Ross
0e8d8e2d60 Move built task keybinding registration earlier
Fixes https://github.com/microsoft/vscode/issues/81552
2019-09-30 15:14:31 +02:00
Joao Moreno
501416814e fixes #80816 2019-09-30 15:12:42 +02:00
Benjamin Pasero
da76f05e7a electron - revert to Electron 4 2019-09-30 14:55:17 +02:00
Martin Aeschlimann
8d9356eaa5 Telemetry when exe recommendation is already installed 2019-09-30 14:44:23 +02:00
isidor
c2997da2ac Gesture.addTarget returns an IDisposable
fixes #81630
2019-09-30 14:42:58 +02:00
Johannes Rieken
5c3ac79b01 fix "extension slow" link 2019-09-30 14:22:24 +02:00
Sandeep Somavarapu
42846298e2 Fix #81468 2019-09-30 13:04:54 +02:00
Benjamin Pasero
205b617cac web - implement text input actions too 2019-09-30 12:48:00 +02:00
Sandeep Somavarapu
846cff1e8f Fix #80862 2019-09-30 12:20:34 +02:00
Benjamin Pasero
25fb4bcd78 debt - move enterWorkspace into workspace service 2019-09-30 11:35:50 +02:00